You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hop.apache.org by GitBox <gi...@apache.org> on 2021/01/03 00:13:13 UTC
[GitHub] [incubator-hop] mfgaspar opened a new pull request #528: HOP-2388: Use environment variable HOP_PLUGIN_BASE_FOLDERS to define …
mfgaspar opened a new pull request #528:
URL: https://github.com/apache/incubator-hop/pull/528
…the location of plugins folder
Following this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/HOP) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[HOP-XXX] - Fixes bug in SessionManager`,
where you replace `HOP-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like `(DOC) - Add javadoc in SessionManager`.
If this is your first contribution, you have to read the [Contribution Guidelines](https://hop.apache.org/community/contributing/)
If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf)
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mfgaspar commented on pull request #528: HOP-2388: Use environment variable HOP_PLUGIN_BASE_FOLDERS to define …
Posted by GitBox <gi...@apache.org>.
mfgaspar commented on pull request #528:
URL: https://github.com/apache/incubator-hop/pull/528#issuecomment-753996410
The idea was to get the value directly from the Environment Variable if defined instead of getting it from System Properties
System.getProperty vs System.getenv
But also good to have it from hop-config.json
To avoid System.getenv I could also do it similar to HOP_SHARED_JDBC_FOLDER in the shell scripts
if [ -n "${HOP_PLUGIN_BASE_FOLDERS}" ]; then
HOP_OPTIONS="${HOP_OPTIONS} -DHOP_PLUGIN_BASE_FOLDERS=${HOP_PLUGIN_BASE_FOLDERS}"
fi
How does that sounds ?
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mfgaspar closed pull request #528: HOP-2388: Use environment variable HOP_PLUGIN_BASE_FOLDERS to define …
Posted by GitBox <gi...@apache.org>.
mfgaspar closed pull request #528:
URL: https://github.com/apache/incubator-hop/pull/528
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mfgaspar commented on pull request #528: HOP-2388: Use environment variable HOP_PLUGIN_BASE_FOLDERS to define …
Posted by GitBox <gi...@apache.org>.
mfgaspar commented on pull request #528:
URL: https://github.com/apache/incubator-hop/pull/528#issuecomment-754012088
Will do it this way
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva commented on pull request #528: HOP-2388: Use environment variable HOP_PLUGIN_BASE_FOLDERS to define …
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #528:
URL: https://github.com/apache/incubator-hop/pull/528#issuecomment-754011151
I think for consistency reasons this will be the best, also if you have multiple versions of Hop running with different plugins you can override using the startup scripts, else you would be stuck with the one system variable available.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org