You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2015/03/03 12:06:26 UTC
Review Request 31676: Added documentation about the use of the
LIBPROCESS_DISABLED_ENDPOINTS environment variable.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31676/
-----------------------------------------------------------
Review request for mesos, Joerg Schad, Niklas Nielsen, and Till Toenshoff.
Bugs: mesos-2333
https://issues.apache.org/jira/browse/mesos-2333
Repository: mesos
Description
-------
Adds documentation on how to disable endpoints using `LIBPROCESS_DISABLED_ENDPOINTS`.
Diffs
-----
docs/configuration.md fc3afec248b534b1d5eb625eb66de5f90cd8cd33
Diff: https://reviews.apache.org/r/31676/diff/
Testing
-------
Thanks,
Alexander Rojas
Re: Review Request 31676: Added documentation about the use of the
LIBPROCESS_DISABLED_ENDPOINTS environment variable.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31676/#review74938
-----------------------------------------------------------
Patch looks great!
Reviews applied: [31227, 30994, 31228, 31676]
All tests passed.
- Mesos ReviewBot
On March 3, 2015, 11:06 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31676/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 11:06 a.m.)
>
>
> Review request for mesos, Joerg Schad, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: mesos-2333
> https://issues.apache.org/jira/browse/mesos-2333
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds documentation on how to disable endpoints using `LIBPROCESS_DISABLED_ENDPOINTS`.
>
>
> Diffs
> -----
>
> docs/configuration.md fc3afec248b534b1d5eb625eb66de5f90cd8cd33
>
> Diff: https://reviews.apache.org/r/31676/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 31676: Added documentation about the use of the
LIBPROCESS_DISABLED_ENDPOINTS environment variable.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31676/#review75683
-----------------------------------------------------------
Patch looks great!
Reviews applied: [31227, 30994, 31228, 31676]
All tests passed.
- Mesos ReviewBot
On March 9, 2015, 10:53 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31676/
> -----------------------------------------------------------
>
> (Updated March 9, 2015, 10:53 a.m.)
>
>
> Review request for mesos, Joerg Schad, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: mesos-2333
> https://issues.apache.org/jira/browse/mesos-2333
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds documentation on how to disable endpoints using `LIBPROCESS_DISABLED_ENDPOINTS`.
>
>
> Diffs
> -----
>
> docs/configuration.md fc3afec248b534b1d5eb625eb66de5f90cd8cd33
>
> Diff: https://reviews.apache.org/r/31676/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 31676: Added documentation about the use of the
LIBPROCESS_DISABLED_ENDPOINTS environment variable.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31676/#review78502
-----------------------------------------------------------
Patch looks great!
Reviews applied: [31228, 31676]
All tests passed.
- Mesos ReviewBot
On April 1, 2015, 9:47 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31676/
> -----------------------------------------------------------
>
> (Updated April 1, 2015, 9:47 a.m.)
>
>
> Review request for mesos, Joerg Schad, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: mesos-2333
> https://issues.apache.org/jira/browse/mesos-2333
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds documentation on how to disable endpoints using `LIBPROCESS_DISABLED_ENDPOINTS`.
>
>
> Diffs
> -----
>
> docs/configuration.md 54c4e31ed6dfed3c23d492c19a301ce119a0519b
>
> Diff: https://reviews.apache.org/r/31676/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 31676: Added documentation about the use of the
LIBPROCESS_DISABLED_ENDPOINTS environment variable.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31676/
-----------------------------------------------------------
(Updated April 1, 2015, 11:47 a.m.)
Review request for mesos, Joerg Schad, Niklas Nielsen, and Till Toenshoff.
Changes
-------
Endpoints disabling doesn't support wildcard matching anymore.
Bugs: mesos-2333
https://issues.apache.org/jira/browse/mesos-2333
Repository: mesos
Description
-------
Adds documentation on how to disable endpoints using `LIBPROCESS_DISABLED_ENDPOINTS`.
Diffs (updated)
-----
docs/configuration.md 54c4e31ed6dfed3c23d492c19a301ce119a0519b
Diff: https://reviews.apache.org/r/31676/diff/
Testing
-------
Thanks,
Alexander Rojas
Re: Review Request 31676: Added documentation about the use of the
LIBPROCESS_DISABLED_ENDPOINTS environment variable.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31676/
-----------------------------------------------------------
(Updated March 9, 2015, 11:53 a.m.)
Review request for mesos, Joerg Schad, Niklas Nielsen, and Till Toenshoff.
Changes
-------
More concise documentation.
Bugs: mesos-2333
https://issues.apache.org/jira/browse/mesos-2333
Repository: mesos
Description
-------
Adds documentation on how to disable endpoints using `LIBPROCESS_DISABLED_ENDPOINTS`.
Diffs (updated)
-----
docs/configuration.md fc3afec248b534b1d5eb625eb66de5f90cd8cd33
Diff: https://reviews.apache.org/r/31676/diff/
Testing
-------
Thanks,
Alexander Rojas
Re: Review Request 31676: Added documentation about the use of the
LIBPROCESS_DISABLED_ENDPOINTS environment variable.
Posted by Alexander Rojas <al...@mesosphere.io>.
> On March 6, 2015, 11:31 p.m., Niklas Nielsen wrote:
> > docs/configuration.md, line 1583
> > <https://reviews.apache.org/r/31676/diff/1/?file=882866#file882866line1583>
> >
> > Not yours, but we haven't documented the other LIBPROCESS environment variables. Mind creating a JIRA so we can get that done? :)
Added here: https://issues.apache.org/jira/browse/MESOS-2466
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31676/#review75554
-----------------------------------------------------------
On March 3, 2015, 12:06 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31676/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 12:06 p.m.)
>
>
> Review request for mesos, Joerg Schad, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: mesos-2333
> https://issues.apache.org/jira/browse/mesos-2333
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds documentation on how to disable endpoints using `LIBPROCESS_DISABLED_ENDPOINTS`.
>
>
> Diffs
> -----
>
> docs/configuration.md fc3afec248b534b1d5eb625eb66de5f90cd8cd33
>
> Diff: https://reviews.apache.org/r/31676/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 31676: Added documentation about the use of the
LIBPROCESS_DISABLED_ENDPOINTS environment variable.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31676/#review75554
-----------------------------------------------------------
docs/configuration.md
<https://reviews.apache.org/r/31676/#comment122739>
Not yours, but we haven't documented the other LIBPROCESS environment variables. Mind creating a JIRA so we can get that done? :)
docs/configuration.md
<https://reviews.apache.org/r/31676/#comment122741>
How about something like:
"A list of comma separated strings representing endpoints to be disabled, e.g. <code>processid1/handler,processid2/*</code>. The disabled endpoints will return HTTP 403 (forbidden)."
- Niklas Nielsen
On March 3, 2015, 3:06 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31676/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 3:06 a.m.)
>
>
> Review request for mesos, Joerg Schad, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: mesos-2333
> https://issues.apache.org/jira/browse/mesos-2333
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds documentation on how to disable endpoints using `LIBPROCESS_DISABLED_ENDPOINTS`.
>
>
> Diffs
> -----
>
> docs/configuration.md fc3afec248b534b1d5eb625eb66de5f90cd8cd33
>
> Diff: https://reviews.apache.org/r/31676/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Rojas
>
>