You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "LE0-Lin (via GitHub)" <gi...@apache.org> on 2026/08/20 13:21:23 UTC
[PR] Warn when inline gitSync SSH keys lack known hosts [airflow]
LE0-Lin opened a new pull request, #71883:
URL: https://github.com/apache/airflow/pull/71883
The Helm chart supports both a named `dags.gitSync.sshKeySecret` and an inline `dags.gitSync.sshKey` for SSH authentication. However, the post-install notes only warned about missing `knownHosts` configuration for the named-secret path, so inline-key users could miss the same host-verification warning.
Include both SSH key sources in the warning condition while continuing to suppress the warning when `knownHosts` is configured.
## Testing
- `breeze testing helm-tests --test-type airflow_aux -- -q` (`665 passed`)
- `prek run --files chart/templates/NOTES.txt --stage pre-commit`
- `helm lint chart` with Helm 3.19
- Helm 4 client-side dry-run matrix covering inline key, named secret, configured known hosts, and no SSH key
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Warn when inline gitSync SSH keys lack known hosts [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #71883:
URL: https://github.com/apache/airflow/pull/71883#issuecomment-5510942238
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Warn when inline gitSync SSH keys lack known hosts [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #71883:
URL: https://github.com/apache/airflow/pull/71883#issuecomment-5356468116
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Warn when inline gitSync SSH keys lack known hosts [airflow]
Posted by "LE0-Lin (via GitHub)" <gi...@apache.org>.
LE0-Lin commented on PR #71883:
URL: https://github.com/apache/airflow/pull/71883#issuecomment-5419397044
Thanks for pointing this out. I rebased the single change onto `chart/v1-2x-test` and updated the PR base accordingly. The resulting diff is still limited to `chart/templates/NOTES.txt`, and `helm lint chart` passes with Helm 3.19.
---
Drafted-by: Codex (GPT-5) (no human review before posting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Warn when inline gitSync SSH keys lack known hosts [airflow]
Posted by "Miretpl (via GitHub)" <gi...@apache.org>.
Miretpl merged PR #71883:
URL: https://github.com/apache/airflow/pull/71883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org