[GitHub] [pulsar-client-go] RobertIndie commented on pull request #1071: [Improve][Producer] Refactor internalSend() and resouce managment

["RobertIndie (via GitHub)" <gi...@apache.org>]

RobertIndie commented on PR #1071:
URL: https://github.com/apache/pulsar-client-go/pull/1071#issuecomment-1700729233

   I noticed that you did a lot of refactoring work in this PR, including changes to the critical path for publishing messages. I’m concerned that these changes may impact publishing performance.
   
   While there are many modifications, it’s difficult for the reviewer to see the relationship between these modifications and the bug fixes. Could you provide more detail in the PR description, particularly regarding why you’re making these changes to fix bugs?
   
   I recommend separating the refactoring work from the bug fixes. Otherwise, it will be challenging for us to cherry-pick the bug fixes to other release branches.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org