[GitHub] [flink-kubernetes-operator] SteNicholas commented on a change in pull request #46: [FLINK-26261] Introduce status and create event for terminal deployment error

[GitBox <gi...@apache.org>]

SteNicholas commented on a change in pull request #46:
URL: https://github.com/apache/flink-kubernetes-operator/pull/46#discussion_r821437181



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentController.java
##########
@@ -92,8 +94,11 @@ public DeleteControl cleanup(FlinkDeployment flinkApp, Context context) {
         LOG.info("Stopping cluster {}", flinkApp.getMetadata().getName());
         Configuration effectiveConfig =
                 FlinkUtils.getEffectiveConfig(flinkApp, defaultConfig.getFlinkConfig());
-
-        observer.observe(flinkApp, context, effectiveConfig);
+        try {
+            observer.observe(flinkApp, context, effectiveConfig);
+        } catch (DeploymentFailedException dfe) {

Review comment:
       Does this need to log the exception for the failure of deployment?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org