You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/10/31 21:06:27 UTC

[GitHub] [lucene] dweiss commented on a change in pull request #419: LUCENE-10200: store git revision in the release folder and read it back from buildAndPushRelease

dweiss commented on a change in pull request #419:
URL: https://github.com/apache/lucene/pull/419#discussion_r739876174



##########
File path: gradle/generation/kuromoji.gradle
##########
@@ -73,7 +73,10 @@ configure(project(":lucene:analysis:kuromoji")) {
         // Apply patch via local git.
         project.quietExec {
           workingDir = unpackedDir
-          executable "git" // TODO: better use jgit to apply patch, this is not portable!!!

Review comment:
       Piggybacking this unrelated change. It's only a comment reference to another issue.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org