[jira] [Created] (MESOS-9582) Reviewbot jenkins jobs stops validating any reviews as soon as it sees it patch which does not apply

["Benjamin Bannier (JIRA)" <ji...@apache.org>]

Benjamin Bannier created MESOS-9582:
---------------------------------------

             Summary: Reviewbot jenkins jobs stops validating any reviews as soon as it sees it patch which does not apply
                 Key: MESOS-9582
                 URL: https://issues.apache.org/jira/browse/MESOS-9582
             Project: Mesos
          Issue Type: Bug
          Components: reviewbot
            Reporter: Benjamin Bannier


The reviewbot Jenkins setup fetches all Mesos reviews since some time stamp, filters that list down to reviews which need to be validated, and then one by one validates each of the remaining review requests.

In doing that it applies patches with {{support/apply-reviews.py}} which is invoked by shelling out wth a function {{shell}} in {{support/verify-reviews.py}}. If that function sees any error from the shell command {{exit(1)}} is called which immediately terminates the Jenkins job.

As {{support/apply-reviews.py}} can fail if a patch does not apply cleanly anymore this means that any review requests which cannot be applied can largely disable reviewbot.

We should avoid calling {{exit}} in low-level functions in {{support/verify-reviews.py}} and instead bubble the error up to be handled at a larger scope. It looks like the script was alreadt designed to handle exceptions which might work much better here.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)