You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/19 14:18:41 UTC
[GitHub] [maven-doxia-sitetools] jdimeo opened a new pull request, #65: [DOXIASITETOOLS-268] - Improve performance by only loading the renderer version once during class initialization
jdimeo opened a new pull request, #65:
URL: https://github.com/apache/maven-doxia-sitetools/pull/65
Loading the version information on every file render significantly slows down the Doxia rendering phase. I observed at least a 10x speedup on 45k Markdown files by moving this resource loading to a static initialization block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] michael-o commented on pull request #65: [DOXIASITETOOLS-268] - Improve performance by only loading the renderer version once during class initialization
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #65:
URL: https://github.com/apache/maven-doxia-sitetools/pull/65#issuecomment-1284121607
Will take care of this this weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] asfgit closed pull request #65: [DOXIASITETOOLS-268] - Improve performance by only loading the renderer version once during class initialization
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #65: [DOXIASITETOOLS-268] - Improve performance by only loading the renderer version once during class initialization
URL: https://github.com/apache/maven-doxia-sitetools/pull/65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] jdimeo commented on pull request #65: [DOXIASITETOOLS-268] - Improve performance by only loading the renderer version once during class initialization
Posted by GitBox <gi...@apache.org>.
jdimeo commented on PR #65:
URL: https://github.com/apache/maven-doxia-sitetools/pull/65#issuecomment-1296366857
@michael-o thanks! yes, I did it to be as little change as the code as possible. This is a better approach! Excited for the performance boost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] michael-o commented on pull request #65: [DOXIASITETOOLS-268] - Improve performance by only loading the renderer version once during class initialization
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #65:
URL: https://github.com/apache/maven-doxia-sitetools/pull/65#issuecomment-1296354968
@jdimeo I slightly refactored you PR to use a static method instead of having a cluttered static block. Logic remains the same. Please have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] michael-o commented on pull request #65: [DOXIASITETOOLS-268] - Improve performance by only loading the renderer version once during class initialization
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #65:
URL: https://github.com/apache/maven-doxia-sitetools/pull/65#issuecomment-1296356173
I just ran this patch with MSITE ITs and it looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org