You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Simon Kitching (JIRA)" <my...@incubator.apache.org> on 2005/10/12 23:44:05 UTC
[jira] Created: (MYFACES-700) incompatible change to jscookMenu
incompatible change to jscookMenu
---------------------------------
Key: MYFACES-700
URL: http://issues.apache.org/jira/browse/MYFACES-700
Project: MyFaces
Type: Bug
Components: Tomahawk
Versions: 1.1.1
Reporter: Simon Kitching
Priority: Blocker
The current version of the jscookMenu tag [R292680, 2005-10-13] now throws an exception, with message:
"You provided a wrong themeName.".
I see that new features have been added to support custom themes. This is fine, but please restore the original behaviour of accepting an unknown themeName value. A bump in the "patch-level" release number (1.1.0 -> 1.1.1) should not have changes that break valid existing user code.
I currently implement a custom theme by passing my own theme name to the jscookMenu class and then ensuring that references to the appropriate .js and .css files are inserted into the page too. The old jscookMenu code simply accepted the unknown theme name, included that name in its generated inline javascript, and skipped output of any references to the .js/.css for a built-in theme.
The problem change is to class
org.apache.myfaces.custom.navmenu.jscookmenu.HtmlJSCookMenuRenderer
Possibly a *warning* (logged or even output as a js comment) could be generated by the jscookMenu code to recommend to people that they modify their pages to use the new custom-theming attributes, but throwing an exception isn't nice.
This has been discussed on the user email list:
http://marc.theaimsgroup.com/?t=112864086400003&r=1&w=2
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-700) incompatible change to jscookMenu
Posted by "Simon Kitching (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-700?page=all ]
Simon Kitching updated MYFACES-700:
-----------------------------------
Attachment: HtmlJSCookMenuRenderer.java.patch
Ok, here's a patch that allows a custom themeName to be provided without specifying any of the newly-introduced attributes.
I've tested that this class is compatible with the 1.1.0 release when using a custom theme.
I've not tested this patch with a built-in theme yet; as RCs are being rolled I wanted to get this patch posted ASAP.
Changes are mostly limited to the "addThemeSpecificResources" method although:
* a check for themeName==null has been added in the encodeEnd method;
* built-in themes are now defined in a map rather than hard-coded in the java
* the imports have been sorted (eclipse standard behaviour; it's easy enough to chop this out of the patch if you don't want it)
Regards,
Simon
> incompatible change to jscookMenu
> ---------------------------------
>
> Key: MYFACES-700
> URL: http://issues.apache.org/jira/browse/MYFACES-700
> Project: MyFaces
> Type: Bug
> Components: Tomahawk
> Versions: 1.1.1
> Reporter: Simon Kitching
> Assignee: Martin Marinschek
> Priority: Blocker
> Attachments: HtmlJSCookMenuRenderer.java.patch
>
> The current version of the jscookMenu tag [R292680, 2005-10-13] now throws an exception, with message:
> "You provided a wrong themeName.".
> I see that new features have been added to support custom themes. This is fine, but please restore the original behaviour of accepting an unknown themeName value. A bump in the "patch-level" release number (1.1.0 -> 1.1.1) should not have changes that break valid existing user code.
> I currently implement a custom theme by passing my own theme name to the jscookMenu class and then ensuring that references to the appropriate .js and .css files are inserted into the page too. The old jscookMenu code simply accepted the unknown theme name, included that name in its generated inline javascript, and skipped output of any references to the .js/.css for a built-in theme.
> The problem change is to class
> org.apache.myfaces.custom.navmenu.jscookmenu.HtmlJSCookMenuRenderer
> Possibly a *warning* (logged or even output as a js comment) could be generated by the jscookMenu code to recommend to people that they modify their pages to use the new custom-theming attributes, but throwing an exception isn't nice.
> This has been discussed on the user email list:
> http://marc.theaimsgroup.com/?t=112864086400003&r=1&w=2
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-700) incompatible change to jscookMenu
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-700?page=comments#action_12332674 ]
Martin Marinschek commented on MYFACES-700:
-------------------------------------------
No Simon, actually I was trying to apply the patch for current!
there must have been a change in between you creating the patch and the time I applied it, obviously...
regards,
Martin
> incompatible change to jscookMenu
> ---------------------------------
>
> Key: MYFACES-700
> URL: http://issues.apache.org/jira/browse/MYFACES-700
> Project: MyFaces
> Type: Bug
> Components: Tomahawk
> Versions: 1.1.1
> Reporter: Simon Kitching
> Assignee: Martin Marinschek
> Priority: Blocker
> Attachments: HtmlJSCookMenuRenderer.java, HtmlJSCookMenuRenderer.java.patch, HtmlJSCookMenuRenderer.java.patch
>
> The current version of the jscookMenu tag [R292680, 2005-10-13] now throws an exception, with message:
> "You provided a wrong themeName.".
> I see that new features have been added to support custom themes. This is fine, but please restore the original behaviour of accepting an unknown themeName value. A bump in the "patch-level" release number (1.1.0 -> 1.1.1) should not have changes that break valid existing user code.
> I currently implement a custom theme by passing my own theme name to the jscookMenu class and then ensuring that references to the appropriate .js and .css files are inserted into the page too. The old jscookMenu code simply accepted the unknown theme name, included that name in its generated inline javascript, and skipped output of any references to the .js/.css for a built-in theme.
> The problem change is to class
> org.apache.myfaces.custom.navmenu.jscookmenu.HtmlJSCookMenuRenderer
> Possibly a *warning* (logged or even output as a js comment) could be generated by the jscookMenu code to recommend to people that they modify their pages to use the new custom-theming attributes, but throwing an exception isn't nice.
> This has been discussed on the user email list:
> http://marc.theaimsgroup.com/?t=112864086400003&r=1&w=2
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-700) incompatible change to jscookMenu
Posted by "Simon Kitching (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-700?page=all ]
Simon Kitching updated MYFACES-700:
-----------------------------------
Attachment: HtmlJSCookMenuRenderer.java.patch
Sorry, my fault for the bad patch. I had forgotten one comment and thought I could just add it directly into the patch file.
Looks like I was wrong. Hopefully this patch file will apply cleanly.
> incompatible change to jscookMenu
> ---------------------------------
>
> Key: MYFACES-700
> URL: http://issues.apache.org/jira/browse/MYFACES-700
> Project: MyFaces
> Type: Bug
> Components: Tomahawk
> Versions: 1.1.1
> Reporter: Simon Kitching
> Assignee: Martin Marinschek
> Priority: Blocker
> Attachments: HtmlJSCookMenuRenderer.java.patch, HtmlJSCookMenuRenderer.java.patch
>
> The current version of the jscookMenu tag [R292680, 2005-10-13] now throws an exception, with message:
> "You provided a wrong themeName.".
> I see that new features have been added to support custom themes. This is fine, but please restore the original behaviour of accepting an unknown themeName value. A bump in the "patch-level" release number (1.1.0 -> 1.1.1) should not have changes that break valid existing user code.
> I currently implement a custom theme by passing my own theme name to the jscookMenu class and then ensuring that references to the appropriate .js and .css files are inserted into the page too. The old jscookMenu code simply accepted the unknown theme name, included that name in its generated inline javascript, and skipped output of any references to the .js/.css for a built-in theme.
> The problem change is to class
> org.apache.myfaces.custom.navmenu.jscookmenu.HtmlJSCookMenuRenderer
> Possibly a *warning* (logged or even output as a js comment) could be generated by the jscookMenu code to recommend to people that they modify their pages to use the new custom-theming attributes, but throwing an exception isn't nice.
> This has been discussed on the user email list:
> http://marc.theaimsgroup.com/?t=112864086400003&r=1&w=2
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (MYFACES-700) incompatible change to jscookMenu
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-700?page=all ]
Martin Marinschek closed MYFACES-700:
-------------------------------------
Fix Version: Nightly
Resolution: Fixed
Thanks Simon! Finally we arrived where we wanted to get ;)
Thing is that I don't have the rc3 checked out on my system can one of Bill or Sean apply this patch (or the whole file) there as well?
thx a lot,
regards,
Martin
> incompatible change to jscookMenu
> ---------------------------------
>
> Key: MYFACES-700
> URL: http://issues.apache.org/jira/browse/MYFACES-700
> Project: MyFaces
> Type: Bug
> Components: Tomahawk
> Versions: 1.1.1
> Reporter: Simon Kitching
> Assignee: Martin Marinschek
> Priority: Blocker
> Fix For: Nightly
> Attachments: HtmlJSCookMenuRenderer.java, HtmlJSCookMenuRenderer.java.patch, HtmlJSCookMenuRenderer.java.patch
>
> The current version of the jscookMenu tag [R292680, 2005-10-13] now throws an exception, with message:
> "You provided a wrong themeName.".
> I see that new features have been added to support custom themes. This is fine, but please restore the original behaviour of accepting an unknown themeName value. A bump in the "patch-level" release number (1.1.0 -> 1.1.1) should not have changes that break valid existing user code.
> I currently implement a custom theme by passing my own theme name to the jscookMenu class and then ensuring that references to the appropriate .js and .css files are inserted into the page too. The old jscookMenu code simply accepted the unknown theme name, included that name in its generated inline javascript, and skipped output of any references to the .js/.css for a built-in theme.
> The problem change is to class
> org.apache.myfaces.custom.navmenu.jscookmenu.HtmlJSCookMenuRenderer
> Possibly a *warning* (logged or even output as a js comment) could be generated by the jscookMenu code to recommend to people that they modify their pages to use the new custom-theming attributes, but throwing an exception isn't nice.
> This has been discussed on the user email list:
> http://marc.theaimsgroup.com/?t=112864086400003&r=1&w=2
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-700) incompatible change to jscookMenu
Posted by "Simon Kitching (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-700?page=comments#action_12332057 ]
Simon Kitching commented on MYFACES-700:
----------------------------------------
Interestingly, the code also has:
if (themeName != null) {
...
} else {
...
}
However the tomahawk.tld file specifies that the themeName attribute is required.
So presumably the "else" clause will never be used?
> incompatible change to jscookMenu
> ---------------------------------
>
> Key: MYFACES-700
> URL: http://issues.apache.org/jira/browse/MYFACES-700
> Project: MyFaces
> Type: Bug
> Components: Tomahawk
> Versions: 1.1.1
> Reporter: Simon Kitching
> Priority: Blocker
>
> The current version of the jscookMenu tag [R292680, 2005-10-13] now throws an exception, with message:
> "You provided a wrong themeName.".
> I see that new features have been added to support custom themes. This is fine, but please restore the original behaviour of accepting an unknown themeName value. A bump in the "patch-level" release number (1.1.0 -> 1.1.1) should not have changes that break valid existing user code.
> I currently implement a custom theme by passing my own theme name to the jscookMenu class and then ensuring that references to the appropriate .js and .css files are inserted into the page too. The old jscookMenu code simply accepted the unknown theme name, included that name in its generated inline javascript, and skipped output of any references to the .js/.css for a built-in theme.
> The problem change is to class
> org.apache.myfaces.custom.navmenu.jscookmenu.HtmlJSCookMenuRenderer
> Possibly a *warning* (logged or even output as a js comment) could be generated by the jscookMenu code to recommend to people that they modify their pages to use the new custom-theming attributes, but throwing an exception isn't nice.
> This has been discussed on the user email list:
> http://marc.theaimsgroup.com/?t=112864086400003&r=1&w=2
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-700) incompatible change to jscookMenu
Posted by "Simon Kitching (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-700?page=comments#action_12332656 ]
Simon Kitching commented on MYFACES-700:
----------------------------------------
Ahh..I see the problem.
Of course you're expecting a patch against head of branch 1.1.1. But my patch is against TRUNK.
And there have been several patches applied to TRUNK that are not on the 1.1.1 branch:
* branch 1.1.1 is at R291893
* trunk also has: 292680, 292677, 292303, 292163.
Working on the TRUNK is easy; I just check out "current".
Working on 1.1.1 is not so easy but I'll try to get it checked out and building.
Alternatively, if you could just look at the recent patch and apply that to TRUNK then manually apply the equivalent changes to the 1.1.1 branch that would save me a lot of time; you're obviously already set up to work with that branch.
> incompatible change to jscookMenu
> ---------------------------------
>
> Key: MYFACES-700
> URL: http://issues.apache.org/jira/browse/MYFACES-700
> Project: MyFaces
> Type: Bug
> Components: Tomahawk
> Versions: 1.1.1
> Reporter: Simon Kitching
> Assignee: Martin Marinschek
> Priority: Blocker
> Attachments: HtmlJSCookMenuRenderer.java, HtmlJSCookMenuRenderer.java.patch, HtmlJSCookMenuRenderer.java.patch
>
> The current version of the jscookMenu tag [R292680, 2005-10-13] now throws an exception, with message:
> "You provided a wrong themeName.".
> I see that new features have been added to support custom themes. This is fine, but please restore the original behaviour of accepting an unknown themeName value. A bump in the "patch-level" release number (1.1.0 -> 1.1.1) should not have changes that break valid existing user code.
> I currently implement a custom theme by passing my own theme name to the jscookMenu class and then ensuring that references to the appropriate .js and .css files are inserted into the page too. The old jscookMenu code simply accepted the unknown theme name, included that name in its generated inline javascript, and skipped output of any references to the .js/.css for a built-in theme.
> The problem change is to class
> org.apache.myfaces.custom.navmenu.jscookmenu.HtmlJSCookMenuRenderer
> Possibly a *warning* (logged or even output as a js comment) could be generated by the jscookMenu code to recommend to people that they modify their pages to use the new custom-theming attributes, but throwing an exception isn't nice.
> This has been discussed on the user email list:
> http://marc.theaimsgroup.com/?t=112864086400003&r=1&w=2
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-700) incompatible change to jscookMenu
Posted by "Martin Marinschek (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-700?page=comments#action_12332596 ]
Martin Marinschek commented on MYFACES-700:
-------------------------------------------
Sorry to not let you out, but it seems that your new patch was not made from the version currently on SVN head...
Can I ask you once again, without causing to much of an inconvenience?
regards,
Martin
> incompatible change to jscookMenu
> ---------------------------------
>
> Key: MYFACES-700
> URL: http://issues.apache.org/jira/browse/MYFACES-700
> Project: MyFaces
> Type: Bug
> Components: Tomahawk
> Versions: 1.1.1
> Reporter: Simon Kitching
> Assignee: Martin Marinschek
> Priority: Blocker
> Attachments: HtmlJSCookMenuRenderer.java.patch, HtmlJSCookMenuRenderer.java.patch
>
> The current version of the jscookMenu tag [R292680, 2005-10-13] now throws an exception, with message:
> "You provided a wrong themeName.".
> I see that new features have been added to support custom themes. This is fine, but please restore the original behaviour of accepting an unknown themeName value. A bump in the "patch-level" release number (1.1.0 -> 1.1.1) should not have changes that break valid existing user code.
> I currently implement a custom theme by passing my own theme name to the jscookMenu class and then ensuring that references to the appropriate .js and .css files are inserted into the page too. The old jscookMenu code simply accepted the unknown theme name, included that name in its generated inline javascript, and skipped output of any references to the .js/.css for a built-in theme.
> The problem change is to class
> org.apache.myfaces.custom.navmenu.jscookmenu.HtmlJSCookMenuRenderer
> Possibly a *warning* (logged or even output as a js comment) could be generated by the jscookMenu code to recommend to people that they modify their pages to use the new custom-theming attributes, but throwing an exception isn't nice.
> This has been discussed on the user email list:
> http://marc.theaimsgroup.com/?t=112864086400003&r=1&w=2
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-700) incompatible change to jscookMenu
Posted by "Martin Marinschek (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-700?page=comments#action_12332444 ]
Martin Marinschek commented on MYFACES-700:
-------------------------------------------
I seem not to be able to apply your patch - tortoise SVN shows a problem with "an undefined line type was found in line 84".
could you send me something compatible with tortoise SVN - or could someone else patch this in, I have reviewed the patch and it looks good.
regards,
Martin
> incompatible change to jscookMenu
> ---------------------------------
>
> Key: MYFACES-700
> URL: http://issues.apache.org/jira/browse/MYFACES-700
> Project: MyFaces
> Type: Bug
> Components: Tomahawk
> Versions: 1.1.1
> Reporter: Simon Kitching
> Assignee: Martin Marinschek
> Priority: Blocker
> Attachments: HtmlJSCookMenuRenderer.java.patch
>
> The current version of the jscookMenu tag [R292680, 2005-10-13] now throws an exception, with message:
> "You provided a wrong themeName.".
> I see that new features have been added to support custom themes. This is fine, but please restore the original behaviour of accepting an unknown themeName value. A bump in the "patch-level" release number (1.1.0 -> 1.1.1) should not have changes that break valid existing user code.
> I currently implement a custom theme by passing my own theme name to the jscookMenu class and then ensuring that references to the appropriate .js and .css files are inserted into the page too. The old jscookMenu code simply accepted the unknown theme name, included that name in its generated inline javascript, and skipped output of any references to the .js/.css for a built-in theme.
> The problem change is to class
> org.apache.myfaces.custom.navmenu.jscookmenu.HtmlJSCookMenuRenderer
> Possibly a *warning* (logged or even output as a js comment) could be generated by the jscookMenu code to recommend to people that they modify their pages to use the new custom-theming attributes, but throwing an exception isn't nice.
> This has been discussed on the user email list:
> http://marc.theaimsgroup.com/?t=112864086400003&r=1&w=2
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira