You are viewing a plain text version of this content. The canonical link for it is here.
Posted to muse-dev@ws.apache.org by "Chris Twiner (JIRA)" <ji...@apache.org> on 2009/01/03 15:15:44 UTC
[jira] Created: (MUSE-295) Pull-Points should not subscribe to all.
Its the job of the subscriptions to decide what is subscribed.
Pull-Points should not subscribe to all. Its the job of the subscriptions to decide what is subscribed.
--------------------------------------------------------------------------------------------------------
Key: MUSE-295
URL: https://issues.apache.org/jira/browse/MUSE-295
Project: Muse
Issue Type: Sub-task
Affects Versions: 2.2.0
Reporter: Chris Twiner
Assignee: Chris Twiner
Currently the SimplePullPointCreation registers a default message listener of *. This captures all messages sent from that Muse instance. This is against the spirit of a pull point.
Suggested fix is to check return a null filter object by default from SimplePullPoint.getFilter. Then PPCreation can check if the filter is the null object. If so it doesn't add a default filter. This preserves the notion of a default subscription for a pullpoint but also provides expected behaviour.
Further specific subscriptions can be added as per normal with a subscription client.
Adding a SimplePullPointAll class allows the existing behaviour to be used with only three additional letters in the muse.xml :-)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org
[jira] Updated: (MUSE-295) Pull-Points should not subscribe to all.
Its the job of the subscriptions to decide what is subscribed.
Posted by "Chris Twiner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MUSE-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Twiner updated MUSE-295:
------------------------------
Description:
Currently the SimplePullPointCreation registers a default message listener of *. This captures all messages sent from that Muse instance. This is against the spirit of a pull point.
Suggested fix is to check return a null filter object by default from SimplePullPoint.getFilter. Then PPCreation can check if the filter is the null object. If so it doesn't add a default filter. This preserves the notion of a default subscription for a pullpoint but also provides expected behaviour.
Further specific subscriptions can be added as per normal with a subscription client.
The existing SimplePullPoint is kept as-is for binary compatibility, a SubscriptionPullPoint class is added to provide this functionality. NullFilter is added to the WsnConstants class.
was:
Currently the SimplePullPointCreation registers a default message listener of *. This captures all messages sent from that Muse instance. This is against the spirit of a pull point.
Suggested fix is to check return a null filter object by default from SimplePullPoint.getFilter. Then PPCreation can check if the filter is the null object. If so it doesn't add a default filter. This preserves the notion of a default subscription for a pullpoint but also provides expected behaviour.
Further specific subscriptions can be added as per normal with a subscription client.
Adding a SimplePullPointAll class allows the existing behaviour to be used with only three additional letters in the muse.xml :-)
> Pull-Points should not subscribe to all. Its the job of the subscriptions to decide what is subscribed.
> --------------------------------------------------------------------------------------------------------
>
> Key: MUSE-295
> URL: https://issues.apache.org/jira/browse/MUSE-295
> Project: Muse
> Issue Type: Sub-task
> Affects Versions: 2.2.0
> Reporter: Chris Twiner
> Assignee: Chris Twiner
> Fix For: 2.2.1
>
>
> Currently the SimplePullPointCreation registers a default message listener of *. This captures all messages sent from that Muse instance. This is against the spirit of a pull point.
> Suggested fix is to check return a null filter object by default from SimplePullPoint.getFilter. Then PPCreation can check if the filter is the null object. If so it doesn't add a default filter. This preserves the notion of a default subscription for a pullpoint but also provides expected behaviour.
> Further specific subscriptions can be added as per normal with a subscription client.
> The existing SimplePullPoint is kept as-is for binary compatibility, a SubscriptionPullPoint class is added to provide this functionality. NullFilter is added to the WsnConstants class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org
[jira] Commented: (MUSE-295) Pull-Points should not subscribe to
all. Its the job of the subscriptions to decide what is subscribed.
Posted by "Chris Twiner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MUSE-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660472#action_12660472 ]
Chris Twiner commented on MUSE-295:
-----------------------------------
A brief history of related issues:
http://marc.info/?l=muse-user&m=118538443013450&w=2
http://mail-archives.apache.org/mod_mbox/ws-muse-user/200707.mbox/%3CDD00ACEE56F4A04DB7092539C493FADC053CA05E@sxmbx06.corproot.net%3E
> Pull-Points should not subscribe to all. Its the job of the subscriptions to decide what is subscribed.
> --------------------------------------------------------------------------------------------------------
>
> Key: MUSE-295
> URL: https://issues.apache.org/jira/browse/MUSE-295
> Project: Muse
> Issue Type: Sub-task
> Affects Versions: 2.2.0
> Reporter: Chris Twiner
> Assignee: Chris Twiner
> Fix For: 2.2.1
>
>
> Currently the SimplePullPointCreation registers a default message listener of *. This captures all messages sent from that Muse instance. This is against the spirit of a pull point.
> Suggested fix is to check return a null filter object by default from SimplePullPoint.getFilter. Then PPCreation can check if the filter is the null object. If so it doesn't add a default filter. This preserves the notion of a default subscription for a pullpoint but also provides expected behaviour.
> Further specific subscriptions can be added as per normal with a subscription client.
> The existing SimplePullPoint is kept as-is for binary compatibility, a SubscriptionPullPoint class is added to provide this functionality. NullFilter is added to the WsnConstants class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org
[jira] Resolved: (MUSE-295) Pull-Points should not subscribe to
all. Its the job of the subscriptions to decide what is subscribed.
Posted by "Chris Twiner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MUSE-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Twiner resolved MUSE-295.
-------------------------------
Resolution: Fixed
> Pull-Points should not subscribe to all. Its the job of the subscriptions to decide what is subscribed.
> --------------------------------------------------------------------------------------------------------
>
> Key: MUSE-295
> URL: https://issues.apache.org/jira/browse/MUSE-295
> Project: Muse
> Issue Type: Sub-task
> Affects Versions: 2.2.0
> Reporter: Chris Twiner
> Assignee: Chris Twiner
> Fix For: 2.2.1
>
>
> Currently the SimplePullPointCreation registers a default message listener of *. This captures all messages sent from that Muse instance. This is against the spirit of a pull point.
> Suggested fix is to check return a null filter object by default from SimplePullPoint.getFilter. Then PPCreation can check if the filter is the null object. If so it doesn't add a default filter. This preserves the notion of a default subscription for a pullpoint but also provides expected behaviour.
> Further specific subscriptions can be added as per normal with a subscription client.
> The existing SimplePullPoint is kept as-is for binary compatibility, a SubscriptionPullPoint class is added to provide this functionality. NullFilter is added to the WsnConstants class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org