You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/03/19 00:35:31 UTC

[GitHub] [pulsar] timmyyuan commented on a change in pull request #9961: [Build] Python-client build script use wrong path for root dir

timmyyuan commented on a change in pull request #9961:
URL: https://github.com/apache/pulsar/pull/9961#discussion_r597331408



##########
File path: pulsar-client-cpp/docker/build-wheels.sh
##########
@@ -25,6 +25,7 @@ BUILD_IMAGE_NAME="${BUILD_IMAGE_NAME:-apachepulsar/pulsar-build}"
 
 ROOT_DIR=$(dirname $0)/../..
 cd $ROOT_DIR
+ROOT_DIR=$(pwd)

Review comment:
       Sorry, I forgot to upload the context of this issue. In the build process of python-client, Docker will reject the relative path when mounting volumes, i.e. 
   ```
   Digest: sha256:2f75d7ba0cec73550deaa8a850fb3dcfcc47dd5aa7d17ad6fab3d4bae5ae5e7c
   201
   Status: Downloaded newer image for apachepulsar/pulsar-build:manylinux-cp27-cp27mu
   202
   docker: Error response from daemon: create pulsar-client-cpp/docker/../..: "pulsar-client-cpp/docker/../.." includes invalid characters for a local volume name, only "[a-zA-Z0-9][a-zA-Z0-9_.-]" are allowed. If you intended to pass a host directory, use absolute path.
   203
   See 'docker run --help'.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org