[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #2234: [KYUUBI #1498] Support operation log for ExecuteScala

[GitBox <gi...@apache.org>]

ulysses-you commented on a change in pull request #2234:
URL: https://github.com/apache/incubator-kyuubi/pull/2234#discussion_r836005031



##########
File path: externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/ExecuteScala.scala
##########
@@ -71,9 +75,12 @@ class ExecuteScala(
             if (result != null) {
               new ArrayFetchIterator[Row](result.collect())
             } else {
-              // TODO (#1498): Maybe we shall pass the output through operation log
-              // but some clients may not support operation log
-              new ArrayFetchIterator[Row](Array(Row(repl.getOutput)))
+              if (scalaReplToOperationLog) {
+                info("\n" + repl.getOutput)
+                new ArrayFetchIterator[Row](Array.empty[Row])

Review comment:
       shall we also pass repl.output to client ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org