You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by danobi <gi...@git.apache.org> on 2017/03/30 22:29:46 UTC
[GitHub] trafficserver pull request #1623: Delete dead code
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/1623
Delete dead code
None of this code was being called or used elsewhere. Most likely some
point before git history someone migrated off the abstract base class
and never bothered to delete this stuff.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danobi/trafficserver delete_abstract_buffer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1623.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1623
----
commit 7241221cf3a73729786540c04fcb3fe7805d05ea
Author: Daniel Xu <dx...@dxuuu.xyz>
Date: 2017-03-30T22:28:34Z
Delete dead code
None of this code was being called or used elsewhere. Most likely some
point before git history someone migrated off the abstract base class
and never bothered to delete this stuff.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1623: Delete dead code
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1623
AU check *successful*! https://ci.trafficserver.apache.org/job/autest-github/121/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1623: Delete dead code
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1623
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1623: Delete dead code
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1623
AU check *successful*! https://ci.trafficserver.apache.org/job/autest-github/120/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1623: Delete dead code
Posted by danobi <gi...@git.apache.org>.
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1623#discussion_r109180096
--- Diff: proxy/logging/LogBuffer.cc ---
@@ -112,14 +112,6 @@ LogBufferHeader::log_filename()
return addr;
}
-/*-------------------------------------------------------------------------
- LogBuffer::LogBuffer
--- End diff --
IMO it wasn't saying anything informative or useful now that AbstractBuffer is gone. If I had to add a comment it would be about what LogBuffer does and I would prefer to do that in LogBuffer.h.
I'm deep into the weeds of the logging system right now. Afterwards, I'll fix up and add more documentation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1623: Delete dead code
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1623#discussion_r109226190
--- Diff: proxy/logging/LogBuffer.cc ---
@@ -112,14 +112,6 @@ LogBufferHeader::log_filename()
return addr;
}
-/*-------------------------------------------------------------------------
- LogBuffer::LogBuffer
--- End diff --
I talked with @danobi about this and my view is a local comment should be minimal and the real meat in the Architecture section of the documentation. This commentary has obviously not been maintained and I don't see it being any different in the future. At least in the normal documentation there's some hope of it being updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1623: Delete dead code
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1623
FreeBSD11 build *successful*! https://ci.trafficserver.apache.org/job/freebsd-github/1820/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1623: Delete dead code
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1623
RAT check *successful*! https://ci.trafficserver.apache.org/job/RAT-github/138/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1623: Delete dead code
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1623
Linux build *successful*! https://ci.trafficserver.apache.org/job/linux-github/1710/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1623: Delete dead code
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1623
Intel CC build *successful*! https://ci.trafficserver.apache.org/job/icc-github/250/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1623: Delete dead code
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1623
Intel CC build *successful*! https://ci.trafficserver.apache.org/job/icc-github/249/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1623: Delete dead code
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1623
clang-analyzer build *successful*! https://ci.trafficserver.apache.org/job/clang-analyzer-github/382/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1623: Delete dead code
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1623
clang format *successful*! https://ci.trafficserver.apache.org/job/clang-format-github/124/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1623: Delete dead code
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1623
clang-analyzer build *successful*! https://ci.trafficserver.apache.org/job/clang-analyzer-github/381/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1623: Delete dead code
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1623
clang format *successful*! https://ci.trafficserver.apache.org/job/clang-format-github/123/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1623: Delete dead code
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1623
FreeBSD11 build *successful*! https://ci.trafficserver.apache.org/job/freebsd-github/1819/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1623: Delete dead code
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1623#discussion_r109090078
--- Diff: proxy/logging/LogBuffer.cc ---
@@ -112,14 +112,6 @@ LogBufferHeader::log_filename()
return addr;
}
-/*-------------------------------------------------------------------------
- LogBuffer::LogBuffer
--- End diff --
I don't think you should nuke the entire comment, just clean it up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1623: Delete dead code
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1623
Linux build *successful*! https://ci.trafficserver.apache.org/job/linux-github/1711/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1623: Delete dead code
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1623
RAT check *successful*! https://ci.trafficserver.apache.org/job/RAT-github/137/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---