You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "Liammcl (via GitHub)" <gi...@apache.org> on 2024/08/07 07:53:23 UTC
[PR] [amoro-#3054]: Add Paimon Table Consumer Infos In Ams Dashboard [amoro]
Liammcl opened a new pull request, #3081:
URL: https://github.com/apache/amoro/pull/3081
#3054 Add Paimon Table Consumer Infos In Ams Dashboard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement]: Add Paimon Table Consumer Infos In Ams Dashboard [amoro]
Posted by "tcodehuber (via GitHub)" <gi...@apache.org>.
tcodehuber commented on code in PR #3081:
URL: https://github.com/apache/amoro/pull/3081#discussion_r1709083299
##########
amoro-ams/amoro-ams-dashboard/src/types/common.type.ts:
##########
@@ -359,7 +359,7 @@ export type ILineChartOriginalData = Record<string, Record<string, number>>
export enum branchTypeMap {
BRANCH = 'branch',
TAG = 'tag',
- CONSUMER = 'consumer',
+ CONSUMERS = 'consumers',
Review Comment:
Here you can keep using : CONSUMER = 'consumer'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement]: Add Paimon Table Consumer Infos In Ams Dashboard [amoro]
Posted by "czy006 (via GitHub)" <gi...@apache.org>.
czy006 commented on code in PR #3081:
URL: https://github.com/apache/amoro/pull/3081#discussion_r1706556803
##########
amoro-ams/amoro-ams-dashboard/vite.config.ts:
##########
@@ -95,24 +95,24 @@ export default defineConfig({
* If you run the server on you local backend
* Maybe you need to open the Proxy
*/
- // proxy: {
- // '^/ams': {
- // // change the target to your backend server
- // // Such as target: 'http://127.0.0.1:xxx',
- // target: 'http://127.0.0.1:xxx',
- // changeOrigin: true,
- // configure(_, options) {
- // // configure proxy header here
- // options.headers = {
- // 'Access-Control-Allow-Origin': '*',
- // 'Access-Control-Allow-Credentials': 'true',
- // 'Access-Control-Allow-Headers':
- // 'Content-Type, Content-Length, Authorization, Accept, X-Requested-With , yourHeaderFeild',
- // 'Access-Control-Allow-Methods': 'PUT,POST,GET,DELETE,OPTIONS'
- // }
- // }
- // }
- // }
+ proxy: {
Review Comment:
why this proxy need to open? it just test to open it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement]: Add Paimon Table Consumer Infos In Ams Dashboard [amoro]
Posted by "czy006 (via GitHub)" <gi...@apache.org>.
czy006 commented on code in PR #3081:
URL: https://github.com/apache/amoro/pull/3081#discussion_r1708678252
##########
amoro-ams/amoro-ams-dashboard/src/language/zh.ts:
##########
@@ -198,8 +198,9 @@ export default {
totalDeleteFiles: '删除文件数量',
branches: '分支',
tags: '标签',
+ consumers: '用户',
nothingToShow: '无内容可展示',
- filterBranchesOrTags: '过滤分支/标签',
+ filterBranchesOrTagsOrConsumers: '过滤分支/标签/用户',
Review Comment:
maybe use filterBranchesOrTagsOrConsumers: '过滤分支/标签/消费者'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement]: Add Paimon Table Consumer Infos In Ams Dashboard [amoro]
Posted by "tcodehuber (via GitHub)" <gi...@apache.org>.
tcodehuber commented on code in PR #3081:
URL: https://github.com/apache/amoro/pull/3081#discussion_r1709081641
##########
amoro-ams/amoro-ams-dashboard/src/language/en.ts:
##########
@@ -198,9 +198,9 @@ export default {
totalDeleteFiles: 'delete-files',
branches: 'branches',
tags: 'tags',
- consumer: 'consumer',
+ consumers: 'consumers',
nothingToShow: 'Nothing to show',
- filterBranchesOrTags: 'Filter branches/tags/consumer',
+ filterBranchesOrTagsOrConsumers: 'Filter branches/tags/consumer',
Review Comment:
filterBranchesOrTagsOrConsumers: 'Filter branches/tags/consumers',
##########
amoro-ams/amoro-ams-dashboard/src/views/tables/components/Selector.vue:
##########
@@ -77,7 +78,7 @@ async function getTagList() {
}
async function getConsumerList() {
const result = await getConsumers(props as any)
- consumerList.value = (result.list || []).map((l: IServiceBranchItem) => ({ value: l.consumerId, label: l.consumerId, type: branchTypeMap.CONSUMER, amoroCurrentSnapshotsOfTable: l.amoroCurrentSnapshotsOfTable}))}
Review Comment:
use `branchTypeMap.CONSUMER`
##########
amoro-ams/amoro-ams-dashboard/src/types/common.type.ts:
##########
@@ -359,7 +359,7 @@ export type ILineChartOriginalData = Record<string, Record<string, number>>
export enum branchTypeMap {
BRANCH = 'branch',
TAG = 'tag',
- CONSUMER = 'consumer',
+ CONSUMERS = 'consumers',
Review Comment:
Here you can keep Using : CONSUMER = 'consumer'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement]: Add Paimon Table Consumer Infos In Ams Dashboard [amoro]
Posted by "Liammcl (via GitHub)" <gi...@apache.org>.
Liammcl commented on PR #3081:
URL: https://github.com/apache/amoro/pull/3081#issuecomment-2283028751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement]: Add Paimon Table Consumer Infos In Ams Dashboard [amoro]
Posted by "tcodehuber (via GitHub)" <gi...@apache.org>.
tcodehuber commented on code in PR #3081:
URL: https://github.com/apache/amoro/pull/3081#discussion_r1708444155
##########
amoro-ams/amoro-ams-dashboard/src/language/en.ts:
##########
@@ -198,8 +198,9 @@ export default {
totalDeleteFiles: 'delete-files',
branches: 'branches',
tags: 'tags',
+ consumer: 'consumer',
Review Comment:
ç: 'consumers',
Related consumer in the code should be replaced by consumers
##########
amoro-ams/amoro-ams-dashboard/src/language/en.ts:
##########
@@ -198,8 +198,9 @@ export default {
totalDeleteFiles: 'delete-files',
branches: 'branches',
tags: 'tags',
+ consumer: 'consumer',
Review Comment:
çonsumers: 'consumers',
Related consumer in the code should be replaced by consumers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement]: Add Paimon Table Consumer Infos In Ams Dashboard [amoro]
Posted by "Liammcl (via GitHub)" <gi...@apache.org>.
Liammcl commented on code in PR #3081:
URL: https://github.com/apache/amoro/pull/3081#discussion_r1708514037
##########
amoro-ams/amoro-ams-dashboard/src/views/tables/components/Selector.vue:
##########
@@ -33,8 +33,14 @@ const tagSearchKey = ref<string>('')
const tabActiveKey = ref<string>(branchTypeMap.BRANCH)
const branchList = ref<IBranchItem[]>([])
const tagList = ref<IBranchItem[]>([])
-const actualBranchList = computed(() => branchList.value.filter(item => !branchSearchKey.value || item.label.includes(branchSearchKey.value)))
-const actualTagList = computed(() => tagList.value.filter(item => !tagSearchKey.value || item.label.includes(tagSearchKey.value)))
+const consumerList = ref<IBranchItem[]>([])
+const actualBranchList = computed(() =>branchList.value.filter((item) =>!branchSearchKey.value ||
+ item.label.includes(branchSearchKey.value)))
+const actualTagList = computed(() =>tagList.value.filter((item) => !tagSearchKey.value ||
+item.label.includes(tagSearchKey.value)))
+const actualConsumerList = computed(() =>consumerList.value.filter((item) => !tagSearchKey.value ||
Review Comment:
Of course, I will fix these bugs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement]: Add Paimon Table Consumer Infos In Ams Dashboard [amoro]
Posted by "tcodehuber (via GitHub)" <gi...@apache.org>.
tcodehuber commented on code in PR #3081:
URL: https://github.com/apache/amoro/pull/3081#discussion_r1708444155
##########
amoro-ams/amoro-ams-dashboard/src/language/en.ts:
##########
@@ -198,8 +198,9 @@ export default {
totalDeleteFiles: 'delete-files',
branches: 'branches',
tags: 'tags',
+ consumer: 'consumer',
Review Comment:
consumers: 'consumers',
##########
amoro-ams/amoro-ams-dashboard/src/language/en.ts:
##########
@@ -198,8 +198,9 @@ export default {
totalDeleteFiles: 'delete-files',
branches: 'branches',
tags: 'tags',
+ consumer: 'consumer',
nothingToShow: 'Nothing to show',
- filterBranchesOrTags: 'Filter branches/tags',
+ filterBranchesOrTags: 'Filter branches/tags/consumer',
Review Comment:
filterBranchesOrTagsOrConsumers: 'Filter branches/tags/consumers',
Related `filterBranchesOrTags` in the code should be replaced by `filterBranchesOrTagsOrConsumers`
##########
amoro-ams/amoro-ams-dashboard/src/language/zh.ts:
##########
@@ -198,8 +198,9 @@ export default {
totalDeleteFiles: '删除文件数量',
branches: '分支',
tags: '标签',
+ consumer: '用户',
nothingToShow: '无内容可展示',
- filterBranchesOrTags: '过滤分支/标签',
+ filterBranchesOrTags: '过滤分支/标签/用户',
Review Comment:
filterBranchesOrTagsOrConsumers: '过滤分支/标签/用户',
Related filterBranchesOrTags in the code should be replaced by filterBranchesOrTagsOrConsumers
##########
amoro-ams/amoro-ams-dashboard/src/views/tables/components/Selector.vue:
##########
@@ -33,8 +33,14 @@ const tagSearchKey = ref<string>('')
const tabActiveKey = ref<string>(branchTypeMap.BRANCH)
const branchList = ref<IBranchItem[]>([])
const tagList = ref<IBranchItem[]>([])
-const actualBranchList = computed(() => branchList.value.filter(item => !branchSearchKey.value || item.label.includes(branchSearchKey.value)))
-const actualTagList = computed(() => tagList.value.filter(item => !tagSearchKey.value || item.label.includes(tagSearchKey.value)))
+const consumerList = ref<IBranchItem[]>([])
+const actualBranchList = computed(() =>branchList.value.filter((item) =>!branchSearchKey.value ||
+ item.label.includes(branchSearchKey.value)))
+const actualTagList = computed(() =>tagList.value.filter((item) => !tagSearchKey.value ||
+item.label.includes(tagSearchKey.value)))
+const actualConsumerList = computed(() =>consumerList.value.filter((item) => !tagSearchKey.value ||
Review Comment:
Can we define a consumerSearchKey instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement]: Add Paimon Table Consumer Infos In Ams Dashboard [amoro]
Posted by "Liammcl (via GitHub)" <gi...@apache.org>.
Liammcl commented on code in PR #3081:
URL: https://github.com/apache/amoro/pull/3081#discussion_r1706568809
##########
amoro-ams/amoro-ams-dashboard/vite.config.ts:
##########
@@ -95,24 +95,24 @@ export default defineConfig({
* If you run the server on you local backend
* Maybe you need to open the Proxy
*/
- // proxy: {
- // '^/ams': {
- // // change the target to your backend server
- // // Such as target: 'http://127.0.0.1:xxx',
- // target: 'http://127.0.0.1:xxx',
- // changeOrigin: true,
- // configure(_, options) {
- // // configure proxy header here
- // options.headers = {
- // 'Access-Control-Allow-Origin': '*',
- // 'Access-Control-Allow-Credentials': 'true',
- // 'Access-Control-Allow-Headers':
- // 'Content-Type, Content-Length, Authorization, Accept, X-Requested-With , yourHeaderFeild',
- // 'Access-Control-Allow-Methods': 'PUT,POST,GET,DELETE,OPTIONS'
- // }
- // }
- // }
- // }
+ proxy: {
Review Comment:
I will fixed that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement]: Add Paimon Table Consumer Infos In Ams Dashboard [amoro]
Posted by "czy006 (via GitHub)" <gi...@apache.org>.
czy006 commented on PR #3081:
URL: https://github.com/apache/amoro/pull/3081#issuecomment-2273030020
I can only verify it through local tests,can you help complete the code review cc @tcodehuber
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement]: Add Paimon Table Consumer Infos In Ams Dashboard [amoro]
Posted by "Liammcl (via GitHub)" <gi...@apache.org>.
Liammcl commented on code in PR #3081:
URL: https://github.com/apache/amoro/pull/3081#discussion_r1706568809
##########
amoro-ams/amoro-ams-dashboard/vite.config.ts:
##########
@@ -95,24 +95,24 @@ export default defineConfig({
* If you run the server on you local backend
* Maybe you need to open the Proxy
*/
- // proxy: {
- // '^/ams': {
- // // change the target to your backend server
- // // Such as target: 'http://127.0.0.1:xxx',
- // target: 'http://127.0.0.1:xxx',
- // changeOrigin: true,
- // configure(_, options) {
- // // configure proxy header here
- // options.headers = {
- // 'Access-Control-Allow-Origin': '*',
- // 'Access-Control-Allow-Credentials': 'true',
- // 'Access-Control-Allow-Headers':
- // 'Content-Type, Content-Length, Authorization, Accept, X-Requested-With , yourHeaderFeild',
- // 'Access-Control-Allow-Methods': 'PUT,POST,GET,DELETE,OPTIONS'
- // }
- // }
- // }
- // }
+ proxy: {
Review Comment:
I will fix that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement]: Add Paimon Table Consumer Infos In Ams Dashboard [amoro]
Posted by "Liammcl (via GitHub)" <gi...@apache.org>.
Liammcl commented on PR #3081:
URL: https://github.com/apache/amoro/pull/3081#issuecomment-2283027912
![image](https://github.com/user-attachments/assets/7de3d6f2-fea6-4b7b-8694-4e38ccb8a410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement]: Add Paimon Table Consumer Infos In Ams Dashboard [amoro]
Posted by "czy006 (via GitHub)" <gi...@apache.org>.
czy006 merged PR #3081:
URL: https://github.com/apache/amoro/pull/3081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org