You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2022/12/08 19:58:17 UTC

[GitHub] [openwhisk] msciabarra opened a new pull request, #5361: GitHub action [WIP]

msciabarra opened a new pull request, #5361:
URL: https://github.com/apache/openwhisk/pull/5361

   <!--- Provide a concise summary of your changes in the Title -->
   Implements a port of the travis build for github actions
   
   ## Description
   <!--- Provide a detailed description of your changes. -->
   This adds a Github action workflow and a port of the travis scripts to work with GitHubactions
   <!--- Include details of what problem you are solving and how your changes are tested. -->
   Travis needs to be replaced
   ## Related issue and scope
   
   <!--- Please include a link to a related issue if there is one. -->
   - [x] I opened an issue to propose and discuss this change (#5360)
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Scheduler
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [x] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
   - [ ] I reviewed the [style guides](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md#coding-standards) and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] bdoyle0182 commented on pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
bdoyle0182 commented on PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#issuecomment-1351783515

   To Dom's comment on aligning with master past 1.0.0 and the email sent to the dev list, I don't think master is broken. The CI tests should all pass, I think there was some flakiness with travis / the scheduler tests that would require you to re-kick the travis job to get them to pass; but master should be in a fine state.
   
   Thank you so much for the effort on this before the holidays.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on pull request #5361: GitHub action [WIP]

Posted by GitBox <gi...@apache.org>.
msciabarra commented on PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#issuecomment-1343281085

   Please note it is still incomplete because I have no idea of how to upload logs and how to see the results.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] style95 commented on a diff in pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
style95 commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1050254416


##########
tools/github/setup.sh:
##########
@@ -0,0 +1,79 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#if [[ $TEST_SUITE =~ Dummy ]]

Review Comment:
   I love this idea to skip tests for debugging.
   How about making this as an input as well just like debugging enablement option so that users can easily trigger this feature without changing any code?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
msciabarra commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1046228883


##########
ansible/group_vars/all:
##########
@@ -551,5 +551,3 @@ scheduler:
     throttlingFraction: "{{ scheduler_queue_throttlingFraction | default(0.9) }}"
     durationBufferSize: "{{ scheduler_queue_durationBufferSize | default(10) }}"
   deployment_ignore_error: "{{ scheduler_deployment_ignore_error | default('False') }}"
-  dataManagementService:

Review Comment:
   Yes. It gives a duplicate warning.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] style95 commented on a diff in pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
style95 commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1050253894


##########
tools/github/setup.sh:
##########
@@ -0,0 +1,79 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#if [[ $TEST_SUITE =~ Dummy ]]
+#then echo skipping setup ; exit 0
+#fi
+
+# retries a command for five times and exits with the non-zero exit if even after
+# the retries the command did not succeed.
+function retry() {
+  local exitcode=0
+  for i in {1..5};
+  do
+    exitcode=0
+    "$@" && break || exitcode=$? && echo "$i. attempt failed. Will retry $((5-i)) more times!" && sleep 1;
+  done
+  if [ $exitcode -ne 0 ]; then
+    exit $exitcode
+  fi
+}
+
+# setup docker to listen in port 4243
+sudo systemctl stop docker
+sudo sed -i -e 's!/usr/bin/dockerd -H fd://!/usr/bin/dockerd -H tcp://0.0.0.0:4243 -H fd://!' /lib/systemd/system/docker.service

Review Comment:
   Thank you for confirming that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] style95 commented on a diff in pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
style95 commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1048110025


##########
ansible/group_vars/all:
##########
@@ -458,98 +420,3 @@ metrics:
     port: "{{ metrics_kamon_statsd_port | default('8125') }}"
 
 user_events: "{{ user_events_enabled | default(false) | lower }}"
-
-zeroDowntimeDeployment:

Review Comment:
   Will these variables be added back after the test?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] bdoyle0182 commented on a diff in pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
bdoyle0182 commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1046227267


##########
ansible/group_vars/all:
##########
@@ -551,5 +551,3 @@ scheduler:
     throttlingFraction: "{{ scheduler_queue_throttlingFraction | default(0.9) }}"
     durationBufferSize: "{{ scheduler_queue_durationBufferSize | default(10) }}"
   deployment_ignore_error: "{{ scheduler_deployment_ignore_error | default('False') }}"
-  dataManagementService:

Review Comment:
   is this intended to be removed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
msciabarra commented on PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#issuecomment-1351868853

   Yes, I confirm the master is NOT broken. Indeed I was able to run all the master tests against my fork. At this point I think it is safe to merge.
   ![Uploading Screenshot 2022-12-14 at 17.59.47.png…]()
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] bdoyle0182 closed pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
bdoyle0182 closed pull request #5361: GitHub action
URL: https://github.com/apache/openwhisk/pull/5361


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] style95 commented on a diff in pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
style95 commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1050494234


##########
tools/github/setup.sh:
##########
@@ -0,0 +1,79 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#if [[ $TEST_SUITE =~ Dummy ]]

Review Comment:
   ah ok I got confused.
   My last question is what is the purpose of this commented block?
   There is already uncommnted one.
   
   ```
   if [[ $TEST_SUITE =~ Dummy ]]
   then echo skiping setup ; exit 0
   fi



##########
tools/github/setup.sh:
##########
@@ -0,0 +1,79 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#if [[ $TEST_SUITE =~ Dummy ]]

Review Comment:
   ah ok, I got confused.
   My last question is what is the purpose of this commented block?
   There is already uncommented one.
   
   ```
   if [[ $TEST_SUITE =~ Dummy ]]
   then echo skiping setup ; exit 0
   fi```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] style95 commented on a diff in pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
style95 commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1050367320


##########
tools/github/setup.sh:
##########
@@ -0,0 +1,79 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#if [[ $TEST_SUITE =~ Dummy ]]

Review Comment:
   Can we control whether to run these dummy tests like this?
   ![image](https://user-images.githubusercontent.com/3447251/208024370-1d2a9faa-724c-4225-a0cd-5b5153d0708d.png)
   
   Also, there is the same code block, so can we delete these comments?
   https://github.com/apache/openwhisk/pull/5361/files#diff-fc5257f5200a46b6baab3ca657b694cc84dc77e3a5f9d71062b25fce994c02b4R70



##########
tests/src/test/scala/org/apache/openwhisk/core/containerpool/v2/test/ActivationClientProxyTests.scala:
##########
@@ -15,6 +15,7 @@
  * limitations under the License.
  */
 
+/*

Review Comment:
   Why is this test commented?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
msciabarra commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1048119663


##########
ansible/group_vars/all:
##########
@@ -458,98 +420,3 @@ metrics:
     port: "{{ metrics_kamon_statsd_port | default('8125') }}"
 
 user_events: "{{ user_events_enabled | default(false) | lower }}"
-
-zeroDowntimeDeployment:

Review Comment:
   ooops - reverting them to the master version



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] codecov-commenter commented on pull request #5361: GitHub action [WIP]

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#issuecomment-1343325876

   # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/5361?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#5361](https://codecov.io/gh/apache/openwhisk/pull/5361?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (880ab52) into [master](https://codecov.io/gh/apache/openwhisk/commit/85788875d597f4225909479cefbdf403c0d19ff2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8578887) will **decrease** coverage by `76.93%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 880ab52 differs from pull request most recent head 3150456. Consider uploading reports for the commit 3150456 to get more accurate results
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #5361       +/-   ##
   ==========================================
   - Coverage   81.46%   4.52%   -76.94%     
   ==========================================
     Files         240     240               
     Lines       14407   14407               
     Branches      618     618               
   ==========================================
   - Hits        11736     652    -11084     
   - Misses       2671   13755    +11084     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/5361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../main/scala/org/apache/openwhisk/core/WarmUp.scala](https://codecov.io/gh/apache/openwhisk/pull/5361/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvV2FybVVwLnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ain/scala/org/apache/openwhisk/spi/SpiLoader.scala](https://codecov.io/gh/apache/openwhisk/pull/5361/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL3NwaS9TcGlMb2FkZXIuc2NhbGE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...n/scala/org/apache/openwhisk/utils/JsHelpers.scala](https://codecov.io/gh/apache/openwhisk/pull/5361/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL3V0aWxzL0pzSGVscGVycy5zY2FsYQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...scala/org/apache/openwhisk/common/Prometheus.scala](https://codecov.io/gh/apache/openwhisk/pull/5361/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Qcm9tZXRoZXVzLnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...scala/org/apache/openwhisk/common/time/Clock.scala](https://codecov.io/gh/apache/openwhisk/pull/5361/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi90aW1lL0Nsb2NrLnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...scala/org/apache/openwhisk/core/FeatureFlags.scala](https://codecov.io/gh/apache/openwhisk/pull/5361/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvRmVhdHVyZUZsYWdzLnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...scala/org/apache/openwhisk/http/CorsSettings.scala](https://codecov.io/gh/apache/openwhisk/pull/5361/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2h0dHAvQ29yc1NldHRpbmdzLnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ala/org/apache/openwhisk/common/ConfigMXBean.scala](https://codecov.io/gh/apache/openwhisk/pull/5361/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Db25maWdNWEJlYW4uc2NhbGE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...la/org/apache/openwhisk/http/BasicRasService.scala](https://codecov.io/gh/apache/openwhisk/pull/5361/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2h0dHAvQmFzaWNSYXNTZXJ2aWNlLnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...a/org/apache/openwhisk/common/ConfigMapValue.scala](https://codecov.io/gh/apache/openwhisk/pull/5361/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Db25maWdNYXBWYWx1ZS5zY2FsYQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [204 more](https://codecov.io/gh/apache/openwhisk/pull/5361/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
msciabarra commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1049279054


##########
.github/workflows/README.md:
##########
@@ -0,0 +1,56 @@
+# How to use those workflows
+
+There are a few [GitHub secrets](https://docs.github.com/en/actions/security-guides/encrypted-secrets) to configure to fully leverage the build.
+
+You can use and set the followings secrets also in your fork.
+
+## Ngrok Debugging
+
+You can debug a GitHub Action build using [NGROK](https://ngrok.com/).
+
+It is disabled for automated build triggered by push and pull_requests.
+
+You can trigger a workflow run manually  enabling ngrok debugging.
+
+It will open an ssh connection to the VM and keep it up and running for one hour.
+The connection url is showns in the log for debugAction.sh
+
+You can then connect to the build vm, and debug it.
+You need to use a password of your choice to access it.
+
+You can continue the build with `touch /tmp/continue`.
+You can abort the build with `touch /tmp/abort`.
+
+To enable this option you have to register to Ngrok, using the fee account and get the NGROK Token.
+
+Then set the following secrets:
+
+- `NGROK_TOKEN` to the ngrok token.
+- `NGROK_PASSWORD` to a password of choice to access the build with the ssh command generated.
+
+## Log Upload
+
+The build uploads the logs to an s3 bucket allowing to inspect them with a browser.
+
+You need to create the bucket with the following commands:
+
+```
+AWS_BUCKET=<name-of-your-bucket>
+AWS_REGION=<the-region-you-use>
+aws s3 mb s3://$AWS_BUCKET --region $AWS_REGION
+aws s3 website s3://$AWS_BUCKET/ --index-document index.html
+aws s3api put-bucket-acl --acl public-read --bucket $AWS_BUCKET
+```
+
+To enable upload to the created bucket you need to set the following secrets:
+
+- `AWS_BUCKET`: name of your bucket in s3 (just the name, without `s3://`); create it before.
+- `AWS_ACCESS_KEY_ID`: your aws access key.
+- `AWS_SECRET_ACCESS_KEY`: your aws secret key.
+- `AWS_REGION`: important: the region where your bucket is.
+
+## Slack notification
+
+If you want to get notified of what happens on slack, create an [Incoming Web Hook](https://api.slack.com/messaging/webhooks) and then set the following secret:
+
+- `SLACK_WEBHOOK`: the incoming webhook url provided by slack.

Review Comment:
   You can use it with the current OpenWhisk slack. I do not know who has access to the slack configuration. All you need to do is to create an app and retrieve the incoming webhook. And you can use the exiting dev channel on OpenWhisk slack



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
msciabarra commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1050363178


##########
tools/github/setup.sh:
##########
@@ -0,0 +1,79 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#if [[ $TEST_SUITE =~ Dummy ]]

Review Comment:
   it is already there...if you launvh the dummy build and enable ngrok in a few second you get an ssh command to get into the vm with everythingalready setup to build and test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] style95 commented on a diff in pull request #5361: GitHub action [WIP]

Posted by GitBox <gi...@apache.org>.
style95 commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1044937654


##########
.github/workflows/unit.yaml:
##########
@@ -0,0 +1,62 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+name: Unit Tests
+on:
+  push:
+
+env:
+  # uncomment this to enable an ngrok access to the vm on test failure
+  # enabling this you will get an ssh command to access the vm, active for one hour
+  #NGROK_DEBUG: yes

Review Comment:
   Can we make this selectively enabled in the core repo by those who have permission?
   IIRC, Travis does not enable the debug mode by default because secrets can be revealed.
   (Though I am not sure there are any secrets with GHA too.)
   If there are any, then we may need to keep them safe.



##########
.github/workflows/performance.yaml:
##########
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+name: Performance Tests
+on:
+  push:
+
+env:
+  # uncomment this to enable an ngrok access to the vm on test failure
+  # enabling this you will get an ssh command to access the vm, active for one hour
+  #NGROK_DEBUG: yes
+  # you need to add as secrets an ngrok token and a password to access the terminal 
+  NGROK_TOKEN: ${{ secrets.NGROK_TOKEN }}

Review Comment:
   Does this imply those who need debugging should sign up for Ngrok?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
msciabarra commented on PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#issuecomment-1346157570

   The workflow does not run and it is not visibile until it is available on the default branch so it shoud be merged. However currently the do not run unless you trigger them manually or push a tag. So we can test them merging and triggering manually. Or you can merge them in a fork as I am doing here (https://github.com/msciabarra/openwhisk/)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
msciabarra commented on PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#issuecomment-1347200248

   I fixed the error in the aws storage renaming a secret to AWS_BUCKET, and the error in system forcing a corresponding java version. I had to "slightly" update the version of openj9 used to use one that can be actually downloaded (11.0.8 -> 11.0.12)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
msciabarra commented on PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#issuecomment-1354549513

   Definitely ready to merge. This is what I get on my fork:
   ![Screenshot 2022-12-16 at 10 52 51](https://user-images.githubusercontent.com/1595312/208082941-d902970d-787b-4b84-bedc-2bbeaf7199e9.png)
   All tests are passing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
msciabarra commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1049270136


##########
.github/workflows/0-on-demand.yaml:
##########
@@ -0,0 +1,94 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+name: On Demand Tests
+
+on:
+  workflow_dispatch:
+    inputs:
+      enable_ngrok_debug:
+        description: "Enable Ngrok Debugging"
+        required: true
+        type: boolean
+        default: false
+      test_suite:
+        description: Select Test Suite to run
+        type: choice
+        options:
+        - Unit
+        - System
+        - MultiRuntime
+        - Standalone
+        - Scheduler
+        - Performance
+        ## Uncomment those to debug the build
+        - Dummy
+        #- DummyKO
+
+env:
+  # openwhisk env
+  TEST_SUITE: ${{ inputs.test_suite }}
+  ANSIBLE_CMD: "ansible-playbook -i environments/local -e docker_image_prefix=testing"
+  GRADLE_PROJS_SKIP: ""
+
+  # (optional) slack incoming wehbook for notifications
+  SLACK_WEBHOOK: ${{secrets.SLACK_WEBHOOK}}
+
+  # (optional) s3 log upload
+  AWS_BUCKET: ${{ secrets.AWS_BUCKET }}

Review Comment:
   Yes you can put your own AWS_BUCKET where you want. The bucket can be made public as I did here: https://nuvolaris-logs.s3.eu-central-1.amazonaws.com/index.html.
   Instructions are in the README.
   Actually, since there is already a bucket configured for some tests, it will be used!
   Maybe this is not what the owner of the bucket wants.
   We need to get a bucket from Amazon or from some other cloud provider, I am sure there are donations somewhere of resources that we can use...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
msciabarra commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1049618814


##########
tools/github/setup.sh:
##########
@@ -0,0 +1,79 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#if [[ $TEST_SUITE =~ Dummy ]]
+#then echo skipping setup ; exit 0
+#fi
+
+# retries a command for five times and exits with the non-zero exit if even after
+# the retries the command did not succeed.
+function retry() {
+  local exitcode=0
+  for i in {1..5};
+  do
+    exitcode=0
+    "$@" && break || exitcode=$? && echo "$i. attempt failed. Will retry $((5-i)) more times!" && sleep 1;
+  done
+  if [ $exitcode -ne 0 ]; then
+    exit $exitcode
+  fi
+}
+
+# setup docker to listen in port 4243
+sudo systemctl stop docker
+sudo sed -i -e 's!/usr/bin/dockerd -H fd://!/usr/bin/dockerd -H tcp://0.0.0.0:4243 -H fd://!' /lib/systemd/system/docker.service

Review Comment:
   I tried to run tests without this change but some tests (coverage tests) fails.
   So I would keep the open door for Docker.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] style95 commented on pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
style95 commented on PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#issuecomment-1346147920

   How can we test this change?
   It seems the GitHub workflow is not running on this repo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] style95 commented on pull request #5361: GitHub action [WIP]

Posted by GitBox <gi...@apache.org>.
style95 commented on PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#issuecomment-1344958772

   Logs are uploaded to IBM Bluemix.
   https://github.com/apache/openwhisk/blob/master/tools/travis/box-upload.py#L46
   
   We need to see if this is still valid.
   I also have no access to the logs.
   
   @dgrove-oss, could you confirm if we can still use Bluemix to upload logs?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
msciabarra commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1050470989


##########
tools/github/runDummyKOTests.sh:
##########
@@ -0,0 +1,26 @@
+#!/usr/bin/env bash

Review Comment:
   removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] style95 commented on a diff in pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
style95 commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1050494234


##########
tools/github/setup.sh:
##########
@@ -0,0 +1,79 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#if [[ $TEST_SUITE =~ Dummy ]]

Review Comment:
   ah ok I got confused.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
msciabarra commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1049267204


##########
.github/workflows/0-on-demand.yaml:
##########
@@ -0,0 +1,94 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+name: On Demand Tests
+
+on:
+  workflow_dispatch:
+    inputs:
+      enable_ngrok_debug:

Review Comment:
   The NGROK support is now only in the "on demand" task that must be manually activated.
   So you trigger it when you want. Works in your fork, so you have to add the token only for your it. When it is enabled in the actions a menu to trigger manually appears, and you have to check the box and select the test you want to run as below.
   
   ![Screenshot 2022-12-15 at 06 40 26](https://user-images.githubusercontent.com/1595312/207790563-c5d85b79-13c6-4273-8f8e-6203dedff050.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
msciabarra commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1049281941


##########
tools/github/runDummyKOTests.sh:
##########
@@ -0,0 +1,26 @@
+#!/usr/bin/env bash

Review Comment:
   yes to test a failing build...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra closed pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
msciabarra closed pull request #5361: GitHub action
URL: https://github.com/apache/openwhisk/pull/5361


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] sciabarracom commented on pull request #5361: GitHub action [WIP]

Posted by GitBox <gi...@apache.org>.
sciabarracom commented on PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#issuecomment-1345177195

   Yes I see in the scripts there is a "box-upload.py" script uploading them to a wired-in path.
   I am going to add also s3 upload so if you provide your keys it will upload to s3 instead.
   
   -- 
     Michele Sciabarra
     ***@***.***
   
   
   ----- Original message -----
   From: Dominic Kim ***@***.***>
   To: apache/openwhisk ***@***.***>
   Cc: Subscribed ***@***.***>
   Subject: Re: [apache/openwhisk] GitHub action [WIP] (PR #5361)
   Date: Saturday, December 10, 2022 1:10 AM
   
   
   
   
   Logs are uploaded to IBM Bluemix.
   https://github.com/apache/openwhisk/blob/master/tools/travis/box-upload.py#L46
   
   
   We need to see if this is still valid.
   I also have no access to the logs.
   
   @dgrove-oss <https://github.com/dgrove-oss>, could you confirm if we can still use Bluemix to upload logs?
   
   
   —
   Reply to this email directly, view it on GitHub <https://github.com/apache/openwhisk/pull/5361#issuecomment-1344958772>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHJ4D36OOAHDQB3MFXMVPALWMPKCHANCNFSM6AAAAAASYRAF5Q>.
   You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action [WIP]

Posted by GitBox <gi...@apache.org>.
msciabarra commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1045018310


##########
.github/workflows/performance.yaml:
##########
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+name: Performance Tests
+on:
+  push:
+
+env:
+  # uncomment this to enable an ngrok access to the vm on test failure
+  # enabling this you will get an ssh command to access the vm, active for one hour
+  #NGROK_DEBUG: yes
+  # you need to add as secrets an ngrok token and a password to access the terminal 
+  NGROK_TOKEN: ${{ secrets.NGROK_TOKEN }}

Review Comment:
   Yes but the NGROK account is free for one connection.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
msciabarra commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1049279581


##########
tools/github/runDummyTests.sh:
##########
@@ -0,0 +1,26 @@
+#!/usr/bin/env bash

Review Comment:
   to test the build without having to run a full test... it is handy to debug secrets and so on



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
msciabarra commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1049281580


##########
tools/github/setup.sh:
##########
@@ -0,0 +1,79 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#if [[ $TEST_SUITE =~ Dummy ]]
+#then echo skipping setup ; exit 0
+#fi
+
+# retries a command for five times and exits with the non-zero exit if even after
+# the retries the command did not succeed.
+function retry() {
+  local exitcode=0
+  for i in {1..5};
+  do
+    exitcode=0
+    "$@" && break || exitcode=$? && echo "$i. attempt failed. Will retry $((5-i)) more times!" && sleep 1;
+  done
+  if [ $exitcode -ne 0 ]; then
+    exit $exitcode
+  fi
+}
+
+# setup docker to listen in port 4243
+sudo systemctl stop docker
+sudo sed -i -e 's!/usr/bin/dockerd -H fd://!/usr/bin/dockerd -H tcp://0.0.0.0:4243 -H fd://!' /lib/systemd/system/docker.service

Review Comment:
   At least in the 1.0.0 branch one test fails... Let me see if we can get rid of this on the master....



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
msciabarra commented on PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#issuecomment-1347870420

   Now I have unit, multiruntime and standalone test passing and system only failing one test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
msciabarra commented on PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#issuecomment-1349657168

   ![Screenshot 2022-12-13 at 20 37 53](https://user-images.githubusercontent.com/1595312/207438759-bf68f919-64fa-4060-b39a-d981cbcc361d.png)
   
   The build is able to pass all the tests on 1.0.0 so I assume it can be merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on pull request #5361: GitHub action [WIP]

Posted by GitBox <gi...@apache.org>.
msciabarra commented on PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#issuecomment-1345626975

   I updated the pull requests.
   
   It is now able to write on slack and upload logs to an S3 buckets.
   There is also an "on demand" task allowing to launch a single test and debug the results enabling and accessing the vm with ngrok.
   
   To use the PR we need to merge it and also add to GitHub all the secrets listed in the .github/workflows/README.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
msciabarra commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1049279967


##########
tools/github/setup.sh:
##########
@@ -0,0 +1,79 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#if [[ $TEST_SUITE =~ Dummy ]]

Review Comment:
   no, if you do not want to defeat the goal of the dummy test to avoid to run a fast build withou waiting an hour...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
msciabarra commented on PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#issuecomment-1351876274

   Sorry my mistake. Please merge now. I tested the build against my fork and it works.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] style95 commented on a diff in pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
style95 commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1049127546


##########
.github/workflows/0-on-demand.yaml:
##########
@@ -0,0 +1,94 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+name: On Demand Tests
+
+on:
+  workflow_dispatch:
+    inputs:
+      enable_ngrok_debug:
+        description: "Enable Ngrok Debugging"
+        required: true
+        type: boolean
+        default: false
+      test_suite:
+        description: Select Test Suite to run
+        type: choice
+        options:
+        - Unit
+        - System
+        - MultiRuntime
+        - Standalone
+        - Scheduler
+        - Performance
+        ## Uncomment those to debug the build
+        - Dummy
+        #- DummyKO
+
+env:
+  # openwhisk env
+  TEST_SUITE: ${{ inputs.test_suite }}
+  ANSIBLE_CMD: "ansible-playbook -i environments/local -e docker_image_prefix=testing"
+  GRADLE_PROJS_SKIP: ""
+
+  # (optional) slack incoming wehbook for notifications
+  SLACK_WEBHOOK: ${{secrets.SLACK_WEBHOOK}}
+
+  # (optional) s3 log upload
+  AWS_BUCKET: ${{ secrets.AWS_BUCKET }}

Review Comment:
   Same for NGROK, so now contributors are in charge of uploading logs to their own environment to figure out the failed tests of a PR.
   For periodic tests against the upstream master branch, those who have permission can configure proper secrets for the upstream repo.
   
   It needs to be discussed where to place such logs.
   



##########
tools/github/runDummyTests.sh:
##########
@@ -0,0 +1,26 @@
+#!/usr/bin/env bash

Review Comment:
   What is the purpose of this?
   Seems it's being used here.
   https://github.com/apache/openwhisk/pull/5361/files#diff-fc5257f5200a46b6baab3ca657b694cc84dc77e3a5f9d71062b25fce994c02b4R70



##########
tools/github/setup.sh:
##########
@@ -0,0 +1,79 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#if [[ $TEST_SUITE =~ Dummy ]]

Review Comment:
   This might need to be deleted?



##########
tools/github/runDummyKOTests.sh:
##########
@@ -0,0 +1,26 @@
+#!/usr/bin/env bash

Review Comment:
   Is this being used?



##########
.github/workflows/README.md:
##########
@@ -0,0 +1,56 @@
+# How to use those workflows
+
+There are a few [GitHub secrets](https://docs.github.com/en/actions/security-guides/encrypted-secrets) to configure to fully leverage the build.
+
+You can use and set the followings secrets also in your fork.
+
+## Ngrok Debugging
+
+You can debug a GitHub Action build using [NGROK](https://ngrok.com/).
+
+It is disabled for automated build triggered by push and pull_requests.
+
+You can trigger a workflow run manually  enabling ngrok debugging.
+
+It will open an ssh connection to the VM and keep it up and running for one hour.
+The connection url is showns in the log for debugAction.sh
+
+You can then connect to the build vm, and debug it.
+You need to use a password of your choice to access it.
+
+You can continue the build with `touch /tmp/continue`.
+You can abort the build with `touch /tmp/abort`.
+
+To enable this option you have to register to Ngrok, using the fee account and get the NGROK Token.
+
+Then set the following secrets:
+
+- `NGROK_TOKEN` to the ngrok token.
+- `NGROK_PASSWORD` to a password of choice to access the build with the ssh command generated.
+
+## Log Upload
+
+The build uploads the logs to an s3 bucket allowing to inspect them with a browser.
+
+You need to create the bucket with the following commands:
+
+```
+AWS_BUCKET=<name-of-your-bucket>
+AWS_REGION=<the-region-you-use>
+aws s3 mb s3://$AWS_BUCKET --region $AWS_REGION
+aws s3 website s3://$AWS_BUCKET/ --index-document index.html
+aws s3api put-bucket-acl --acl public-read --bucket $AWS_BUCKET
+```
+
+To enable upload to the created bucket you need to set the following secrets:
+
+- `AWS_BUCKET`: name of your bucket in s3 (just the name, without `s3://`); create it before.
+- `AWS_ACCESS_KEY_ID`: your aws access key.
+- `AWS_SECRET_ACCESS_KEY`: your aws secret key.
+- `AWS_REGION`: important: the region where your bucket is.
+
+## Slack notification
+
+If you want to get notified of what happens on slack, create an [Incoming Web Hook](https://api.slack.com/messaging/webhooks) and then set the following secret:
+
+- `SLACK_WEBHOOK`: the incoming webhook url provided by slack.

Review Comment:
   I think this is also same. It would be great to discuss how/whether to configure this for the upstream repo.
   



##########
tools/github/setup.sh:
##########
@@ -0,0 +1,79 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#if [[ $TEST_SUITE =~ Dummy ]]
+#then echo skipping setup ; exit 0
+#fi
+
+# retries a command for five times and exits with the non-zero exit if even after
+# the retries the command did not succeed.
+function retry() {
+  local exitcode=0
+  for i in {1..5};
+  do
+    exitcode=0
+    "$@" && break || exitcode=$? && echo "$i. attempt failed. Will retry $((5-i)) more times!" && sleep 1;
+  done
+  if [ $exitcode -ne 0 ]; then
+    exit $exitcode
+  fi
+}
+
+# setup docker to listen in port 4243
+sudo systemctl stop docker
+sudo sed -i -e 's!/usr/bin/dockerd -H fd://!/usr/bin/dockerd -H tcp://0.0.0.0:4243 -H fd://!' /lib/systemd/system/docker.service

Review Comment:
   I faintly remember we decided not to open this port for the docker engine.
   Does any test fail without this port?



##########
.github/workflows/0-on-demand.yaml:
##########
@@ -0,0 +1,94 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+name: On Demand Tests
+
+on:
+  workflow_dispatch:
+    inputs:
+      enable_ngrok_debug:

Review Comment:
   What is the expected behavior for contributors to enable this debugging?
   Are they supposed to set up a secret in their forked repo, enable this input, and run tests in their repo?
   
   Since the secret is not configured in the upstream repo, no debugging would be enabled in the upstream repo, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
msciabarra commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1050472679


##########
tools/github/setup.sh:
##########
@@ -0,0 +1,79 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#if [[ $TEST_SUITE =~ Dummy ]]

Review Comment:
   Yes you control the test from there. Select "Dummy" to run the dummy test. It is useful when also you enable Ngrok debugging so you get an ssh command to get into the CI build VM to experiment. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
msciabarra commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1050460516


##########
tests/src/test/scala/org/apache/openwhisk/core/containerpool/v2/test/ActivationClientProxyTests.scala:
##########
@@ -15,6 +15,7 @@
  * limitations under the License.
  */
 
+/*

Review Comment:
   it was an attempt to pass the travis build to merge... but looks like it does not work



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] sciabarracom merged pull request #5361: GitHub action

Posted by GitBox <gi...@apache.org>.
sciabarracom merged PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action [WIP]

Posted by GitBox <gi...@apache.org>.
msciabarra commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1045018230


##########
.github/workflows/unit.yaml:
##########
@@ -0,0 +1,62 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+name: Unit Tests
+on:
+  push:
+
+env:
+  # uncomment this to enable an ngrok access to the vm on test failure
+  # enabling this you will get an ssh command to access the vm, active for one hour
+  #NGROK_DEBUG: yes

Review Comment:
   Yes. I already made it optional and you can enable it triggering it explicitly.
   You can run it on your fork.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org