You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Warren Turkal <wt...@penguintechs.org> on 2011/08/29 23:27:24 UTC
Small patch for test classes to better support eclipse
Here is a small patch to better support eclipse. It makes one of the base
classes that doesn't include any tests get ignored by the JUnit4 test
framework.
Please include, if possible.
Thanks,
wt
Index: src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java
===================================================================
--- src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java
(revision
1162989)
+++ src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java (working
copy)
@@ -32,8 +32,10 @@
import org.apache.zookeeper.ZooKeeper;
import org.apache.zookeeper.server.quorum.QuorumPeer;
import org.apache.zookeeper.server.quorum.QuorumPeer.QuorumServer;
+import org.junit.Ignore;
import org.junit.runner.JUnitCore;
+@Ignore
public class BaseSysTest extends TestCase {
private static int fakeBasePort = 33222;
private static String zkHostPort;
Re: Small patch for test classes to better support eclipse
Posted by Warren Turkal <wt...@penguintechs.org>.
Done:
https://issues.apache.org/jira/browse/ZOOKEEPER-1165
On Mon, Aug 29, 2011 at 2:37 PM, Patrick Hunt <ph...@apache.org> wrote:
> Warren, sounds good, would you mind submitting as a patch on a jira?
> thanks!
> http://wiki.apache.org/hadoop/ZooKeeper/HowToContribute
>
> basically create a jira here and attach your patch:
> https://issues.apache.org/jira/browse/ZOOKEEPER
>
> Patrick
>
>
> On Mon, Aug 29, 2011 at 2:27 PM, Warren Turkal <wt...@penguintechs.org>
> wrote:
> > Here is a small patch to better support eclipse. It makes one of the base
> > classes that doesn't include any tests get ignored by the JUnit4 test
> > framework.
> >
> > Please include, if possible.
> >
> > Thanks,
> > wt
> >
> > Index: src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java
> > ===================================================================
> > --- src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java
> > (revision
> > 1162989)
> > +++ src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java
> (working
> > copy)
> > @@ -32,8 +32,10 @@
> > import org.apache.zookeeper.ZooKeeper;
> > import org.apache.zookeeper.server.quorum.QuorumPeer;
> > import org.apache.zookeeper.server.quorum.QuorumPeer.QuorumServer;
> > +import org.junit.Ignore;
> > import org.junit.runner.JUnitCore;
> >
> > +@Ignore
> > public class BaseSysTest extends TestCase {
> > private static int fakeBasePort = 33222;
> > private static String zkHostPort;
> >
>
Re: Small patch for test classes to better support eclipse
Posted by Patrick Hunt <ph...@apache.org>.
Warren, sounds good, would you mind submitting as a patch on a jira? thanks!
http://wiki.apache.org/hadoop/ZooKeeper/HowToContribute
basically create a jira here and attach your patch:
https://issues.apache.org/jira/browse/ZOOKEEPER
Patrick
On Mon, Aug 29, 2011 at 2:27 PM, Warren Turkal <wt...@penguintechs.org> wrote:
> Here is a small patch to better support eclipse. It makes one of the base
> classes that doesn't include any tests get ignored by the JUnit4 test
> framework.
>
> Please include, if possible.
>
> Thanks,
> wt
>
> Index: src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java
> ===================================================================
> --- src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java
> (revision
> 1162989)
> +++ src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java (working
> copy)
> @@ -32,8 +32,10 @@
> import org.apache.zookeeper.ZooKeeper;
> import org.apache.zookeeper.server.quorum.QuorumPeer;
> import org.apache.zookeeper.server.quorum.QuorumPeer.QuorumServer;
> +import org.junit.Ignore;
> import org.junit.runner.JUnitCore;
>
> +@Ignore
> public class BaseSysTest extends TestCase {
> private static int fakeBasePort = 33222;
> private static String zkHostPort;
>