You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/08/26 09:28:51 UTC
[GitHub] [commons-collections] XenoAmess commented on a change in pull request #178: fix ci builds
XenoAmess commented on a change in pull request #178:
URL: https://github.com/apache/commons-collections/pull/178#discussion_r477165459
##########
File path: .travis.yml
##########
@@ -29,10 +29,23 @@ jdk:
- openjdk-ea
script:
- - mvn -V --no-transfer-progress
# japicmp requires a package
- - mvn -V jar:jar japicmp:cmp -P japicmp --no-transfer-progress
+ - |
+ if [ "$TRAVIS_JDK_VERSION" = "openjdk8" ];
+ then
+ mvn -V;
+ mvn -V jar:jar japicmp:cmp -P japicmp;
+ else
+ mvn -V --no-transfer-progress;
+ mvn -V jar:jar japicmp:cmp -P japicmp --no-transfer-progress;
+ fi;
after_success:
# jacoco will run in the main script. Include the profile to submit to coveralls.
- - mvn -V jacoco:report coveralls:report -Ptravis-jacoco --no-transfer-progress
+ - |
+ if [ "$TRAVIS_JDK_VERSION" = "openjdk8" ];
+ then
+ mvn -V jacoco:report coveralls:report -Ptravis-jacoco;
+ else
+ mvn -V jacoco:report coveralls:report -Ptravis-jacoco --no-transfer-progress;
+ fi;
Review comment:
@kinow
Hi.
> Couldn't we just drop --no-transfer-progress?
I personally have no experience in using `--no-transfer-progress`, thus I cannot answer this question.
Sorry for that.
I suggest if you want to delete it, find people who add it and get the reason why they add it first.
I just assume, it is added with a reason...
##########
File path: .travis.yml
##########
@@ -29,10 +29,23 @@ jdk:
- openjdk-ea
script:
- - mvn -V --no-transfer-progress
# japicmp requires a package
- - mvn -V jar:jar japicmp:cmp -P japicmp --no-transfer-progress
+ - |
+ if [ "$TRAVIS_JDK_VERSION" = "openjdk8" ];
+ then
+ mvn -V;
+ mvn -V jar:jar japicmp:cmp -P japicmp;
+ else
+ mvn -V --no-transfer-progress;
+ mvn -V jar:jar japicmp:cmp -P japicmp --no-transfer-progress;
+ fi;
after_success:
# jacoco will run in the main script. Include the profile to submit to coveralls.
- - mvn -V jacoco:report coveralls:report -Ptravis-jacoco --no-transfer-progress
+ - |
+ if [ "$TRAVIS_JDK_VERSION" = "openjdk8" ];
+ then
+ mvn -V jacoco:report coveralls:report -Ptravis-jacoco;
+ else
+ mvn -V jacoco:report coveralls:report -Ptravis-jacoco --no-transfer-progress;
+ fi;
Review comment:
@kinow
Hi.
> Couldn't we just drop --no-transfer-progress?
I personally have no experience in using `--no-transfer-progress`, thus I cannot answer this question.
Sorry for that.
I suggest if you want to delete it, find people who add it and get the reason why they add it first.
I just assume, it is added with a reason...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org