You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openoffice.apache.org by ar...@apache.org on 2021/03/03 18:37:11 UTC
[openoffice] branch AOO42X updated (2186aa1 -> 2cfa35e)
This is an automated email from the ASF dual-hosted git repository.
ardovm pushed a change to branch AOO42X
in repository https://gitbox.apache.org/repos/asf/openoffice.git.
from 2186aa1 Changed helptext after resolved problem. (#117)
new 33e2b20 fix unitialized variables in delivery.pl by treat undef as 0 changed: ../solenv/bin/deliver.pl
new 2cfa35e fixed compiler warnings 1) warning: comparison between signed and unsigned integer expressions [-Wsign-compare solution int -> unsigned int 2) warning: unused variable 'bResult' [-Wunused-variable removed return variable
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
main/cppuhelper/qa/ifcontainer/cppu_ifcontainer.cxx | 2 +-
main/cppuhelper/qa/unourl/cppu_unourl.cxx | 19 +++++++++----------
main/solenv/bin/deliver.pl | 3 +++
3 files changed, 13 insertions(+), 11 deletions(-)
[openoffice] 01/02: fix unitialized variables in delivery.pl by
treat undef as 0 changed: ../solenv/bin/deliver.pl
Posted by ar...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ardovm pushed a commit to branch AOO42X
in repository https://gitbox.apache.org/repos/asf/openoffice.git
commit 33e2b206e9e008c28b40f20e9050f412c48113e3
Author: Peter Kovacs <pe...@apache.org>
AuthorDate: Sat Apr 25 04:55:17 2020 +0200
fix unitialized variables in delivery.pl by treat undef as 0
changed: ../solenv/bin/deliver.pl
---
main/solenv/bin/deliver.pl | 3 +++
1 file changed, 3 insertions(+)
diff --git a/main/solenv/bin/deliver.pl b/main/solenv/bin/deliver.pl
index 1205b9c..f4b9df4 100755
--- a/main/solenv/bin/deliver.pl
+++ b/main/solenv/bin/deliver.pl
@@ -973,6 +973,9 @@ sub get_latest_patchlevel
for ($i = 0; $i < 3; $i++)
{
+ # if unitialized assign 0 as default value.
+ $field_a[$i] //= 0;
+ $field_b[$i] //= 0;
if ( ($field_a[$i] < $field_b[$i]) ) {
return -1;
}
[openoffice] 02/02: fixed compiler warnings 1) warning: comparison
between signed and unsigned integer expressions [-Wsign-compare solution
int -> unsigned int 2) warning: unused variable 'bResult'
[-Wunused-variable removed return variable
Posted by ar...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ardovm pushed a commit to branch AOO42X
in repository https://gitbox.apache.org/repos/asf/openoffice.git
commit 2cfa35e992a8f28fa6bcafda41750b0a45f7d15c
Author: Peter Kovacs <pe...@apache.org>
AuthorDate: Sat Apr 25 22:21:48 2020 +0200
fixed compiler warnings
1) warning: comparison between signed and unsigned integer expressions [-Wsign-compare
solution int -> unsigned int
2) warning: unused variable 'bResult' [-Wunused-variable
removed return variable
---
main/cppuhelper/qa/ifcontainer/cppu_ifcontainer.cxx | 2 +-
main/cppuhelper/qa/unourl/cppu_unourl.cxx | 19 +++++++++----------
2 files changed, 10 insertions(+), 11 deletions(-)
diff --git a/main/cppuhelper/qa/ifcontainer/cppu_ifcontainer.cxx b/main/cppuhelper/qa/ifcontainer/cppu_ifcontainer.cxx
index 952c34d..847958f 100644
--- a/main/cppuhelper/qa/ifcontainer/cppu_ifcontainer.cxx
+++ b/main/cppuhelper/qa/ifcontainer/cppu_ifcontainer.cxx
@@ -170,7 +170,7 @@ namespace cppu_ifcontainer
for (i = 0; i < nTests; i++)
{
Reference<XEventListener> xRef = new ContainerListener(&aStats);
- int nNewLen = pContainer->addInterface(xRef);
+ pContainer->addInterface(xRef);
aListeners.push_back(xRef);
}
Sequence< Reference< XInterface > > aElements;
diff --git a/main/cppuhelper/qa/unourl/cppu_unourl.cxx b/main/cppuhelper/qa/unourl/cppu_unourl.cxx
index dcab952..47d76e5 100644
--- a/main/cppuhelper/qa/unourl/cppu_unourl.cxx
+++ b/main/cppuhelper/qa/unourl/cppu_unourl.cxx
@@ -73,7 +73,7 @@ namespace cppu_unourl
{ "abc,def=%22", true },
{ "abc,def=\"", true },
{ "abc,def=%ed%a0%80", true } };
- for (int i = 0; i < sizeof aTests / sizeof (Test); ++i)
+ for (unsigned int i = 0; i < sizeof aTests / sizeof (Test); ++i)
{
bool bValid = false;
try
@@ -122,8 +122,7 @@ namespace cppu_unourl
{ "abc,def=%22", "abc,def=%22" },
{ "abc,def=\"", "abc,def=\"" },
{ "abc,def=%ed%a0%80", "abc,def=%ed%a0%80" } };
- bool bResult = true;
- for (int i = 0; i < sizeof aTests / sizeof (Test); ++i)
+ for (unsigned int i = 0; i < sizeof aTests / sizeof (Test); ++i)
{
bool bValid = false;
rtl::OUString aDescriptor;
@@ -169,7 +168,7 @@ namespace cppu_unourl
{ "abc,def=%22", "abc" },
{ "abc,def=\"", "abc" },
{ "abc,def=%ed%a0%80", "abc" } };
- for (int i = 0; i < sizeof aTests / sizeof (Test); ++i)
+ for (unsigned int i = 0; i < sizeof aTests / sizeof (Test); ++i)
{
bool bValid = false;
rtl::OUString aName;
@@ -213,7 +212,7 @@ namespace cppu_unourl
{ "abc,def=xxx,ghi=xxx", "def", true },
{ "abc,def=xxx,ghi=xxx", "ghi", true },
{ "abc,def=xxx,ghi=xxx", "jkl", false } };
- for (int i = 0; i < sizeof aTests / sizeof (Test); ++i)
+ for (unsigned int i = 0; i < sizeof aTests / sizeof (Test); ++i)
{
bool bValid = false;
bool bPresent = false;
@@ -282,7 +281,7 @@ namespace cppu_unourl
{ "abc,abc=,def=Abc", "def", "Abc" },
{ "abc,abc=,def=aBC", "def", "aBC" },
{ "abc,abc=,def=ABC", "def", "ABC" } };
- for (int i = 0; i < sizeof aTests / sizeof (Test); ++i)
+ for (unsigned int i = 0; i < sizeof aTests / sizeof (Test); ++i)
{
bool bValid = false;
rtl::OUString aValue;
@@ -324,7 +323,7 @@ namespace cppu_unourl
{ "uno:abc;def;1", true },
{ "uno:abc;def;$&+,/:=?@", true },
{ "uno:abc;def;%24&+,/:=?@", false } };
- for (int i = 0; i < sizeof aTests / sizeof (Test); ++i)
+ for (unsigned int i = 0; i < sizeof aTests / sizeof (Test); ++i)
{
bool bValid = false;
try
@@ -361,7 +360,7 @@ namespace cppu_unourl
{ "uno:ABC;def;ghi", "ABC" },
{ "uno:abc,def=xxx,ghi=xxx;def,ghi=xxx,jkl=xxx;ghi",
"abc,def=xxx,ghi=xxx" } };
- for (int i = 0; i < sizeof aTests / sizeof (Test); ++i)
+ for (unsigned int i = 0; i < sizeof aTests / sizeof (Test); ++i)
{
bool bValid = false;
rtl::OUString aConnection;
@@ -393,7 +392,7 @@ namespace cppu_unourl
{ "uno:abc;DEF;ghi", "DEF" },
{ "uno:abc,def=xxx,ghi=xxx;def,ghi=xxx,jkl=xxx;ghi",
"def,ghi=xxx,jkl=xxx" } };
- for (int i = 0; i < sizeof aTests / sizeof (Test); ++i)
+ for (unsigned int i = 0; i < sizeof aTests / sizeof (Test); ++i)
{
bool bValid = false;
rtl::OUString aProtocol;
@@ -428,7 +427,7 @@ namespace cppu_unourl
{ "uno:abc;def;A", "A" },
{ "uno:abc;def;1", "1" },
{ "uno:abc;def;$&+,/:=?@", "$&+,/:=?@" } };
- for (int i = 0; i < sizeof aTests / sizeof (Test); ++i)
+ for (unsigned int i = 0; i < sizeof aTests / sizeof (Test); ++i)
{
bool bValid = false;
rtl::OUString aObjectName;