You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "etseidl (via GitHub)" <gi...@apache.org> on 2024/09/23 21:50:32 UTC
[PR] Minor: Add some missing documentation to fix CI errors [arrow-rs]
etseidl opened a new pull request, #6445:
URL: https://github.com/apache/arrow-rs/pull/6445
# Rationale for this change
A recent merge has been causing some CI failures (e.g. https://github.com/apache/arrow-rs/actions/runs/11002447868/job/30549428975?pr=6431).
# What changes are included in this PR?
Adds missing documentation
# Are there any user-facing changes?
No
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: Add some missing documentation to fix CI errors [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6445:
URL: https://github.com/apache/arrow-rs/pull/6445#issuecomment-2371179362
Thank you @etseidl and @ngli-me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: Add some missing documentation to fix CI errors [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6445:
URL: https://github.com/apache/arrow-rs/pull/6445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: Add some missing documentation to fix CI errors [arrow-rs]
Posted by "ngli-me (via GitHub)" <gi...@apache.org>.
ngli-me commented on code in PR #6445:
URL: https://github.com/apache/arrow-rs/pull/6445#discussion_r1772359164
##########
arrow-string/src/like.rs:
##########
@@ -158,7 +158,9 @@ fn like_op(op: Op, lhs: &dyn Datum, rhs: &dyn Datum) -> Result<BooleanArray, Arr
/// This trait helps to abstract over the different types of string arrays
/// so that we don't need to duplicate the implementation for each type.
pub trait StringArrayType<'a>: ArrayAccessor<Item = &'a str> + Sized {
+ /// Returns true if all data within this array is ASCII
Review Comment:
```suggestion
/// Returns true if all data within this string array is ASCII
```
Maybe redundant, so feel free to ignore. I see this matches the format of the other comments on `is_ascii` functions, but my thought is that this is slightly different since its for the `StringArrayType` trait specifically. Otherwise, LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org