You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/10/06 15:35:43 UTC
[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request #1051: nimble/ll: Fix scanning with LL Privacy disabled
andrzej-kaczmarek opened a new pull request #1051:
URL: https://github.com/apache/mynewt-nimble/pull/1051
This is regression after eed4389851fcf96922a2e429376808f2dfddc912.
Without this fix only SCAN_RSP are reported back to host...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] haukepetersen commented on pull request #1051: nimble/ll: Fix scanning with LL Privacy disabled
Posted by GitBox <gi...@apache.org>.
haukepetersen commented on pull request #1051:
URL: https://github.com/apache/mynewt-nimble/pull/1051#issuecomment-937513478
All green -> lets go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] haukepetersen merged pull request #1051: nimble/ll: Fix scanning with LL Privacy disabled
Posted by GitBox <gi...@apache.org>.
haukepetersen merged pull request #1051:
URL: https://github.com/apache/mynewt-nimble/pull/1051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on pull request #1051: nimble/ll: Fix scanning with LL Privacy disabled
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on pull request #1051:
URL: https://github.com/apache/mynewt-nimble/pull/1051#issuecomment-936679804
@haukepetersen fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] haukepetersen commented on pull request #1051: nimble/ll: Fix scanning with LL Privacy disabled
Posted by GitBox <gi...@apache.org>.
haukepetersen commented on pull request #1051:
URL: https://github.com/apache/mynewt-nimble/pull/1051#issuecomment-936624282
On my first try I get a build error
```
/home/hauke/dev/riot/RIOT/build/pkg/nimble/nimble/controller/src/ble_ll_scan.c: In function 'ble_ll_scan_rx_isr_on_adv':
/home/hauke/dev/riot/RIOT/build/pkg/nimble/nimble/controller/src/ble_ll_scan.c:1960:5: error: 'rxinfo' undeclared (first use in this function)
1960 | rxinfo->flags |= BLE_MBUF_HDR_F_DEVMATCH;
| ^~~~~~
/home/hauke/dev/riot/RIOT/build/pkg/nimble/nimble/controller/src/ble_ll_scan.c:1960:5: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [/home/hauke/dev/riot/RIOT/Makefile.base:138: /home/hauke/dev/riot/RIOT/examples/nimble_scanner/bin/nrf52840dk/nimble_controller/ble_ll_scan.o] Error 1
```
But seems to be an easy fix:
```
diff --git a/nimble/controller/src/ble_ll_scan.c b/nimble/controller/src/ble_ll_scan.c
index 98734a30..6c408c46 100644
--- a/nimble/controller/src/ble_ll_scan.c
+++ b/nimble/controller/src/ble_ll_scan.c
@@ -1939,9 +1939,9 @@ ble_ll_scan_rx_isr_on_adv(uint8_t pdu_type, uint8_t *rxbuf,
{
struct ble_ll_scan_sm *scansm = &g_ble_ll_scan_sm;
struct ble_ll_scan_phy *scanp = scansm->scanp;
-#if MYNEWT_VAL(BLE_LL_CFG_FEAT_LL_PRIVACY)
+// #if MYNEWT_VAL(BLE_LL_CFG_FEAT_LL_PRIVACY)
struct ble_mbuf_hdr_rxinfo *rxinfo = &hdr->rxinfo;
-#endif
+// #endif
uint8_t scan_ok;
int rc;
```
With this applied, I can confirm that the issue described in #1049 is not present anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] haukepetersen commented on pull request #1051: nimble/ll: Fix scanning with LL Privacy disabled
Posted by GitBox <gi...@apache.org>.
haukepetersen commented on pull request #1051:
URL: https://github.com/apache/mynewt-nimble/pull/1051#issuecomment-937513478
All green -> lets go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] haukepetersen merged pull request #1051: nimble/ll: Fix scanning with LL Privacy disabled
Posted by GitBox <gi...@apache.org>.
haukepetersen merged pull request #1051:
URL: https://github.com/apache/mynewt-nimble/pull/1051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org