You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/11/15 20:43:42 UTC
[GitHub] [nifi] bbende opened a new pull request #5521: NIFI-9378 Create new artifact in nifi-assembly that packages all exte…
bbende opened a new pull request #5521:
URL: https://github.com/apache/nifi/pull/5521
…nsion manifests.
This produces a new artifact during building of `nifi-assembly` - `nifi-1.16.0-SNAPSHOT-manifests.zip`. This must be done from `nifi-assembly` since that is where the determination is made about which NARs to include in the assembly.
This zip file contains all of the `META-INF/docs/extension-manifest.xml` files from all NARs in the assembly. It is also attached to the build so it will be published as a Maven artifact on a release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] rfellows commented on pull request #5521: NIFI-9378 Create new artifact in nifi-assembly that packages all exte…
Posted by GitBox <gi...@apache.org>.
rfellows commented on pull request #5521:
URL: https://github.com/apache/nifi/pull/5521#issuecomment-971575334
Reviewing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on a change in pull request #5521: NIFI-9378 Create new artifact in nifi-assembly that packages all exte…
Posted by GitBox <gi...@apache.org>.
bbende commented on a change in pull request #5521:
URL: https://github.com/apache/nifi/pull/5521#discussion_r751434578
##########
File path: nifi-assembly/pom.xml
##########
@@ -51,6 +71,30 @@ language governing permissions and limitations under the License. -->
</formats>
</configuration>
</execution>
+ <execution>
+ <id>make-extension-manifest-assembly</id>
+ <goals>
+ <goal>single</goal>
+ </goals>
+ <phase>package</phase>
+ <configuration>
+ <finalName>nifi-${project.version}</finalName>
+ <attach>true</attach>
+ <archiverConfig>
+ <defaultDirectoryMode>0775</defaultDirectoryMode>
+ <directoryMode>0775</directoryMode>
+ <fileMode>0664</fileMode>
+ </archiverConfig>
+ <descriptors>
+ <descriptor>src/main/assembly/extension-manifests.xml</descriptor>
+ </descriptors>
+ <tarLongFileMode>posix</tarLongFileMode>
+ <formats>
+ <format>dir</format>
+ <format>zip</format>
+ </formats>
Review comment:
I don't have a strong opinion here, but the reason I put them here and not in the descriptor file was because the other existing execution above this (`make shared resource`) already defines them in the pom, so it seemed consistent. That one was done through the pom config because there are profiles that alter the formats like "dir-only" to save time, but for this case we wouldn't need that so it could be fine to put it in the descriptor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on pull request #5521: NIFI-9378 Create new artifact in nifi-assembly that packages all exte…
Posted by GitBox <gi...@apache.org>.
bbende commented on pull request #5521:
URL: https://github.com/apache/nifi/pull/5521#issuecomment-971814856
@rfellows thanks for reviewing, just pushed up a commit that makes a few tweaks..
- Flattened the directory structure to remove the META-INF/docs
- Removed the zip format
- Removed the version from base dir so a consumer can just expect a constant dir of nifi-manifests
Left the format in the pom for consistency with the other assembly execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] rfellows commented on a change in pull request #5521: NIFI-9378 Create new artifact in nifi-assembly that packages all exte…
Posted by GitBox <gi...@apache.org>.
rfellows commented on a change in pull request #5521:
URL: https://github.com/apache/nifi/pull/5521#discussion_r751320134
##########
File path: nifi-assembly/src/main/assembly/extension-manifests.xml
##########
@@ -0,0 +1,28 @@
+<?xml version="1.0"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<assembly>
+ <id>manifests</id>
+ <includeBaseDirectory>true</includeBaseDirectory>
+ <baseDirectory>nifi-${project.version}-manifests</baseDirectory>
+
Review comment:
Should define the format here. Also, I think including the `dir` format is redundant. e can probably do without it.
```suggestion
<formats>
<format>zip</format>
</formats>
```
##########
File path: nifi-assembly/pom.xml
##########
@@ -51,6 +71,30 @@ language governing permissions and limitations under the License. -->
</formats>
</configuration>
</execution>
+ <execution>
+ <id>make-extension-manifest-assembly</id>
+ <goals>
+ <goal>single</goal>
+ </goals>
+ <phase>package</phase>
+ <configuration>
+ <finalName>nifi-${project.version}</finalName>
+ <attach>true</attach>
+ <archiverConfig>
+ <defaultDirectoryMode>0775</defaultDirectoryMode>
+ <directoryMode>0775</directoryMode>
+ <fileMode>0664</fileMode>
+ </archiverConfig>
+ <descriptors>
+ <descriptor>src/main/assembly/extension-manifests.xml</descriptor>
+ </descriptors>
+ <tarLongFileMode>posix</tarLongFileMode>
+ <formats>
+ <format>dir</format>
+ <format>zip</format>
+ </formats>
Review comment:
Should the formats be defined in the assembly descriptor file instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] rfellows merged pull request #5521: NIFI-9378 Create new artifact in nifi-assembly that packages all exte…
Posted by GitBox <gi...@apache.org>.
rfellows merged pull request #5521:
URL: https://github.com/apache/nifi/pull/5521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org