You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/06 13:39:13 UTC
[GitHub] [beam] damccorm opened a new pull request, #21719: Add ability to self-assign issues for non-committers
damccorm opened a new pull request, #21719:
URL: https://github.com/apache/beam/pull/21719
Right now, non-committers can't self assign issues - this allows them to do so by commenting .take-issue.
Addresses https://github.com/apache/beam/issues/21684
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Add a link to the appropriate issue in your description, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on a diff in pull request #21719: Add ability to self-assign issues for non-committers
Posted by GitBox <gi...@apache.org>.
aaltay commented on code in PR #21719:
URL: https://github.com/apache/beam/pull/21719#discussion_r892666803
##########
website/www/site/content/en/contribute/get-started-contributing.md:
##########
@@ -109,7 +109,10 @@ Questions can be asked on the [#beam channel of the ASF Slack](https://beam.apac
1. Find or create an issue in the [Beam repo](https://github.com/apache/beam/issues/new/choose).
Tracking your work in an issue will avoid duplicated or conflicting work, and provide
a place for notes. Later, your pull request will be linked to the issue as well.
-2. Comment on the issue saying that you would like to work on it.
+2. Comment ".take-issue" on the issue. This will cause the issue to be assigned to you.
+ When you've completed the issue, you can close it by commenting ".close-issue".
+ If you are a committer and would like to assign an issue to a non-committer, they must comment
+ on the issue first; please tag the user asking them to do so or to comment ".take-issue".
Review Comment:
How would a committer ask non-committers to comment ".take-issue", without it causing the issue to be assigned to the committer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21719: Add ability to self-assign issues for non-committers
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21719:
URL: https://github.com/apache/beam/pull/21719#issuecomment-1147458790
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck merged pull request #21719: Add ability to self-assign issues for non-committers
Posted by GitBox <gi...@apache.org>.
lostluck merged PR #21719:
URL: https://github.com/apache/beam/pull/21719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #21719: Add ability to self-assign issues for non-committers
Posted by GitBox <gi...@apache.org>.
lostluck commented on PR #21719:
URL: https://github.com/apache/beam/pull/21719#issuecomment-1150125641
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #21719: Add ability to self-assign issues for non-committers
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #21719:
URL: https://github.com/apache/beam/pull/21719#discussion_r892706148
##########
website/www/site/content/en/contribute/get-started-contributing.md:
##########
@@ -109,7 +109,10 @@ Questions can be asked on the [#beam channel of the ASF Slack](https://beam.apac
1. Find or create an issue in the [Beam repo](https://github.com/apache/beam/issues/new/choose).
Tracking your work in an issue will avoid duplicated or conflicting work, and provide
a place for notes. Later, your pull request will be linked to the issue as well.
-2. Comment on the issue saying that you would like to work on it.
+2. Comment ".take-issue" on the issue. This will cause the issue to be assigned to you.
+ When you've completed the issue, you can close it by commenting ".close-issue".
+ If you are a committer and would like to assign an issue to a non-committer, they must comment
+ on the issue first; please tag the user asking them to do so or to comment ".take-issue".
Review Comment:
That's a good point - that's a limitation as currently implemented.
I added #21755 to address that limitation, it will ignore comments like `.take-issue`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21719: Add ability to self-assign issues for non-committers
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21719:
URL: https://github.com/apache/beam/pull/21719#issuecomment-1147458794
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21719: Add ability to self-assign issues for non-committers
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21719:
URL: https://github.com/apache/beam/pull/21719#issuecomment-1147480423
R: @lostluck
Would you mind helping me open a ticket with infra again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org