You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ku...@apache.org on 2017/09/14 13:21:16 UTC
flink git commit: [FLINK-7617] [runtime] Remove string format in
BitSet to improve the performance of BuildSideOuterjoin
Repository: flink
Updated Branches:
refs/heads/master 041b72c80 -> 6612c0e13
[FLINK-7617] [runtime] Remove string format in BitSet to improve the performance of BuildSideOuterjoin
This closes #4668.
Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/6612c0e1
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/6612c0e1
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/6612c0e1
Branch: refs/heads/master
Commit: 6612c0e13f2181ce9d4efee3606d487b27cf1545
Parents: 041b72c
Author: JingsongLi <lz...@aliyun.com>
Authored: Thu Sep 14 14:42:34 2017 +0800
Committer: Kurt Young <ku...@apache.org>
Committed: Thu Sep 14 21:18:25 2017 +0800
----------------------------------------------------------------------
.../java/org/apache/flink/runtime/operators/util/BitSet.java | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flink/blob/6612c0e1/flink-runtime/src/main/java/org/apache/flink/runtime/operators/util/BitSet.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/operators/util/BitSet.java b/flink-runtime/src/main/java/org/apache/flink/runtime/operators/util/BitSet.java
index be24ee2..b6e1e07 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/operators/util/BitSet.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/operators/util/BitSet.java
@@ -56,8 +56,7 @@ public class BitSet {
* @param index - position
*/
public void set(int index) {
- Preconditions.checkArgument(index < bitLength && index >= 0,
- String.format("Input Index[%d] is larger than BitSet available size[%d].", index, bitLength));
+ Preconditions.checkArgument(index < bitLength && index >= 0);
int byteIndex = (index & BYTE_POSITION_MASK) >>> 3;
byte current = memorySegment.get(offset + byteIndex);
@@ -72,8 +71,7 @@ public class BitSet {
* @return - value at the bit position
*/
public boolean get(int index) {
- Preconditions.checkArgument(index < bitLength && index >= 0,
- String.format("Input Index[%d] is larger than BitSet available size[%d].", index, bitLength));
+ Preconditions.checkArgument(index < bitLength && index >= 0);
int byteIndex = (index & BYTE_POSITION_MASK) >>> 3;
byte current = memorySegment.get(offset + byteIndex);