[GitHub] [cassandra] adelapena commented on pull request #788: CASSANDRA-16227 Add netstats and tablestats unit tests

[GitBox <gi...@apache.org>]

adelapena commented on pull request #788:
URL: https://github.com/apache/cassandra/pull/788#issuecomment-718727890


   > I have gone through unused imports in `test/unit/org/apache/cassandra/tools/nodetool/stats` if that is what you were referring to. I also tweaked generics usage but [this](https://github.com/bereng/cassandra/blob/CASSANDRA-16227/test/unit/org/apache/cassandra/tools/nodetool/stats/StatsTableComparatorTest.java#L53) guy is giving me a warning despite both the List and the Comparator are both typed 🤷. I must be missing sthg...
   
   Yes, I meant that. I thought that given that we are not going to add more tests for TableStats under this ticket at least we can do some quick and easy cleaning of warnings on its tests classes. Regarding that warning on `StatsTableComparatorTest`, I think that it is suggesting to use the instance method `List#sort` instead of the static `Collections.sort`:
   ```
   vector.sort(new StatsTableComparator(sortKey, humanReadable, ascending));
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org