You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/07/12 05:46:18 UTC

[GitHub] [skywalking-banyandb] lujiajing1126 commented on a change in pull request #14: Query Module: Executor

lujiajing1126 commented on a change in pull request #14:
URL: https://github.com/apache/skywalking-banyandb/pull/14#discussion_r667639854



##########
File path: api/common/id.go
##########
@@ -18,3 +18,40 @@
 package common
 
 type ChunkID uint64
+
+type ChunkIDs []ChunkID
+
+// HashIntersect returns an intersection of two ChunkID arrays
+// without any assumptions on the order. It uses a HashMap to mark
+// the existence of a item.
+func (c ChunkIDs) HashIntersect(other ChunkIDs) ChunkIDs {
+	if c == nil && other == nil {

Review comment:
       Fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org