You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "gharris1727 (via GitHub)" <gi...@apache.org> on 2023/06/23 17:00:13 UTC
[GitHub] [kafka] gharris1727 opened a new pull request, #13912: MINOR: Silence error logs for faulty plugins in integration tests
gharris1727 opened a new pull request, #13912:
URL: https://github.com/apache/kafka/pull/13912
In #13467 we changed non-connector plugins to be instantiated during plugin scanning. This has the effect that converters and transform classes without a valid (public, no-args) constructor print an error log during worker startup.
These two plugin classes are not marked `public`, so their constructor is not public either, which causes these two classes to print an error during plugin scanning. Because these are used in runtime:test, they will generate log spam for integration tests for ourselves and anyone including the runtime:test artifact, such as downstream projects wishing to use the EmbeddedConnectCluster.
We should change these plugins so that no warnings are printed during scanning. The existing TestPlugins should be the only place in which this error condition is tested.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on a diff in pull request #13912: MINOR: Silence error logs for faulty plugins in integration tests
Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante commented on code in PR #13912:
URL: https://github.com/apache/kafka/pull/13912#discussion_r1240123793
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ErrorHandlingTaskTest.java:
##########
@@ -554,7 +554,7 @@ private ConsumerRecords<byte[], byte[]> records(ConsumerRecord<byte[], byte[]> r
private abstract static class TestSinkTask extends SinkTask {
}
- static class FaultyConverter extends JsonConverter {
+ public static class FaultyConverter extends JsonConverter {
Review Comment:
Worth adding a comment on why these are public, so that a future contributor doesn't accidentally revert this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante merged pull request #13912: MINOR: Silence error logs for faulty plugins in integration tests
Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante merged PR #13912:
URL: https://github.com/apache/kafka/pull/13912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on pull request #13912: MINOR: Silence error logs for faulty plugins in integration tests
Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante commented on PR #13912:
URL: https://github.com/apache/kafka/pull/13912#issuecomment-1604661486
I've built and verified this patch locally (including the reduction in error log messages). Given the trivial nature of the changes, I'll merge without awaiting the CI run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org