You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/10/29 18:15:16 UTC

Review Request 71687: Rejected scheduler calls that include reservation updates.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71687/
-----------------------------------------------------------

Review request for mesos and Benjamin Bannier.


Bugs: MESOS-9983
    https://issues.apache.org/jira/browse/MESOS-9983


Repository: mesos


Description
-------

Until reservation updates are implemented, ensure
that calls making use of them are properly rejected.


Diffs
-----

  src/master/master.cpp 351823e69f14dbb5eb1ea2b108c42e93722f1eff 


Diff: https://reviews.apache.org/r/71687/diff/1/


Testing
-------


Thanks,

Benno Evers

Re: Review Request 71687: Rejected scheduler calls that include reservation updates.

Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71687/#review218457
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.cpp
Lines 4491 (patched)
<https://reviews.apache.org/r/71687/#comment306183>

    nit: `switch (`



src/master/master.cpp
Lines 4493 (patched)
<https://reviews.apache.org/r/71687/#comment306182>

    nit: `operation.reserve().source().empty`.


- Benjamin Bannier


On Oct. 29, 2019, 7:15 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71687/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2019, 7:15 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9983
>     https://issues.apache.org/jira/browse/MESOS-9983
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Until reservation updates are implemented, ensure
> that calls making use of them are properly rejected.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 351823e69f14dbb5eb1ea2b108c42e93722f1eff 
> 
> 
> Diff: https://reviews.apache.org/r/71687/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 71687: Rejected scheduler calls that include reservation updates.

Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71687/
-----------------------------------------------------------

(Updated Nov. 6, 2019, 3:50 p.m.)


Review request for mesos and Benjamin Bannier.


Changes
-------

Addressed comments.


Bugs: MESOS-9983
    https://issues.apache.org/jira/browse/MESOS-9983


Repository: mesos


Description
-------

Until reservation updates are implemented, ensure
that calls making use of them are properly rejected.


Diffs (updated)
-----

  src/master/master.cpp 2fdd6f7ddbb488d785c6f875c8b0c46c5f881d9d 


Diff: https://reviews.apache.org/r/71687/diff/3/

Changes: https://reviews.apache.org/r/71687/diff/2-3/


Testing
-------


Thanks,

Benno Evers

Re: Review Request 71687: Rejected scheduler calls that include reservation updates.

Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71687/#review218530
-----------------------------------------------------------




src/master/master.cpp
Lines 4489 (patched)
<https://reviews.apache.org/r/71687/#comment306268>

    `error.isNone()`


- Benjamin Bannier


On Nov. 1, 2019, 4:59 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71687/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2019, 4:59 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9983
>     https://issues.apache.org/jira/browse/MESOS-9983
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Until reservation updates are implemented, ensure
> that calls making use of them are properly rejected.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 2fdd6f7ddbb488d785c6f875c8b0c46c5f881d9d 
> 
> 
> Diff: https://reviews.apache.org/r/71687/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 71687: Rejected scheduler calls that include reservation updates.

Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71687/
-----------------------------------------------------------

(Updated Nov. 1, 2019, 3:59 p.m.)


Review request for mesos and Benjamin Bannier.


Changes
-------

Address style comments.


Bugs: MESOS-9983
    https://issues.apache.org/jira/browse/MESOS-9983


Repository: mesos


Description
-------

Until reservation updates are implemented, ensure
that calls making use of them are properly rejected.


Diffs (updated)
-----

  src/master/master.cpp 2fdd6f7ddbb488d785c6f875c8b0c46c5f881d9d 


Diff: https://reviews.apache.org/r/71687/diff/2/

Changes: https://reviews.apache.org/r/71687/diff/1-2/


Testing
-------


Thanks,

Benno Evers