You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "hjtran (via GitHub)" <gi...@apache.org> on 2023/09/18 11:14:09 UTC
[GitHub] [beam] hjtran opened a new pull request, #28496: RenderRunner cleanup
hjtran opened a new pull request, #28496:
URL: https://github.com/apache/beam/pull/28496
While trying to use the `RenderRunner`, I came across a few warts.
- It accepts a pipeline proto but doesn't use `run_portable_pipeline`
- Not 100% sure about this but it used `dotX` instead of `dot` for one of its subprocess calls
- `RenderOptions` couldn't be used with `.view_as` because the init-time validation
- The `RenderRunner` logging used the root logger instead of the module logger
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] hjtran commented on pull request #28496: RenderRunner cleanup
Posted by "hjtran (via GitHub)" <gi...@apache.org>.
hjtran commented on PR #28496:
URL: https://github.com/apache/beam/pull/28496#issuecomment-1723201242
R: @robertwb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #28496: RenderRunner cleanup
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28496:
URL: https://github.com/apache/beam/pull/28496#issuecomment-1723203620
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb merged pull request #28496: RenderRunner cleanup
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb merged PR #28496:
URL: https://github.com/apache/beam/pull/28496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #28496: RenderRunner cleanup
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #28496:
URL: https://github.com/apache/beam/pull/28496#issuecomment-1723235133
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28496?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#28496](https://app.codecov.io/gh/apache/beam/pull/28496?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7f709e7) into [master](https://app.codecov.io/gh/apache/beam/commit/38720a39d91db1853741f86d29819bf5a5d59a36?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (38720a3) will **increase** coverage by `0.03%`.
> Report is 4 commits behind head on master.
> The diff coverage is `35.71%`.
```diff
@@ Coverage Diff @@
## master #28496 +/- ##
==========================================
+ Coverage 72.22% 72.25% +0.03%
==========================================
Files 684 684
Lines 100856 100854 -2
==========================================
+ Hits 72846 72877 +31
+ Misses 26434 26401 -33
Partials 1576 1576
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/28496/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [python](https://app.codecov.io/gh/apache/beam/pull/28496/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `82.87% <35.71%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/beam/pull/28496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/runners/render.py](https://app.codecov.io/gh/apache/beam/pull/28496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9yZW5kZXIucHk=) | `48.12% <35.71%> (+1.52%)` | :arrow_up: |
... and [11 files with indirect coverage changes](https://app.codecov.io/gh/apache/beam/pull/28496/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org