You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2021/03/11 19:54:49 UTC

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #865: PARQUET-1973: Support ZSTD JNI BufferPool

shangxinli commented on a change in pull request #865:
URL: https://github.com/apache/parquet-mr/pull/865#discussion_r592678142



##########
File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/codec/ZstandardCodec.java
##########
@@ -91,7 +102,14 @@ public CompressionOutputStream createOutputStream(OutputStream stream, Compresso
 
   @Override
   public CompressionOutputStream createOutputStream(OutputStream stream) throws IOException {
-    return new ZstdCompressorStream(stream, conf.getInt(PARQUET_COMPRESS_ZSTD_LEVEL, DEFAULT_PARQUET_COMPRESS_ZSTD_LEVEL),
+    BufferPool pool;

Review comment:
       Thanks Dongjoon for working on this! 
   
   It is kind of late. Just a minor comment: if you can wrap the code into a method and call it in both CompressionInputStream() and CompressionOutputStream, it would avoid duplicating. Not a big deal though. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org