[maven-javadoc-plugin] branch master updated: Properly close DirectoryStream (#41)

[ol...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

olamy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-javadoc-plugin.git


The following commit(s) were added to refs/heads/master by this push:
     new 48c8420  Properly close DirectoryStream (#41)
48c8420 is described below

commit 48c8420633a72af774bfedb5fee5eec40ac0ed87
Author: Benedikt Ritter <br...@apache.org>
AuthorDate: Thu Mar 19 09:29:31 2020 +0100

    Properly close DirectoryStream (#41)
    
    Fixes MJAVADOC-644
---
 src/main/java/org/apache/maven/plugins/javadoc/StaleHelper.java | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/main/java/org/apache/maven/plugins/javadoc/StaleHelper.java b/src/main/java/org/apache/maven/plugins/javadoc/StaleHelper.java
index 72b2e48..2f7979e 100644
--- a/src/main/java/org/apache/maven/plugins/javadoc/StaleHelper.java
+++ b/src/main/java/org/apache/maven/plugins/javadoc/StaleHelper.java
@@ -22,6 +22,7 @@ package org.apache.maven.plugins.javadoc;
 import java.io.File;
 import java.io.IOException;
 import java.nio.charset.StandardCharsets;
+import java.nio.file.DirectoryStream;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.util.ArrayList;
@@ -139,10 +140,10 @@ public class StaleHelper
 
     private static Collection<Path> walk( Path dir )
     {
-        try
+        Collection<Path> paths = new ArrayList<>();
+        try ( DirectoryStream<Path> directoryStream = Files.newDirectoryStream( dir ) )
         {
-            Collection<Path> paths = new ArrayList<>();
-            for ( Path p : Files.newDirectoryStream( dir ) )
+            for ( Path p : directoryStream )
             {
                 paths.add( p );
             }