You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/10/28 00:44:43 UTC

[GitHub] [beam] boyuanzz commented on a change in pull request #13154: Implementing Python Bounded Source Reader DoFn

boyuanzz commented on a change in pull request #13154:
URL: https://github.com/apache/beam/pull/13154#discussion_r513112076



##########
File path: sdks/python/apache_beam/io/iobase.py
##########
@@ -1618,3 +1628,48 @@ def display_data(self):
         'source': DisplayDataItem(self.source.__class__, label='Read Source'),
         'source_dd': self.source
     }
+
+
+class SDFBoundedSourceReader(PTransform):

Review comment:
       It seems like the major difference between `SDFBoundedSourceWrapper ` and `SDFBoundedSourceReader ` is that `SDFBoundedSourceWrapper` takes the source as construction param where `SDFBoundedSourceReader` takes the source as input element. We could change the implementation of `SDFBoundedSourceWrapper` as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org