You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/18 14:01:44 UTC
[GitHub] [arrow-datafusion] korowa opened a new pull request, #2262: rewrite approx_median to approx_percentile_cont while planning phase
korowa opened a new pull request, #2262:
URL: https://github.com/apache/arrow-datafusion/pull/2262
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #2221 .
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
At this moment approx_median -> approx_percentile_cont occurs in one of optimization rules which kind of breaks logical plan (expressions inside of aggregate step don't match its output schema) and it works fine in case of one optimizer pass, but while second optimizer pass projection_push_down rule cleans up approximate_percentile_cont.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Suggestion is to move function replacement to planning phase - it seems to be more appropriate (we don't actually need the whole execution plan for this, because it's just rewriting of single expression), and there is no need to adjust all aliases / projections / schemas while optimization phase.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
Fixed execution of queries with approx_median aggregate expression / window function / having filter.
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #2262: rewrite approx_median to approx_percentile_cont while planning phase
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #2262:
URL: https://github.com/apache/arrow-datafusion/pull/2262#issuecomment-1112446043
@realno @yahoNanJing fyi since you have both worked on this code. I plan to merge this soon if there are no objections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #2262: rewrite approx_median to approx_percentile_cont while planning phase
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #2262:
URL: https://github.com/apache/arrow-datafusion/pull/2262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org