You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ko...@apache.org on 2025/10/06 11:42:49 UTC

(arrow) branch main updated: GH-47695: [CI][Release] Link arrow-io hdfs_test to c++fs on compilers where std:::filesystem is not default present (#47701)

This is an automated email from the ASF dual-hosted git repository.

kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new efb62f1719 GH-47695: [CI][Release] Link arrow-io hdfs_test to c++fs on compilers where std:::filesystem is not default present (#47701)
efb62f1719 is described below

commit efb62f1719ec0268b5ac54120d8646bcbc7098e1
Author: Raúl Cumplido <ra...@gmail.com>
AuthorDate: Mon Oct 6 13:42:41 2025 +0200

    GH-47695: [CI][Release] Link arrow-io hdfs_test to c++fs on compilers where std:::filesystem is not default present (#47701)
    
    ### Rationale for this change
    
    Currently our verify-rc on almalinux 8 fails due to missing symbols for `std::filesystem`. If we use `std::filesystem`, we need `-lstdc++fs` with GCC 8 and `-lc++fs` for clang 7.
    
    ### What changes are included in this PR?
    
    Link the test to `-lc++fs` for the required compilers.
    
    ### Are these changes tested?
    
    Yes, via archery
    
    ### Are there any user-facing changes?
    
    No
    * GitHub Issue: #47695
    
    Authored-by: Raúl Cumplido <ra...@gmail.com>
    Signed-off-by: Sutou Kouhei <ko...@clear-code.com>
---
 cpp/src/arrow/io/CMakeLists.txt | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/cpp/src/arrow/io/CMakeLists.txt b/cpp/src/arrow/io/CMakeLists.txt
index 0398422b05..623fcde413 100644
--- a/cpp/src/arrow/io/CMakeLists.txt
+++ b/cpp/src/arrow/io/CMakeLists.txt
@@ -23,12 +23,22 @@ add_arrow_test(compressed_test PREFIX "arrow-io")
 add_arrow_test(file_test PREFIX "arrow-io")
 
 if(ARROW_HDFS)
+  set(HDFS_TEST_EXTRA_LINK_LIBS arrow::hadoop)
+  if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
+    if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS "9")
+      list(APPEND HDFS_TEST_EXTRA_LINK_LIBS stdc++fs)
+    endif()
+  elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
+    if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS "8")
+      list(APPEND HDFS_TEST_EXTRA_LINK_LIBS c++fs)
+    endif()
+  endif()
   add_arrow_test(hdfs_test
                  NO_VALGRIND
                  PREFIX
                  "arrow-io"
                  EXTRA_LINK_LIBS
-                 arrow::hadoop)
+                 ${HDFS_TEST_EXTRA_LINK_LIBS})
 endif()
 
 add_arrow_test(memory_test PREFIX "arrow-io")