You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Steve Downey <st...@netfolio.com> on 2001/10/30 23:53:01 UTC
[PATCH] allow mod_webapp to build against tomcat v 4.0.1
Use net.ServerSocketFactory instead of ServerSocketFactory.
Index: java/WarpConnector.java
===================================================================
RCS file:
/home/cvspublic/jakarta-tomcat-connectors/webapp/java/WarpConnector.ja
va,v
retrieving revision 1.24
diff -u -r1.24 WarpConnector.java
--- java/WarpConnector.java 2001/10/22 21:44:21 1.24
+++ java/WarpConnector.java 2001/10/30 22:47:04
@@ -74,7 +74,7 @@
import org.apache.catalina.Response;
import org.apache.catalina.Service;
import org.apache.catalina.net.DefaultServerSocketFactory;
-import org.apache.catalina.ServerSocketFactory;
+import org.apache.catalina.net.ServerSocketFactory;
import org.apache.catalina.util.LifecycleSupport;
public class WarpConnector implements Connector, Lifecycle, Runnable {
<><><><><><><><><><><><><><><><><><><><><>This electronic mail transmission
may contain confidential information and is intended only for the person(s)
named. Any use, copying or disclosure by any other person is strictly
prohibited. If you have received this transmission in error, please notify
the sender via e-mail. <><><><><><><><><><><><><><><><><><><><><>
Re: [PATCH] allow mod_webapp to build against tomcat v 4.0.1
Posted by jean-frederic clere <jf...@fujitsu-siemens.com>.
Remy Maucherat wrote:
>
> > Use net.ServerSocketFactory instead of ServerSocketFactory.
> >
> > Index: java/WarpConnector.java
> > ===================================================================
> > RCS file:
> > /home/cvspublic/jakarta-tomcat-connectors/webapp/java/WarpConnector.ja
> > va,v
> > retrieving revision 1.24
> > diff -u -r1.24 WarpConnector.java
> > --- java/WarpConnector.java 2001/10/22 21:44:21 1.24
> > +++ java/WarpConnector.java 2001/10/30 22:47:04
> > @@ -74,7 +74,7 @@
> > import org.apache.catalina.Response;
> > import org.apache.catalina.Service;
> > import org.apache.catalina.net.DefaultServerSocketFactory;
> > -import org.apache.catalina.ServerSocketFactory;
> > +import org.apache.catalina.net.ServerSocketFactory;
> > import org.apache.catalina.util.LifecycleSupport;
> >
> > public class WarpConnector implements Connector, Lifecycle, Runnable {
>
> Agreed. I think we should forget the deprecation warnings, and have
> connectors which compile with both branches at the moment, as neither nod_jk
> or mod_webapp can be considered "branchable" (ie, both have a few issues
> which should be dealt with before).
>
> If people could help with the mod_jk for TC 4 bug(s) (like 4223), that would
> be great. JF ? Henri ? I don't have the time or expertise to do this.
About 4223 the actual cvs does not behave as described:
With mod_jk it returns -1
With TC standalone it blocks until the connection is broken.
Any hints?
>
> Remy
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] allow mod_webapp to build against tomcat v 4.0.1
Posted by jean-frederic clere <jf...@fujitsu-siemens.com>.
Pier Fumagalli wrote:
>
> Remy Maucherat at rmaucher1@home.com wrote:
>
> >> Use net.ServerSocketFactory instead of ServerSocketFactory.
> >>
> >> Index: java/WarpConnector.java
> >> ===================================================================
> >> RCS file:
> >> /home/cvspublic/jakarta-tomcat-connectors/webapp/java/WarpConnector.ja
> >> va,v
> >> retrieving revision 1.24
> >> diff -u -r1.24 WarpConnector.java
> >> --- java/WarpConnector.java 2001/10/22 21:44:21 1.24
> >> +++ java/WarpConnector.java 2001/10/30 22:47:04
> >> @@ -74,7 +74,7 @@
> >> import org.apache.catalina.Response;
> >> import org.apache.catalina.Service;
> >> import org.apache.catalina.net.DefaultServerSocketFactory;
> >> -import org.apache.catalina.ServerSocketFactory;
> >> +import org.apache.catalina.net.ServerSocketFactory;
> >> import org.apache.catalina.util.LifecycleSupport;
> >>
> >> public class WarpConnector implements Connector, Lifecycle, Runnable {
> >
> > Agreed. I think we should forget the deprecation warnings, and have
> > connectors which compile with both branches at the moment, as neither nod_jk
> > or mod_webapp can be considered "branchable" (ie, both have a few issues
> > which should be dealt with before).
>
> I would stick with 4.0 ATM, without branching off to write a 4.1
> implementation until 4.1's API is a little bit more clear... Also (from my
> personal point of view), being 4.0 much more tested than 4.1 (and used by
> users) that's our primary goal (all IMO)
Ok, I have committed the change... (that means arrange what I broke some days
ago!).
>
> Pier
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] allow mod_webapp to build against tomcat v 4.0.1
Posted by Pier Fumagalli <pi...@betaversion.org>.
Remy Maucherat at rmaucher1@home.com wrote:
>> Use net.ServerSocketFactory instead of ServerSocketFactory.
>>
>> Index: java/WarpConnector.java
>> ===================================================================
>> RCS file:
>> /home/cvspublic/jakarta-tomcat-connectors/webapp/java/WarpConnector.ja
>> va,v
>> retrieving revision 1.24
>> diff -u -r1.24 WarpConnector.java
>> --- java/WarpConnector.java 2001/10/22 21:44:21 1.24
>> +++ java/WarpConnector.java 2001/10/30 22:47:04
>> @@ -74,7 +74,7 @@
>> import org.apache.catalina.Response;
>> import org.apache.catalina.Service;
>> import org.apache.catalina.net.DefaultServerSocketFactory;
>> -import org.apache.catalina.ServerSocketFactory;
>> +import org.apache.catalina.net.ServerSocketFactory;
>> import org.apache.catalina.util.LifecycleSupport;
>>
>> public class WarpConnector implements Connector, Lifecycle, Runnable {
>
> Agreed. I think we should forget the deprecation warnings, and have
> connectors which compile with both branches at the moment, as neither nod_jk
> or mod_webapp can be considered "branchable" (ie, both have a few issues
> which should be dealt with before).
I would stick with 4.0 ATM, without branching off to write a 4.1
implementation until 4.1's API is a little bit more clear... Also (from my
personal point of view), being 4.0 much more tested than 4.1 (and used by
users) that's our primary goal (all IMO)
Pier
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] allow mod_webapp to build against tomcat v 4.0.1
Posted by Remy Maucherat <rm...@home.com>.
> Use net.ServerSocketFactory instead of ServerSocketFactory.
>
> Index: java/WarpConnector.java
> ===================================================================
> RCS file:
> /home/cvspublic/jakarta-tomcat-connectors/webapp/java/WarpConnector.ja
> va,v
> retrieving revision 1.24
> diff -u -r1.24 WarpConnector.java
> --- java/WarpConnector.java 2001/10/22 21:44:21 1.24
> +++ java/WarpConnector.java 2001/10/30 22:47:04
> @@ -74,7 +74,7 @@
> import org.apache.catalina.Response;
> import org.apache.catalina.Service;
> import org.apache.catalina.net.DefaultServerSocketFactory;
> -import org.apache.catalina.ServerSocketFactory;
> +import org.apache.catalina.net.ServerSocketFactory;
> import org.apache.catalina.util.LifecycleSupport;
>
> public class WarpConnector implements Connector, Lifecycle, Runnable {
Agreed. I think we should forget the deprecation warnings, and have
connectors which compile with both branches at the moment, as neither nod_jk
or mod_webapp can be considered "branchable" (ie, both have a few issues
which should be dealt with before).
If people could help with the mod_jk for TC 4 bug(s) (like 4223), that would
be great. JF ? Henri ? I don't have the time or expertise to do this.
Remy
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>