You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2016/02/08 23:54:47 UTC
Review Request 43343: HIVE-12857 LLAP: modify the decider to allow
using LLAP with whitelisted UDFs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43343/
-----------------------------------------------------------
Review request for hive and Jason Dere.
Repository: hive-git
Description
-------
see jira
Diffs
-----
bin/hive 52433ec
itests/qtest/pom.xml 292e562
itests/src/test/resources/testconfiguration.properties b46b160
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java e0e030f
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 77f11b9
ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java 16c8c8f
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapDecider.java ae64749
ql/src/test/queries/clientpositive/llap_udf.q PRE-CREATION
ql/src/test/results/clientpositive/llap/llap_udf.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/43343/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 43343: HIVE-12857 LLAP: modify the decider to
allow using LLAP with whitelisted UDFs
Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43343/#review118492
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java (line 147)
<https://reviews.apache.org/r/43343/#comment179744>
Are you supposed to re-throw t here?
ql/src/test/queries/clientpositive/llap_udf.q (line 6)
<https://reviews.apache.org/r/43343/#comment179753>
Does this setting only get checked during query compilation time- in which case anyone can override this setting before running their query?
Or is this also enforced on the daemon side?
ql/src/test/queries/clientpositive/llap_udf.q (line 38)
<https://reviews.apache.org/r/43343/#comment179751>
If this was expected to fail, shouldn't this be in a negative CLIDriver?
- Jason Dere
On Feb. 8, 2016, 10:54 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43343/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2016, 10:54 p.m.)
>
>
> Review request for hive and Jason Dere.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> bin/hive 52433ec
> itests/qtest/pom.xml 292e562
> itests/src/test/resources/testconfiguration.properties b46b160
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java e0e030f
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 77f11b9
> ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java 16c8c8f
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapDecider.java ae64749
> ql/src/test/queries/clientpositive/llap_udf.q PRE-CREATION
> ql/src/test/results/clientpositive/llap/llap_udf.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43343/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 43343: HIVE-12857 LLAP: modify the decider to
allow using LLAP with whitelisted UDFs
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43343/#review118317
-----------------------------------------------------------
bin/hive
<https://reviews.apache.org/r/43343/#comment179541>
doesn't belong to this patch
- Sergey Shelukhin
On Feb. 8, 2016, 10:54 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43343/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2016, 10:54 p.m.)
>
>
> Review request for hive and Jason Dere.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> bin/hive 52433ec
> itests/qtest/pom.xml 292e562
> itests/src/test/resources/testconfiguration.properties b46b160
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java e0e030f
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 77f11b9
> ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java 16c8c8f
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapDecider.java ae64749
> ql/src/test/queries/clientpositive/llap_udf.q PRE-CREATION
> ql/src/test/results/clientpositive/llap/llap_udf.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43343/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>