You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by yatsukhnenko <gi...@git.apache.org> on 2016/06/10 15:57:02 UTC
[GitHub] trafficserver pull request #700: TS-4488: fix Segmentation fault at HttpSM::...
GitHub user yatsukhnenko opened a pull request:
https://github.com/apache/trafficserver/pull/700
TS-4488: fix Segmentation fault at HttpSM::tunnel_handler_ua
Returning to [PR](https://github.com/apache/trafficserver/pull/674). It seems I found how to reproduce this bug. It happens when transformation is used (for example from null transform plugin) and client terminates connection before the transformation consumes all data from upstream vconnection.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yatsukhnenko/trafficserver TS-4488
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/700.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #700
----
commit d8ff431fae24ab8554c96231b301699cb3740b50
Author: Pavlo Yatsukhnenko <ya...@gmail.com>
Date: 2016-06-10T13:59:02Z
TS-4488: fix Segmentation fault at HttpSM::tunnel_handler_ua
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #700: TS-4488: fix Segmentation fault at HttpSM::tunnel_...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/700
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/221/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #700: TS-4488: fix Segmentation fault at HttpSM::tunnel_...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/700
The FreeBSD repo was in limbo, trying again. [approve ci].
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #700: TS-4488: fix Segmentation fault at HttpSM::tunnel_...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/700
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #700: TS-4488: fix Segmentation fault at HttpSM::tunnel_...
Posted by oknet <gi...@git.apache.org>.
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/700
maybe should add EPIPE check?
```
if (!r || r == -ECONNRESET || r == -EPIPE) { // SIGPIPE when write on a closed fd.
vc->write.triggered = 0;
write_signal_done(VC_EVENT_EOS, nh, vc);
return;
}
vc->write.triggered = 0;
write_signal_error(nh, vc, (int)-total_written);
return;
```
make the iocore callback with EOS
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #700: TS-4488: fix Segmentation fault at HttpSM::tunnel_...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/700
FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/220/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #700: TS-4488: fix Segmentation fault at HttpSM::tunnel_...
Posted by yatsukhnenko <gi...@git.apache.org>.
Github user yatsukhnenko commented on the issue:
https://github.com/apache/trafficserver/pull/700
@oknet, no, this isn't helping.
It looks like cache write consumer tries to complete reading data from transformation but server_session already closed because transformation reads data from cache.
BTW, I see this error only on ATS-4.2.x, so I will close this PR and Jira issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #700: TS-4488: fix Segmentation fault at HttpSM::...
Posted by yatsukhnenko <gi...@git.apache.org>.
Github user yatsukhnenko closed the pull request at:
https://github.com/apache/trafficserver/pull/700
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #700: TS-4488: fix Segmentation fault at HttpSM::tunnel_...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/700
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/117/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #700: TS-4488: fix Segmentation fault at HttpSM::tunnel_...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/700
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/118/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---