You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2015/12/16 15:50:19 UTC
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1045 Validate bindings...
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/180
TINKERPOP-1045 Validate bindings on the server to ensure that they were String keys
https://issues.apache.org/jira/browse/TINKERPOP-1045.
Also, fixed a problem where error messages were not always propagating back to the client (usually around validation). They were being sent back in the result field rather than in the statusMessage field.
Tested with:
```text
mvn clean install && mvn verify -DskipIntegrationTests=false -pl gremlin-server
```
and did manual testing as well with the console - see the JIRA ticket for console output.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1045
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/180.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #180
----
commit 55752d30e48d4ace8e7375e4dd46ff0e633bb828
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2015-12-16T14:47:02Z
Validate bindings on the server to ensure that they were String keys.
Also, fixed a problem where error messages were not always propagating back to the client (usually around validation). They were being sent back in the result field rather than in the statusMessage field.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1045 Validate bindings...
Posted by ShaunakDas88 <gi...@git.apache.org>.
Github user ShaunakDas88 commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/180#issuecomment-165483074
Run the following on this branch, and still get a hang on the client-side:
gremlin> client.submit('graph.toString()').all().get()
==>result{object=tinkergraph[vertices:0 edges:0] class=java.lang.String}
gremlin> script = "for(int i = 0; i < 10000000; i++){ graph.addVertex('label', i) }"
==>for(int i = 0; i < 10000000; i++){ graph.addVertex('label', i) }
gremlin> client.submit(script).all().get()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1045 Validate bindings...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/180#issuecomment-165468812
* `mvn clean install`: worked
* integration tests: worked
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1045 Validate bindings...
Posted by twilmes <gi...@git.apache.org>.
Github user twilmes commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/180#issuecomment-166449894
`mvn clean install` and integration tests are good. Code updates look good.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1045 Validate bindings...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/180#issuecomment-165484368
@ShaunakDas88 ok - so, just to be clear, do you mean that OOME is not hanging the client?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1045 Validate bindings...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/180
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1045 Validate bindings...
Posted by ShaunakDas88 <gi...@git.apache.org>.
Github user ShaunakDas88 commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/180#issuecomment-165487180
Yes, OOME does not hang the client anymore. Sorry for the confusion, it looks as though it was hanging, but the message just took some time to get relayed from the server.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---