You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Brijesh Bhalala <br...@gmail.com> on 2023/02/08 10:47:17 UTC

Review Request 74300: RANGER-4066: Add row draggable feature for audit filter table in service form in Ranger React.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74300/
-----------------------------------------------------------

Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.


Bugs: RANGER-4066
    https://issues.apache.org/jira/browse/RANGER-4066


Repository: ranger


Description
-------

1)Provide a row drag feature for reordering audit filters table row in service form.
2)Fixed the pageNo issue in policys, users/groups/roles listing tables.
3)Minor css improvement.


Diffs
-----

  security-admin/src/main/webapp/react-webapp/src/components/CreatableField.jsx 66afce1ca 
  security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx cf2292c82 
  security-admin/src/main/webapp/react-webapp/src/styles/style.css 6ffd55dfc 
  security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js 96657b57b 
  security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx 73956bc9c 
  security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx accd48b0c 
  security-admin/src/main/webapp/react-webapp/src/views/Header.jsx b054dc21e 
  security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx 0f14079f6 
  security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx 1b163a724 
  security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx c088a95ef 
  security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceAuditFilter.jsx a92451fff 
  security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx aa82bbf32 
  security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupForm.jsx 6fc043a98 
  security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleForm.jsx bb23a2727 
  security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx 835291403 


Diff: https://reviews.apache.org/r/74300/diff/1/


Testing
-------

1)Build and Verified Ranger Admin setup with this changes.
2)Verified the following things:-
  1)CRUD Operations for Policy, Services, Users/Groups/Roles.
  2)Policys, Users/Groups/Roles listing tables.


Thanks,

Brijesh Bhalala

Re: Review Request 74300: RANGER-4066: Add row draggable feature for audit filter table in service form in Ranger React.

Posted by Dhaval Rajpara <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74300/#review225186
-----------------------------------------------------------


Ship it!




Ship It!

- Dhaval Rajpara


On Feb. 8, 2023, 10:47 a.m., Brijesh Bhalala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74300/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2023, 10:47 a.m.)
> 
> 
> Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
> 
> 
> Bugs: RANGER-4066
>     https://issues.apache.org/jira/browse/RANGER-4066
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> 1)Provide a row drag feature for reordering audit filters table row in service form.
> 2)Fixed the pageNo issue in policys, users/groups/roles listing tables.
> 3)Minor css improvement.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/react-webapp/src/components/CreatableField.jsx 66afce1ca 
>   security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx cf2292c82 
>   security-admin/src/main/webapp/react-webapp/src/styles/style.css 6ffd55dfc 
>   security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js 96657b57b 
>   security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx 73956bc9c 
>   security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx accd48b0c 
>   security-admin/src/main/webapp/react-webapp/src/views/Header.jsx b054dc21e 
>   security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx 0f14079f6 
>   security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx 1b163a724 
>   security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx c088a95ef 
>   security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceAuditFilter.jsx a92451fff 
>   security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx aa82bbf32 
>   security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupForm.jsx 6fc043a98 
>   security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleForm.jsx bb23a2727 
>   security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx 835291403 
> 
> 
> Diff: https://reviews.apache.org/r/74300/diff/1/
> 
> 
> Testing
> -------
> 
> 1)Build and Verified Ranger Admin setup with this changes.
> 2)Verified the following things:-
>   1)CRUD Operations for Policy, Services, Users/Groups/Roles.
>   2)Policys, Users/Groups/Roles listing tables.
> 
> 
> Thanks,
> 
> Brijesh Bhalala
> 
>

Re: Review Request 74300: RANGER-4066: Add row draggable feature for audit filter table in service form in Ranger React.

Posted by Mugdha Varadkar <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74300/#review225185
-----------------------------------------------------------


Ship it!




Ship It!

- Mugdha Varadkar


On Feb. 8, 2023, 10:47 a.m., Brijesh Bhalala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74300/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2023, 10:47 a.m.)
> 
> 
> Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
> 
> 
> Bugs: RANGER-4066
>     https://issues.apache.org/jira/browse/RANGER-4066
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> 1)Provide a row drag feature for reordering audit filters table row in service form.
> 2)Fixed the pageNo issue in policys, users/groups/roles listing tables.
> 3)Minor css improvement.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/react-webapp/src/components/CreatableField.jsx 66afce1ca 
>   security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx cf2292c82 
>   security-admin/src/main/webapp/react-webapp/src/styles/style.css 6ffd55dfc 
>   security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js 96657b57b 
>   security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx 73956bc9c 
>   security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx accd48b0c 
>   security-admin/src/main/webapp/react-webapp/src/views/Header.jsx b054dc21e 
>   security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx 0f14079f6 
>   security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx 1b163a724 
>   security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx c088a95ef 
>   security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceAuditFilter.jsx a92451fff 
>   security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx aa82bbf32 
>   security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupForm.jsx 6fc043a98 
>   security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleForm.jsx bb23a2727 
>   security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx 835291403 
> 
> 
> Diff: https://reviews.apache.org/r/74300/diff/1/
> 
> 
> Testing
> -------
> 
> 1)Build and Verified Ranger Admin setup with this changes.
> 2)Verified the following things:-
>   1)CRUD Operations for Policy, Services, Users/Groups/Roles.
>   2)Policys, Users/Groups/Roles listing tables.
> 
> 
> Thanks,
> 
> Brijesh Bhalala
> 
>