You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "gabrywu (via GitHub)" <gi...@apache.org> on 2023/08/16 04:41:29 UTC

[GitHub] [beam] gabrywu commented on a diff in pull request #28007: remove fastjson library

gabrywu commented on code in PR #28007:
URL: https://github.com/apache/beam/pull/28007#discussion_r1295371517


##########
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BigQueryTableProviderTest.java:
##########
@@ -67,7 +67,7 @@ public void testDefaultMethod_whenPropertiesAreNotSet() {
   public void testSelectDefaultMethodExplicitly() {
     Table table =
         fakeTableWithProperties(
-            "hello", "{ " + METHOD_PROPERTY + ": " + "\"" + Method.DEFAULT.toString() + "\" }");
+            "hello", "{\"" + METHOD_PROPERTY + "\": " + "\"" + Method.DEFAULT.toString() + "\" }");

Review Comment:
   I will fix it, with JsonParser.Feature.ALLOW_UNQUOTED_FIELD_NAMES true



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org