You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@fineract.apache.org by Ádám Sághy <ad...@gmail.com> on 2026/03/19 09:29:25 UTC
Increased number of PRs and contributions
Hi everyone,
This situation has some good news and a few things to we need to figure out:
- I see an increased number of PRs, and contributions.
So, what’s the challenge?
I could really use some extra help to keep everything running smoothly:
- Need to approve and start GitHub Actions on the PRs. (you need committer permission for this)
- Review these PRs and advise on them
- We are looking for green CI build
- Functionality is tested
- PR is addressing 1 particular issue / functionality
- Commits are in order:
- We should avoid having 2-3 commits to address “trailing space issues”...
- Review and keep an eye on the comments of Jira stories
- Review and advise on existing stories; create new ones where we see room for improvements
I’m hoping some of you can lend a helping hand and we can share this workload!
Regards,
Adam
Re: Increased number of PRs and contributions
Posted by Ádám Sághy <ad...@gmail.com>.
Hi
Usually i am checking the following list:
https://github.com/apache/fineract/pulls?page=1&q=is%3Apr+is%3Aopen+draft%3Afalse+-label%3Arenovate
https://github.com/apache/fineract/pulls?page=1&q=is%3Apr+is%3Aopen+draft%3Afalse+-label%3Arenovate
Looking for:
- Whether Github actions CI need to be approved
- Whether the CI checks are all green
- Leave feedback if some of the CI checks fails
- Give a hint what might be the problem from the console log.
- Leave comment, and request changes
- if PR is incomplete
- if PR does not contain proper testing
- if PR is trying to do more than 1 thing (there is some leeway here, but ultimately we need focused PRs)
- if PR contains implementation that can be done better (very subjective topic :D )
Thank you in advance!
Regards,
Adam
> On Mar 20, 2026, at 5:58 AM, Ambika <ku...@gmail.com> wrote:
>
> Hi Adam,
>
> I'd be happy to help with this!
>
> Best regards
>
> Ambika
>
>
> On Fri, Mar 20, 2026 at 9:24 AM Nidhi Bhawari <nidhibhawari28@gmail.com <ma...@gmail.com>> wrote:
>> Hi Adam,
>> I would love to help!
>>
>>
>>
>> On Thu, Mar 19, 2026 at 3:00 PM Ádám Sághy <adamsaghy@gmail.com <ma...@gmail.com>> wrote:
>>> Hi everyone,
>>>
>>> This situation has some good news and a few things to we need to figure out:
>>> - I see an increased number of PRs, and contributions.
>>>
>>> So, what’s the challenge?
>>>
>>> I could really use some extra help to keep everything running smoothly:
>>> - Need to approve and start GitHub Actions on the PRs. (you need committer permission for this)
>>> - Review these PRs and advise on them
>>> - We are looking for green CI build
>>> - Functionality is tested
>>> - PR is addressing 1 particular issue / functionality
>>> - Commits are in order:
>>> - We should avoid having 2-3 commits to address “trailing space issues”...
>>> - Review and keep an eye on the comments of Jira stories
>>> - Review and advise on existing stories; create new ones where we see room for improvements
>>>
>>> I’m hoping some of you can lend a helping hand and we can share this workload!
>>>
>>> Regards,
>>> Adam
Re: Increased number of PRs and contributions
Posted by Ambika <ku...@gmail.com>.
Hi Adam,
I'd be happy to help with this!
Best regards
Ambika
On Fri, Mar 20, 2026 at 9:24 AM Nidhi Bhawari <ni...@gmail.com>
wrote:
> Hi Adam,
> I would love to help!
>
>
>
> On Thu, Mar 19, 2026 at 3:00 PM Ádám Sághy <ad...@gmail.com> wrote:
>
>> Hi everyone,
>>
>> This situation has some good news and a few things to we need to figure
>> out:
>> - I see an increased number of PRs, and contributions.
>>
>> So, what’s the challenge?
>>
>> I could really use some extra help to keep everything running smoothly:
>> - Need to approve and start GitHub Actions on the PRs. (you need
>> committer permission for this)
>> - Review these PRs and advise on them
>> - We are looking for green CI build
>> - Functionality is tested
>> - PR is addressing 1 particular issue / functionality
>> - Commits are in order:
>> - We should avoid having 2-3 commits to address “trailing
>> space issues”...
>> - Review and keep an eye on the comments of Jira stories
>> - Review and advise on existing stories; create new ones where we see
>> room for improvements
>>
>> I’m hoping some of you can lend a helping hand and we can share this
>> workload!
>>
>> Regards,
>> Adam
>
>
Re: Increased number of PRs and contributions
Posted by Nidhi Bhawari <ni...@gmail.com>.
Hi Adam,
I would love to help!
On Thu, Mar 19, 2026 at 3:00 PM Ádám Sághy <ad...@gmail.com> wrote:
> Hi everyone,
>
> This situation has some good news and a few things to we need to figure
> out:
> - I see an increased number of PRs, and contributions.
>
> So, what’s the challenge?
>
> I could really use some extra help to keep everything running smoothly:
> - Need to approve and start GitHub Actions on the PRs. (you need committer
> permission for this)
> - Review these PRs and advise on them
> - We are looking for green CI build
> - Functionality is tested
> - PR is addressing 1 particular issue / functionality
> - Commits are in order:
> - We should avoid having 2-3 commits to address “trailing
> space issues”...
> - Review and keep an eye on the comments of Jira stories
> - Review and advise on existing stories; create new ones where we see room
> for improvements
>
> I’m hoping some of you can lend a helping hand and we can share this
> workload!
>
> Regards,
> Adam
Re: Increased number of PRs and contributions
Posted by Edward Kang <ed...@gmail.com>.
Hi Adam!
I'd be happy to help wherever I can as well.
Best
Edward
On Thu, Mar 19, 2026 at 8:12 AM Aman Mittal <am...@gmail.com>
wrote:
> Hi Adam,
>
> Take your time, I can help review based on initial standards.
>
> Regards,
> Aman
>
>
> On Thu, Mar 19, 2026, 6:31 PM Jose Alberto Hernandez <
> josealbertohm@gmail.com> wrote:
>
>> I can help with some PR reviews and start the GA (only when you let me
>> know to avoid running them many times)
>>
>> Thanks and best regards
>> Alberto
>>
>> On Thu, Mar 19, 2026 at 4:30 AM Ádám Sághy <ad...@gmail.com> wrote:
>>
>>> Hi everyone,
>>>
>>> This situation has some good news and a few things to we need to figure
>>> out:
>>> - I see an increased number of PRs, and contributions.
>>>
>>> So, what’s the challenge?
>>>
>>> I could really use some extra help to keep everything running smoothly:
>>> - Need to approve and start GitHub Actions on the PRs. (you need
>>> committer permission for this)
>>> - Review these PRs and advise on them
>>> - We are looking for green CI build
>>> - Functionality is tested
>>> - PR is addressing 1 particular issue / functionality
>>> - Commits are in order:
>>> - We should avoid having 2-3 commits to address
>>> “trailing space issues”...
>>> - Review and keep an eye on the comments of Jira stories
>>> - Review and advise on existing stories; create new ones where we see
>>> room for improvements
>>>
>>> I’m hoping some of you can lend a helping hand and we can share this
>>> workload!
>>>
>>> Regards,
>>> Adam
>>
>>
--
Edward E. Kang
edward.kang12@gmail.com
972-768-6940
Re: Increased number of PRs and contributions
Posted by Aman Mittal <am...@gmail.com>.
Hi Adam,
Take your time, I can help review based on initial standards.
Regards,
Aman
On Thu, Mar 19, 2026, 6:31 PM Jose Alberto Hernandez <
josealbertohm@gmail.com> wrote:
> I can help with some PR reviews and start the GA (only when you let me
> know to avoid running them many times)
>
> Thanks and best regards
> Alberto
>
> On Thu, Mar 19, 2026 at 4:30 AM Ádám Sághy <ad...@gmail.com> wrote:
>
>> Hi everyone,
>>
>> This situation has some good news and a few things to we need to figure
>> out:
>> - I see an increased number of PRs, and contributions.
>>
>> So, what’s the challenge?
>>
>> I could really use some extra help to keep everything running smoothly:
>> - Need to approve and start GitHub Actions on the PRs. (you need
>> committer permission for this)
>> - Review these PRs and advise on them
>> - We are looking for green CI build
>> - Functionality is tested
>> - PR is addressing 1 particular issue / functionality
>> - Commits are in order:
>> - We should avoid having 2-3 commits to address “trailing
>> space issues”...
>> - Review and keep an eye on the comments of Jira stories
>> - Review and advise on existing stories; create new ones where we see
>> room for improvements
>>
>> I’m hoping some of you can lend a helping hand and we can share this
>> workload!
>>
>> Regards,
>> Adam
>
>
Re: Increased number of PRs and contributions
Posted by Jose Alberto Hernandez <jo...@gmail.com>.
I can help with some PR reviews and start the GA (only when you let me know
to avoid running them many times)
Thanks and best regards
Alberto
On Thu, Mar 19, 2026 at 4:30 AM Ádám Sághy <ad...@gmail.com> wrote:
> Hi everyone,
>
> This situation has some good news and a few things to we need to figure
> out:
> - I see an increased number of PRs, and contributions.
>
> So, what’s the challenge?
>
> I could really use some extra help to keep everything running smoothly:
> - Need to approve and start GitHub Actions on the PRs. (you need committer
> permission for this)
> - Review these PRs and advise on them
> - We are looking for green CI build
> - Functionality is tested
> - PR is addressing 1 particular issue / functionality
> - Commits are in order:
> - We should avoid having 2-3 commits to address “trailing
> space issues”...
> - Review and keep an eye on the comments of Jira stories
> - Review and advise on existing stories; create new ones where we see room
> for improvements
>
> I’m hoping some of you can lend a helping hand and we can share this
> workload!
>
> Regards,
> Adam
Re: Increased number of PRs and contributions
Posted by KRISHNA MEWARA <kr...@gmail.com>.
Hi Adam, I'd be happy to help out. I'm familiar with Fineract's testing
pipelines and Jira workflows, so I can definitely assist with reviewing PRs
and keeping an eye on the stories.
On Thu, 19 Mar, 2026, 15:28 Pragati, <pr...@gmail.com> wrote:
> I would love to help!
> On Thu, 19 Mar 2026 at 3:00 PM, Ádám Sághy <ad...@gmail.com> wrote:
>
>> Hi everyone,
>>
>> This situation has some good news and a few things to we need to figure
>> out:
>> - I see an increased number of PRs, and contributions.
>>
>> So, what’s the challenge?
>>
>> I could really use some extra help to keep everything running smoothly:
>> - Need to approve and start GitHub Actions on the PRs. (you need
>> committer permission for this)
>> - Review these PRs and advise on them
>> - We are looking for green CI build
>> - Functionality is tested
>> - PR is addressing 1 particular issue / functionality
>> - Commits are in order:
>> - We should avoid having 2-3 commits to address “trailing
>> space issues”...
>> - Review and keep an eye on the comments of Jira stories
>> - Review and advise on existing stories; create new ones where we see
>> room for improvements
>>
>> I’m hoping some of you can lend a helping hand and we can share this
>> workload!
>>
>> Regards,
>> Adam
>
>
Re: Increased number of PRs and contributions
Posted by Pragati <pr...@gmail.com>.
I would love to help!
On Thu, 19 Mar 2026 at 3:00 PM, Ádám Sághy <ad...@gmail.com> wrote:
> Hi everyone,
>
> This situation has some good news and a few things to we need to figure
> out:
> - I see an increased number of PRs, and contributions.
>
> So, what’s the challenge?
>
> I could really use some extra help to keep everything running smoothly:
> - Need to approve and start GitHub Actions on the PRs. (you need committer
> permission for this)
> - Review these PRs and advise on them
> - We are looking for green CI build
> - Functionality is tested
> - PR is addressing 1 particular issue / functionality
> - Commits are in order:
> - We should avoid having 2-3 commits to address “trailing
> space issues”...
> - Review and keep an eye on the comments of Jira stories
> - Review and advise on existing stories; create new ones where we see room
> for improvements
>
> I’m hoping some of you can lend a helping hand and we can share this
> workload!
>
> Regards,
> Adam