[GitHub] [struts] lukaszlenart commented on a diff in pull request #665: WW-5266 Implement struts.multipart.maxFileSize

["lukaszlenart (via GitHub)" <gi...@apache.org>]

lukaszlenart commented on code in PR #665:
URL: https://github.com/apache/struts/pull/665#discussion_r1133057690


##########
core/src/main/resources/org/apache/struts2/default.properties:
##########
@@ -69,6 +69,7 @@ struts.multipart.parser=jakarta
 struts.multipart.saveDir=
 struts.multipart.maxSize=2097152
 struts.multipart.maxFiles=256
+struts.multipart.maxFileSize=2097152

Review Comment:
   Makes sense, and also this option somehow duplicates what we have on the interceptor level - so this is a global config, which takes precedence over the interceptor configuration.
   
   I would just comment out this line and use `null` as a indicator to mark this option disabled to match the same behaviour for other options.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org