You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/05 12:31:00 UTC

[GitHub] [airflow] bbovenzi commented on a diff in pull request #28686: Update gantt chart UI to display queued state of tasks

bbovenzi commented on code in PR #28686:
URL: https://github.com/apache/airflow/pull/28686#discussion_r1062421784


##########
airflow/www/static/js/gantt.js:
##########
@@ -157,9 +164,19 @@ d3.gantt = () => {
         if (!(a.end_date instanceof moment)) {
           a.end_date = moment(a.end_date);
         }
+        if (a.queued_dttm) {

Review Comment:
   ```suggestion
           if (a.queued_dttm && !(a.queued_dttm instanceof moment)) {
   ```
   You can combine the if statements



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org