You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by David Reiss <dr...@facebook.com> on 2009/05/08 21:21:23 UTC
Thrift 0.1.0-RC1
http://people.apache.org/~dreiss/thrift-0.1.0-rc1.tar.gz
Note that it untars into a directory called thrift-0.1-dev.
The final version will untar into "thrift-0.1.0"
--David
Re: Thrift 0.1.0-RC1
Posted by Kevin Clark <ke...@gmail.com>.
On Mon, May 11, 2009 at 11:42 AM, David Reiss <dr...@facebook.com> wrote:
> Are we even supposed to tag RCs? Seems like a pain.
>
> Kevin Clark wrote:
>> On Mon, May 11, 2009 at 11:17 AM, David Reiss <dr...@facebook.com> wrote:
>>> Oh, but it wasn't added to EXTRA_DIST, so it isn't in the tarball.
>>> Will fix.
>>
>> I *didn't* tag the RC since you were bundling it up. Should we tag it
>> before we merge in changes from trunk?
>>
>
Hadoop seems to:
http://wiki.apache.org/hadoop/HowToRelease
Doesn't necessarily mean we should, but being able to match up rev to
tarball would make sense in my mind.
--
Kevin Clark
http://glu.ttono.us
Re: Thrift 0.1.0-RC1
Posted by Doug Cutting <cu...@apache.org>.
David Reiss wrote:
> Are we even supposed to tag RCs? Seems like a pain.
There's certainly no Apache requirement to. Apache releases source code
in archive files, not through SVN. But it's certainly a good idea to
tag final releases, and it may be useful to tag RC's even if only
temporarily.
Doug
Re: Thrift 0.1.0-RC1
Posted by David Reiss <dr...@facebook.com>.
Are we even supposed to tag RCs? Seems like a pain.
Kevin Clark wrote:
> On Mon, May 11, 2009 at 11:17 AM, David Reiss <dr...@facebook.com> wrote:
>> Oh, but it wasn't added to EXTRA_DIST, so it isn't in the tarball.
>> Will fix.
>
> I *didn't* tag the RC since you were bundling it up. Should we tag it
> before we merge in changes from trunk?
>
Re: Thrift 0.1.0-RC1
Posted by Kevin Clark <ke...@gmail.com>.
On Mon, May 11, 2009 at 11:17 AM, David Reiss <dr...@facebook.com> wrote:
> Oh, but it wasn't added to EXTRA_DIST, so it isn't in the tarball.
> Will fix.
I *didn't* tag the RC since you were bundling it up. Should we tag it
before we merge in changes from trunk?
--
Kevin Clark
http://glu.ttono.us
Re: Thrift 0.1.0-RC1
Posted by David Reiss <dr...@facebook.com>.
See THRIFT-373. Some verification from the Perl guys would be great
(per THRIFT-461).
David Reiss wrote:
> Oh, but it wasn't added to EXTRA_DIST, so it isn't in the tarball.
> Will fix.
>
> David Reiss wrote:
>> It was checked in: http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=f08c0a3
>>
>> Todd Lipcon wrote:
>>> On Sat, May 9, 2009 at 7:14 PM, Kevin Clark <ke...@gmail.com> wrote:
>>>
>>>> No ivy:settings found for the default reference 'ivy.instance'. A
>>>> default instance will be used
>>>> no settings file found, using default...
>>>> [ivy:retrieve] :: Ivy 2.0.0-rc2 - 20081028224207 ::
>>>> http://ant.apache.org/ivy/ ::
>>>> :: loading settings :: url =
>>>>
>>>> jar:file:/Users/kev/code/thrift-rc/thrift-0.1-dev/lib/java/build/ivy/ivy-2.0.0-rc2.jar!/org/apache/ivy/core/settings/ivysettings.xml
>>>> [ivy:retrieve] /Users/kev/code/thrift-rc/thrift-0.1-dev/lib/java/ivy.xml
>>>> (No such file or directory) in
>>>> file:/Users/kev/code/thrift-rc/thrift-0.1-dev/lib/java/ivy.xml
>>>>
>>> Hmm, is it possible that lib/java/ivy.xml didn't get checked into svn? I'm
>>> not on the right machine at the moment to check, but it should have been in
>>> the patch I uploaded for that JIRA.
>>>
>>> -Todd
Re: Thrift 0.1.0-RC1
Posted by David Reiss <dr...@facebook.com>.
Oh, but it wasn't added to EXTRA_DIST, so it isn't in the tarball.
Will fix.
David Reiss wrote:
> It was checked in: http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=f08c0a3
>
> Todd Lipcon wrote:
>> On Sat, May 9, 2009 at 7:14 PM, Kevin Clark <ke...@gmail.com> wrote:
>>
>>> No ivy:settings found for the default reference 'ivy.instance'. A
>>> default instance will be used
>>> no settings file found, using default...
>>> [ivy:retrieve] :: Ivy 2.0.0-rc2 - 20081028224207 ::
>>> http://ant.apache.org/ivy/ ::
>>> :: loading settings :: url =
>>>
>>> jar:file:/Users/kev/code/thrift-rc/thrift-0.1-dev/lib/java/build/ivy/ivy-2.0.0-rc2.jar!/org/apache/ivy/core/settings/ivysettings.xml
>>> [ivy:retrieve] /Users/kev/code/thrift-rc/thrift-0.1-dev/lib/java/ivy.xml
>>> (No such file or directory) in
>>> file:/Users/kev/code/thrift-rc/thrift-0.1-dev/lib/java/ivy.xml
>>>
>> Hmm, is it possible that lib/java/ivy.xml didn't get checked into svn? I'm
>> not on the right machine at the moment to check, but it should have been in
>> the patch I uploaded for that JIRA.
>>
>> -Todd
>
Re: Thrift 0.1.0-RC1
Posted by David Reiss <dr...@facebook.com>.
It was checked in: http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=f08c0a3
Todd Lipcon wrote:
> On Sat, May 9, 2009 at 7:14 PM, Kevin Clark <ke...@gmail.com> wrote:
>
>> No ivy:settings found for the default reference 'ivy.instance'. A
>> default instance will be used
>> no settings file found, using default...
>> [ivy:retrieve] :: Ivy 2.0.0-rc2 - 20081028224207 ::
>> http://ant.apache.org/ivy/ ::
>> :: loading settings :: url =
>>
>> jar:file:/Users/kev/code/thrift-rc/thrift-0.1-dev/lib/java/build/ivy/ivy-2.0.0-rc2.jar!/org/apache/ivy/core/settings/ivysettings.xml
>> [ivy:retrieve] /Users/kev/code/thrift-rc/thrift-0.1-dev/lib/java/ivy.xml
>> (No such file or directory) in
>> file:/Users/kev/code/thrift-rc/thrift-0.1-dev/lib/java/ivy.xml
>>
>
> Hmm, is it possible that lib/java/ivy.xml didn't get checked into svn? I'm
> not on the right machine at the moment to check, but it should have been in
> the patch I uploaded for that JIRA.
>
> -Todd
Re: Thrift 0.1.0-RC1
Posted by Todd Lipcon <to...@cloudera.com>.
On Sat, May 9, 2009 at 7:14 PM, Kevin Clark <ke...@gmail.com> wrote:
> No ivy:settings found for the default reference 'ivy.instance'. A
> default instance will be used
> no settings file found, using default...
> [ivy:retrieve] :: Ivy 2.0.0-rc2 - 20081028224207 ::
> http://ant.apache.org/ivy/ ::
> :: loading settings :: url =
>
> jar:file:/Users/kev/code/thrift-rc/thrift-0.1-dev/lib/java/build/ivy/ivy-2.0.0-rc2.jar!/org/apache/ivy/core/settings/ivysettings.xml
> [ivy:retrieve] /Users/kev/code/thrift-rc/thrift-0.1-dev/lib/java/ivy.xml
> (No such file or directory) in
> file:/Users/kev/code/thrift-rc/thrift-0.1-dev/lib/java/ivy.xml
>
Hmm, is it possible that lib/java/ivy.xml didn't get checked into svn? I'm
not on the right machine at the moment to check, but it should have been in
the patch I uploaded for that JIRA.
-Todd
Re: Thrift 0.1.0-RC1
Posted by Kevin Clark <ke...@gmail.com>.
On Sat, May 9, 2009 at 12:20 AM, Michael Greene
<mi...@gmail.com> wrote:
> [...]
>
> Also, make fails on a bunch of gettext file dependencies for me, but
> this could very easily be something I did that I just don't
> understand. Is this just me?
I get the perl makefile missing error but not the gettext errors. That
might be because I blow up on java first:
No ivy:settings found for the default reference 'ivy.instance'. A
default instance will be used
no settings file found, using default...
[ivy:retrieve] :: Ivy 2.0.0-rc2 - 20081028224207 ::
http://ant.apache.org/ivy/ ::
:: loading settings :: url =
jar:file:/Users/kev/code/thrift-rc/thrift-0.1-dev/lib/java/build/ivy/ivy-2.0.0-rc2.jar!/org/apache/ivy/core/settings/ivysettings.xml
[ivy:retrieve] /Users/kev/code/thrift-rc/thrift-0.1-dev/lib/java/ivy.xml
(No such file or directory) in
file:/Users/kev/code/thrift-rc/thrift-0.1-dev/lib/java/ivy.xml
BUILD FAILED
/Users/kev/code/thrift-rc/thrift-0.1-dev/lib/java/build.xml:106:
syntax errors in ivy file: java.text.ParseException:
/Users/kev/code/thrift-rc/thrift-0.1-dev/lib/java/ivy.xml (No such
file or directory) in
file:/Users/kev/code/thrift-rc/thrift-0.1-dev/lib/java/ivy.xml
Though it looks like right now in trunk I'm getting a cpp error, so
it's possible the machine I'm on is misconfigured somehow.
--
Kevin Clark
http://glu.ttono.us
Re: Thrift 0.1.0-RC1
Posted by Michael Greene <mi...@gmail.com>.
On Fri, May 8, 2009 at 2:45 PM, Upayavira <uv...@odoko.co.uk> wrote:
> On Fri, 2009-05-08 at 12:21 -0700, David Reiss wrote:
>> http://people.apache.org/~dreiss/thrift-0.1.0-rc1.tar.gz
>>
>> Note that it untars into a directory called thrift-0.1-dev.
>> The final version will untar into "thrift-0.1.0"
>
> First, thanks David!
Indeed, thanks David for getting a release candidate out.
> So, people, please start reviewing this tarball, and let us know your
> observations. Should we submit it to the incubator now as is, or are
> there things you think we should address?
It looks like the release tarball does not include lib/perl/test and
probably should, based on this error: "config.status: error: cannot
find input file: lib/perl/test/Makefile.in"
Additionally, I have opened THRIFT-494 to address the Python
versioning and other minor metadata that I think should be handled
correctly before a final release.
Also, make fails on a bunch of gettext file dependencies for me, but
this could very easily be something I did that I just don't
understand. Is this just me?
Michael
Re: Thrift 0.1.0-RC1
Posted by Upayavira <uv...@odoko.co.uk>.
On Fri, 2009-05-08 at 12:21 -0700, David Reiss wrote:
> http://people.apache.org/~dreiss/thrift-0.1.0-rc1.tar.gz
>
> Note that it untars into a directory called thrift-0.1-dev.
> The final version will untar into "thrift-0.1.0"
First, thanks David!
So, I guess it is worth noting a few things about this:
* This is _NOT_ a release
* It is for us to review as a possible base for a review.
Therefore, please review it from two perspectives:
* legal/licensing
* code quality/bugs
Legal and licensing are the only that need to be sorted for us to make a
release, however I guess it would be kind to our users to try to ensure
we've fixed any major bugs!
Once we, here, are happy with the quality (as described above) of this
tarball, we will take it to the Incubator PMC (on the general@incubar)
list to get it ratified. Once done, we'll have a release done.
So, people, please start reviewing this tarball, and let us know your
observations. Should we submit it to the incubator now as is, or are
there things you think we should address?
Regards, Upayavira
Re: Thrift 0.1.0-RC1
Posted by Mathias Herberts <ma...@gmail.com>.
On Fri, May 8, 2009 at 21:21, David Reiss <dr...@facebook.com> wrote:
> http://people.apache.org/~dreiss/thrift-0.1.0-rc1.tar.gz
>
> Note that it untars into a directory called thrift-0.1-dev.
> The final version will untar into "thrift-0.1.0"
Thanks for putting that together.
I must have missed something, last time I looked the java lib did not
rely on ivy for building. Now that it does it doesn't build on my
machine anymore!