You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shenyu.apache.org by GitBox <gi...@apache.org> on 2021/06/20 12:03:33 UTC
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1654: [ISSUE #1653] Refactor Code about client register.
codecov-commenter edited a comment on pull request #1654:
URL: https://github.com/apache/incubator-shenyu/pull/1654#issuecomment-864543100
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1654](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f4d0803) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/9011e97465e574d7e69691eb7251f7766b5f2099?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9011e97) will **decrease** coverage by `2.88%`.
> The diff coverage is `13.25%`.
> :exclamation: Current head f4d0803 differs from pull request most recent head ffb8d61. Consider uploading reports for the commit ffb8d61 to get more accurate results
[](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1654 +/- ##
============================================
- Coverage 62.81% 59.93% -2.89%
- Complexity 2220 2225 +5
============================================
Files 460 469 +9
Lines 9547 10073 +526
Branches 976 1021 +45
============================================
+ Hits 5997 6037 +40
- Misses 3057 3551 +494
+ Partials 493 485 -8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...enyu/admin/config/RegisterCenterConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29uZmlnL1JlZ2lzdGVyQ2VudGVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
| [...in/disruptor/RegisterServerDisruptorPublisher.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZGlzcnVwdG9yL1JlZ2lzdGVyU2VydmVyRGlzcnVwdG9yUHVibGlzaGVyLmphdmE=) | `85.71% <ø> (ø)` | |
| [.../register/AbstractShenyuClientRegisterService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9BYnN0cmFjdFNoZW55dUNsaWVudFJlZ2lzdGVyU2VydmljZS5qYXZh) | `2.08% <2.08%> (ø)` | |
| [...ster/ShenyuClientRegisterSpringMVCServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ01WQ1NlcnZpY2VJbXBsLmphdmE=) | `11.11% <11.11%> (ø)` | |
| [...er/ShenyuClientRegisterSpringCloudServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ0Nsb3VkU2VydmljZUltcGwuamF2YQ==) | `12.30% <12.30%> (ø)` | |
| [.../register/ShenyuClientRegisterTarsServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclRhcnNTZXJ2aWNlSW1wbC5qYXZh) | `12.82% <12.82%> (ø)` | |
| [.../register/ShenyuClientRegisterGrpcServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlckdycGNTZXJ2aWNlSW1wbC5qYXZh) | `13.69% <13.69%> (ø)` | |
| [...register/ShenyuClientRegisterMotanServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3Rlck1vdGFuU2VydmljZUltcGwuamF2YQ==) | `13.69% <13.69%> (ø)` | |
| [.../register/ShenyuClientRegisterSofaServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNvZmFTZXJ2aWNlSW1wbC5qYXZh) | `16.32% <16.32%> (ø)` | |
| [...register/ShenyuClientRegisterDubboServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlckR1YmJvU2VydmljZUltcGwuamF2YQ==) | `18.60% <18.60%> (ø)` | |
| ... and [18 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9011e97...ffb8d61](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org