You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/12/09 17:43:57 UTC
[GitHub] [accumulo] DomGarguilo opened a new pull request #1833: Fixes #1760 - `listcompactions` command error is not helpful
DomGarguilo opened a new pull request #1833:
URL: https://github.com/apache/accumulo/pull/1833
Fixing issue #1760. Adding more helpful error messages for the listcompactions command when a tserver address is passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #1833: Fixes #1760 - `listcompactions` command error is not helpful
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #1833:
URL: https://github.com/apache/accumulo/pull/1833#discussion_r539516116
##########
File path: core/src/main/java/org/apache/accumulo/core/util/HostAndPort.java
##########
@@ -105,7 +105,7 @@ public boolean hasPort() {
* occurring.
*/
public int getPort() {
- checkState(hasPort());
+ checkState(hasPort(), "The given address does not include a port");
Review comment:
Just a minor wording suggestion:
```suggestion
checkState(hasPort(), "the address does not include a port");
```
The reason for this is that the exception could also occur when the user has not "given" any address. For example, if it's our own internal code. In that case, the word "given" might be confusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #1833: Fixes #1760 - `listcompactions` command error is not helpful
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #1833:
URL: https://github.com/apache/accumulo/pull/1833#discussion_r539616431
##########
File path: shell/src/main/java/org/apache/accumulo/shell/commands/ActiveCompactionHelper.java
##########
@@ -86,6 +90,7 @@ private static String formatActiveCompactionLine(String tserver, ActiveCompactio
compactions.add(formatActiveCompactionLine(tserver, ac));
}
} catch (Exception e) {
+ log.debug("Exception thrown while attempting to list active compactions", e);
Review comment:
```suggestion
log.debug("Failed to list active compactions for server {}", tserver, e);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii merged pull request #1833: Fixes #1760 - `listcompactions` command error is not helpful
Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #1833:
URL: https://github.com/apache/accumulo/pull/1833
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #1833: Fixes #1760 - `listcompactions` command error is not helpful
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #1833:
URL: https://github.com/apache/accumulo/pull/1833#discussion_r539616431
##########
File path: shell/src/main/java/org/apache/accumulo/shell/commands/ActiveCompactionHelper.java
##########
@@ -86,6 +90,7 @@ private static String formatActiveCompactionLine(String tserver, ActiveCompactio
compactions.add(formatActiveCompactionLine(tserver, ac));
}
} catch (Exception e) {
+ log.debug("Exception thrown while attempting to list active compactions", e);
Review comment:
```suggestion
log.debug("Error attempting to list active compactions for server {}", tserver, e);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org