[hbase] branch master updated: HBASE-24567 Create release should url-encode all characters when building git uri

[nd...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ndimiduk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/master by this push:
     new 90b339a  HBASE-24567 Create release should url-encode all characters when building git uri
90b339a is described below

commit 90b339a4f2e959f5e7a28237f2b591f40bebb3d5
Author: Nick Dimiduk <nd...@apache.org>
AuthorDate: Mon Jun 22 15:22:21 2020 -0700

    HBASE-24567 Create release should url-encode all characters when building git uri
    
    By default, `urllib.quote` will skipp over `/` characters, which are
    valid for use in passwords.
    
    Signed-off-by: stack <st...@apache.org>
    Signed-off-by: Matt Foley <ma...@apache.org>
---
 dev-support/create-release/release-util.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dev-support/create-release/release-util.sh b/dev-support/create-release/release-util.sh
index 2297ee7..3e9506b 100755
--- a/dev-support/create-release/release-util.sh
+++ b/dev-support/create-release/release-util.sh
@@ -412,8 +412,8 @@ function git_clone_overwrite {
     echo "[INFO] clone will be of the gitbox repo for ${PROJECT}."
     if [ -n "${ASF_USERNAME}" ] && [ -n "${ASF_PASSWORD}" ]; then
       # Ugly!
-      encoded_username=$(python -c "import urllib; print urllib.quote('''$ASF_USERNAME''')")
-      encoded_password=$(python -c "import urllib; print urllib.quote('''$ASF_PASSWORD''')")
+      encoded_username=$(python -c "import urllib; print urllib.quote('''$ASF_USERNAME''', '')")
+      encoded_password=$(python -c "import urllib; print urllib.quote('''$ASF_PASSWORD''', '')")
       GIT_REPO="https://$encoded_username:$encoded_password@${asf_repo}"
     else
       GIT_REPO="https://${asf_repo}"