You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/08/02 16:19:05 UTC

[GitHub] [incubator-druid] leventov commented on a change in pull request #8129: Spotbugs: NP_NONNULL_PARAM_VIOLATION

leventov commented on a change in pull request #8129: Spotbugs: NP_NONNULL_PARAM_VIOLATION
URL: https://github.com/apache/incubator-druid/pull/8129#discussion_r310203416
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/query/groupby/strategy/GroupByStrategyV2.java
 ##########
 @@ -377,7 +377,7 @@ public Row apply(final Row row)
       );
     }
     catch (Exception ex) {
-      Lists.reverse(closeOnExit).forEach(closeable -> CloseQuietly.close(closeable));
+      Lists.reverse(closeOnExit).forEach(CloseQuietly::close);
 
 Review comment:
   I've created #8226 about this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org