You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "mlbiscoc (via GitHub)" <gi...@apache.org> on 2026/04/21 18:38:06 UTC
[PR] SOLR-18181: ValueSourceAugmenter NPE when rows exceed 1000 and scores requested [solr]
mlbiscoc opened a new pull request, #4314:
URL: https://github.com/apache/solr/pull/4314
Trying to send a query with ValueSourceAugmenter that requested score and > 1000 rows resulted in an NPE. This is because when it passes prefetch limit and tries to retrieve score, it was referenced incorrectly.
ValueSourceAugmenter was overriding a deprecated 2-arg method which didn't have access to score. The method then incorrectly tried to get score via `(float) doc.get("score")`
To fix, we override the non-deprecated method instead which actually has `DocIterationInfo` to get the score.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18181: ValueSourceAugmenter NPE when rows exceed 1000 and scores requested [solr]
Posted by "mlbiscoc (via GitHub)" <gi...@apache.org>.
mlbiscoc merged PR #4314:
URL: https://github.com/apache/solr/pull/4314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18181: ValueSourceAugmenter NPE when rows exceed 1000 and scores requested [solr]
Posted by "mlbiscoc (via GitHub)" <gi...@apache.org>.
mlbiscoc commented on code in PR #4314:
URL: https://github.com/apache/solr/pull/4314#discussion_r3149768335
##########
changelog/unreleased/SOLR-18181-ValueSourceAugmenter-npe.yml:
##########
@@ -0,0 +1,7 @@
+title: Fix NPE in ValueSourceAugmenter when rows exceed prefetch limit with scores requested
Review Comment:
Thats a good point. Made another [PR](https://github.com/apache/solr/pull/4372) to better the description towards users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18181: ValueSourceAugmenter NPE when rows exceed 1000 and scores requested [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on code in PR #4314:
URL: https://github.com/apache/solr/pull/4314#discussion_r3135057153
##########
changelog/unreleased/SOLR-18181-ValueSourceAugmenter-npe.yml:
##########
@@ -0,0 +1,7 @@
+title: Fix NPE in ValueSourceAugmenter when rows exceed prefetch limit with scores requested
Review Comment:
End users (who generally aren't Solr hackers) have no idea what ValueSourceAugmenter even is; it's an internal thing. They *do* know about use of function queries in the "fl". In the changelog we should try to explain the impact when we can, like:
> Use of function queries in "fl" would fail if rows exceeds 1000 and scores requested. A regression since v9.9.
Here, users would then see this for the serious regression that this is:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org