You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "dmitryor (via GitHub)" <gi...@apache.org> on 2024/03/15 23:31:25 UTC
[PR] Include byte size of stateKey in estimated weight of WindmillBag, WindmillValue, and WindmillWatermarkHold [beam]
dmitryor opened a new pull request, #30654:
URL: https://github.com/apache/beam/pull/30654
Include byte size of stateKey in estimated weight of WindmillBag, WindmillValue, and WindmillWatermarkHold
The weight is used to track and limit the total StateCache memory size. For certain workloads stateKey consitutes major portion of total memory pinned by cache entries. Not including it into the weight results in severe underestimate of the real cache size, and may leads to GC thrashing and eventually to workers crashing OOM.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include byte size of stateKey in estimated weight of WindmillBag, WindmillValue, and WindmillWatermarkHold [beam]
Posted by "dmitryor (via GitHub)" <gi...@apache.org>.
dmitryor commented on PR #30654:
URL: https://github.com/apache/beam/pull/30654#issuecomment-2000640705
R: @arunpandianp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include byte size of stateKey in estimated weight of WindmillBag, WindmillValue, and WindmillWatermarkHold [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30654:
URL: https://github.com/apache/beam/pull/30654#issuecomment-2000644120
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include byte size of stateKey in estimated weight of WindmillBag, WindmillValue, and WindmillWatermarkHold [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #30654:
URL: https://github.com/apache/beam/pull/30654#issuecomment-2004669097
```
org.apache.beam.sdk.util.UnboundedScheduledExecutorServiceTest > testThreadsAreAddedOnlyAsNeededWithContention FAILED
java.lang.AssertionError at UnboundedScheduledExecutorServiceTest.java:556
```
unrelated flaky test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include byte size of stateKey in estimated weight of WindmillBag, WindmillValue, and WindmillWatermarkHold [beam]
Posted by "scwhittle (via GitHub)" <gi...@apache.org>.
scwhittle commented on PR #30654:
URL: https://github.com/apache/beam/pull/30654#issuecomment-2003324742
From precommit logs it appears the tests need to be updated
```
org.apache.beam.runners.dataflow.worker.windmill.state.WindmillStateInternalsTest > testCachedCombining FAILED
java.lang.AssertionError at WindmillStateInternalsTest.java:3188
> Task :runners:google-cloud-dataflow-java:worker:test
org.apache.beam.runners.dataflow.worker.windmill.state.WindmillStateInternalsTest > testCachedBag FAILED
java.lang.AssertionError at WindmillStateInternalsTest.java:3086
org.apache.beam.runners.dataflow.worker.windmill.state.WindmillStateInternalsTest > testCachedWatermarkHold FAILED
java.lang.AssertionError at WindmillStateInternalsTest.java:3148
org.apache.beam.runners.dataflow.worker.windmill.state.WindmillStateInternalsTest > testCachedValue FAILED
java.lang.AssertionError at WindmillStateInternalsTest.java:3046
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include byte size of stateKey in estimated weight of WindmillBag, WindmillValue, and WindmillWatermarkHold [beam]
Posted by "dmitryor (via GitHub)" <gi...@apache.org>.
dmitryor commented on PR #30654:
URL: https://github.com/apache/beam/pull/30654#issuecomment-2004594496
R: @scwhittle fixed the test, thank you for pointing to it, still learning workflows for Beam on GitHub.
The test is inherently fragile, but I'm not sure how to improve it without major rework.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include byte size of stateKey in estimated weight of WindmillBag, WindmillValue, and WindmillWatermarkHold [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #30654:
URL: https://github.com/apache/beam/pull/30654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org