You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Pedro Giffuni <pf...@apache.org> on 2011/11/17 04:04:42 UTC
Heads up: KDE Crystal Icon set going away.
Hello;
This one is a little more difficult than the Oxygen set
because the details of the original commit are lost in
CVS and the icons have been able to grow deeper roots.
I tried to verify the origin and I traced those icons
to:
https://issues.apache.org/ooo/show_bug.cgi?id=60434
Apparently they were "partially JCA covered", for
whatever that means.
The good news is that in KDE my patch will replace
them with the Tango icon set :
http://tango.freedesktop.org/Tango_Showroom
which is already used in gnome, and that will
ultimately make Apache OpenOffice more
consistent in all desktop environments.
I will commit the change tomorrow morning (ET)
because I want to be awake in case a fix is
needed.
Pedro.
ps. I am attaching the 4k patch but I doubt it
pass through the mailing list.
Re: Heads up: KDE Crystal Icon set going away.
Posted by "Pedro F. Giffuni" <gi...@yahoo.com>.
--- On Thu, 11/17/11, Ariel Constenla-Haile <ar...@apache.org> wrote:
>
> IMO the tango icons look uglier than the Galaxy icon set,
> but it's just
> a question of taste. And the Galaxy is the only one we can
> be sure that
> has all the required icons. (try the tango icon set and
> you'll see that
> OOo still uses some Galaxy icons for the missing icons).
> What happens now in OOo from Oracle's times if you remove
> the crystal icon set
> from OOo installation? ... it will default to the default
> icon set; your
> patch was changing the existing behaviour.
>
OK, you convinced me. :)
> On the other hand, AOO is removing copy left stuff from the
> source code,
> but not removing the functionality in the OOo side, that is
> fine as it
> is code now under the AL. So it seems that the approach
> with the images
> should be to add some configure switches to enable them
> providing some
> --with-system-crystal-icons or --with-system-icons etc.
>
OK, but that doesnt look easy. I will have to think
of something that is not ugly and we still cant ship
LGPL :(
Pedro.
Re: Heads up: KDE Crystal Icon set going away.
Posted by Ariel Constenla-Haile <ar...@apache.org>.
Hi Pedro,
On Thu, Nov 17, 2011 at 05:37:31PM -0800, Pedro Giffuni wrote:
> > remove the else and kde will default to OOo's default
> > (Galaxy).
>
> I would be really afraid of existing users recalling the
> icons as too old-stylish. The Tango icons are not really
> Gnome specific, they specifically mention KDE in their
> website.
IMO the tango icons look uglier than the Galaxy icon set, but it's just
a question of taste. And the Galaxy is the only one we can be sure that
has all the required icons. (try the tango icon set and you'll see that
OOo still uses some Galaxy icons for the missing icons).
What happens now in OOo from Oracle's times if you remove the crystal icon set
from OOo installation? ... it will default to the default icon set; your
patch was changing the existing behaviour.
On the other hand, AOO is removing copy left stuff from the source code,
but not removing the functionality in the OOo side, that is fine as it
is code now under the AL. So it seems that the approach with the images
should be to add some configure switches to enable them providing some
--with-system-crystal-icons or --with-system-icons etc.
Regards
--
Ariel Constenla-Haile
La Plata, Argentina
Re: Heads up: KDE Crystal Icon set going away.
Posted by Pedro Giffuni <pf...@apache.org>.
--- On Thu, 11/17/11, Ariel Constenla-Haile <ar...@apache.org> wrote:
>
> remove the else and kde will default to OOo's default
> (Galaxy).
I would be really afraid of existing users recalling the
icons as too old-stylish. The Tango icons are not really
Gnome specific, they specifically mention KDE in their
website.
> May be a cleaner solution is a configure option to enable
> those
> themes in the build and surround the code with ifdefs?
>
I dont know: I have to review this change much more
carefully than the Oxygen stuff. I will probably fix
whatever went wrong and leave it in BZ for someone else
to commit and deal with the "I want skins" bikeshed ;).
Cheers,
Pedro.
Ps. I will also reenable binfilter soon: some code
there will likely need touching and we dont want this
unadvertedly broken before the release. I know you
use --enable-binfilter so dont be surprised when its
reenabled by default again ;).
Re: Heads up: KDE Crystal Icon set going away.
Posted by Ariel Constenla-Haile <ar...@apache.org>.
Hi Pedro,
On Thu, Nov 17, 2011 at 10:31:44AM -0800, Pedro Giffuni wrote:
> > > The good news is that in KDE my patch will replace
> > > them with the Tango icon set :
> > > http://tango.freedesktop.org/Tango_Showroom
> > >
> > > which is already used in gnome, and that will
> > > ultimately make Apache OpenOffice more
> > > consistent in all desktop environments.
> >
> > IMO this is a bad idea. If the default KDE icons (by the
> > way, AFAIK this is hard-coded, not retrieved from the
> > vcl plugin) are gone, then KDE
> > should have the OOo default icons, not Gnome icons.
> >
>
> We only have control over the style symbols here:
>
> http://svn.apache.org/viewvc/incubator/ooo/trunk/main/vcl/source/app/settings.cxx?sortby=date&r1=1203215&r2=1203214&pathrev=1203215
>
> Tango Desktop icons are meant to be used by both KDE and
> Gnome and I don't think there's a way to make the icons
> pluggable :(. Let me know if you have a better solution.
not sure if better, but IMO kde should default to OOo's default, not
gnome's icon theme.
In StyleSettings::GetAutoSymbolsStyle() it was:
if( bCont )
{
if( rDesktopEnvironment.equalsIgnoreAsciiCaseAscii( "gnome" ) )
nRet = STYLE_SYMBOLS_TANGO;
else if( rDesktopEnvironment.equalsIgnoreAsciiCaseAscii( "kde" ) )
nRet = STYLE_SYMBOLS_CRYSTAL;
}
remove the else and kde will default to OOo's default (Galaxy).
May be a cleaner solution is a configure option to enable those
themes in the build and surround the code with ifdefs?
Regards
--
Ariel Constenla-Haile
La Plata, Argentina
Re: Heads up: KDE Crystal Icon set going away.
Posted by Pedro Giffuni <pf...@apache.org>.
--- On Thu, 11/17/11, Ariel Constenla-Haile <ar...@apache.org> wrote:
> >
> > The good news is that in KDE my patch will replace
> > them with the Tango icon set :
> > http://tango.freedesktop.org/Tango_Showroom
> >
> > which is already used in gnome, and that will
> > ultimately make Apache OpenOffice more
> > consistent in all desktop environments.
>
> IMO this is a bad idea. If the default KDE icons (by the
> way, AFAIK this is hard-coded, not retrieved from the
> vcl plugin) are gone, then KDE
> should have the OOo default icons, not Gnome icons.
>
We only have control over the style symbols here:
http://svn.apache.org/viewvc/incubator/ooo/trunk/main/vcl/source/app/settings.cxx?sortby=date&r1=1203215&r2=1203214&pathrev=1203215
Tango Desktop icons are meant to be used by both KDE and
Gnome and I don't think there's a way to make the icons
pluggable :(. Let me know if you have a better solution.
Pedro.
Re: Heads up: KDE Crystal Icon set going away.
Posted by Ariel Constenla-Haile <ar...@apache.org>.
On Wed, Nov 16, 2011 at 07:04:42PM -0800, Pedro Giffuni wrote:
> Hello;
>
> This one is a little more difficult than the Oxygen set
> because the details of the original commit are lost in
> CVS and the icons have been able to grow deeper roots.
>
> I tried to verify the origin and I traced those icons
> to:
> https://issues.apache.org/ooo/show_bug.cgi?id=60434
>
> Apparently they were "partially JCA covered", for
> whatever that means.
>
> The good news is that in KDE my patch will replace
> them with the Tango icon set :
> http://tango.freedesktop.org/Tango_Showroom
>
> which is already used in gnome, and that will
> ultimately make Apache OpenOffice more
> consistent in all desktop environments.
IMO this is a bad idea. If the default KDE icons (by the way, AFAIK this
is hard-coded, not retrieved from the vcl plugin) are gone, then KDE
should have the OOo default icons, not Gnome icons.
Regards
--
Ariel Constenla-Haile
La Plata, Argentina
Re: Heads up: KDE Crystal Icon set going away.
Posted by Pedro Giffuni <pf...@apache.org>.
Committed as revision 1203215.
--- On Wed, 11/16/11, Pedro Giffuni <pf...@apache.org> wrote:
> Hello;
>
> This one is a little more difficult than the Oxygen set
> because the details of the original commit are lost in
> CVS and the icons have been able to grow deeper roots.
>
> I tried to verify the origin and I traced those icons
> to:
> https://issues.apache.org/ooo/show_bug.cgi?id=60434
>
> Apparently they were "partially JCA covered", for
> whatever that means.
>
> The good news is that in KDE my patch will replace
> them with the Tango icon set :
> http://tango.freedesktop.org/Tango_Showroom
>
> which is already used in gnome, and that will
> ultimately make Apache OpenOffice more
> consistent in all desktop environments.
>
> I will commit the change tomorrow morning (ET)
> because I want to be awake in case a fix is
> needed.
>
> Pedro.
>